Fix: Enable keyboard avoiding view for Odometer tab on distance request page by MelvinBot · Pull Request #83580 · Expensify/App

MelvinBot · 2026-02-26T13:59:51Z

Explanation of Change

The ScreenWrapper in DistanceRequestStartPage had shouldEnableKeyboardAvoidingView hardcoded to false for all tabs. This was originally appropriate for the Map and Manual tabs (which don't use native keyboard TextInputs), but the newer Odometer tab has TextInput fields for Start/End readings that trigger the native keyboard. With keyboard avoidance disabled, the Next button was hidden behind the keyboard and unreachable on iOS and Android.

This change makes shouldEnableKeyboardAvoidingView conditional — it is enabled only when the Odometer tab (CONST.TAB_REQUEST.DISTANCE_ODOMETER) is selected, keeping behavior unchanged for all other tabs (Map, Manual, GPS).

Fixed Issues

$ #82647

Tests

Log in with an Expensifail account (with Odometer beta enabled).
Open FAB > Track distance > Odometer tab.
Tap the Start reading field — keyboard opens.
Verify the Next button is visible above the keyboard.
Enter a start reading, then tap the End reading field.
Verify the Next button remains visible above the keyboard.
Tap the Next button — verify it is tappable and navigates correctly.
Switch to the Map tab — verify the map works as before.
Switch to the Manual tab — verify it works as before.

Verify that no errors appear in the JS console

Offline tests

N/A — This is a UI layout fix for keyboard avoidance. The Odometer tab requires online access to submit, so offline behavior is unchanged.

QA Steps

Log in with an account that has the Odometer beta enabled.
Open FAB > Track distance > Odometer tab.
Tap the Start reading field.
Verify the Next button is visible above the keyboard (not hidden behind it).
Switch between Map, Manual, and Odometer tabs — verify each tab still works correctly.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…st page The ScreenWrapper in DistanceRequestStartPage had shouldEnableKeyboardAvoidingView set to false for all tabs. This was fine for Map and Manual tabs which don't use native keyboard TextInputs, but the Odometer tab has TextInput fields that trigger the keyboard. With keyboard avoidance disabled, the Next button was hidden behind the keyboard and unreachable. This change makes shouldEnableKeyboardAvoidingView conditional — it is enabled only when the Odometer tab is selected, keeping behavior unchanged for other tabs. Co-authored-by: DylanDylann <DylanDylann@users.noreply.github.com>

MelvinBot · 2026-02-26T14:00:10Z

I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-fixOdometerKeyboardAvoidingView
git checkout -b claude-fixOdometerKeyboardAvoidingView upstream/claude-fixOdometerKeyboardAvoidingView
git push -u origin claude-fixOdometerKeyboardAvoidingView

Then you can close this PR and open a new one from your fork.

DylanDylann · 2026-03-02T10:25:23Z

@MelvinBot Please merge the latest main and mark this PR as ready

…boardAvoidingView Co-authored-by: DylanDylann <DylanDylann@users.noreply.github.com>

melvin-bot · 2026-03-02T10:30:54Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MelvinBot · 2026-03-02T10:30:59Z

Done! I've merged the latest main into this branch and marked the PR as ready for review. ✅

DylanDylann · 2026-03-02T10:32:52Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

DylanDylann · 2026-03-02T10:33:08Z

@codex review

DylanDylann

LGTM

codecov · 2026-03-02T10:37:27Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/pages/iou/request/DistanceRequestStartPage.tsx	`0.00% <ø> (ø)`
... and 31 files with indirect coverage changes

chatgpt-codex-connector · 2026-03-02T10:41:09Z

Codex Review: Didn't find any major issues. What shall we delve into next?

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

joekaufmanexpensify

👍

github-actions · 2026-03-02T21:57:23Z

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-03-02T22:01:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-03-02T22:03:26Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83580.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-ab4df95-8beecd5-657aef86e7a14e2c19a6fe4e96dbdb636987a865/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-ab4df95-8beecd5-c4b8a017ffae572d07b4c2a4c2577f5d99e54a77/index.html

Web 🕸️
https://83580.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-02T23:03:44Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.28-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-04T03:18:32Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.30-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-04T18:08:53Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.30-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot assigned DylanDylann Feb 26, 2026

MelvinBot requested a review from a team February 26, 2026 13:59

MelvinBot mentioned this pull request Feb 26, 2026

[Odometer] [$250] Distance - Odometer - Next button is hidden behind the keyboard #82647

Closed

7 tasks

Merge remote-tracking branch 'origin/main' into claude-fixOdometerKey…

3adf0da

…boardAvoidingView Co-authored-by: DylanDylann <DylanDylann@users.noreply.github.com>

MelvinBot marked this pull request as ready for review March 2, 2026 10:30

MelvinBot requested a review from a team as a code owner March 2, 2026 10:30

melvin-bot bot requested review from DylanDylann and joekaufmanexpensify and removed request for a team March 2, 2026 10:30

DylanDylann approved these changes Mar 2, 2026

View reviewed changes

melvin-bot bot requested a review from Julesssss March 2, 2026 10:35

joekaufmanexpensify approved these changes Mar 2, 2026

View reviewed changes

Julesssss approved these changes Mar 2, 2026

View reviewed changes

Julesssss merged commit ab4df95 into main Mar 2, 2026
35 checks passed

Julesssss deleted the claude-fixOdometerKeyboardAvoidingView branch March 2, 2026 21:52

OSBotify mentioned this pull request Mar 2, 2026

Deploy Checklist: New Expensify 2026-03-02 #83947

Closed

Conversation

MelvinBot commented Feb 26, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Feb 26, 2026

Uh oh!

DylanDylann commented Mar 2, 2026

Uh oh!

melvin-bot bot commented Mar 2, 2026

Uh oh!

MelvinBot commented Mar 2, 2026

Uh oh!

DylanDylann commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann commented Mar 2, 2026

Uh oh!

DylanDylann left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Mar 2, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector bot commented Mar 2, 2026

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

OSBotify commented Mar 2, 2026

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

OSBotify commented Mar 2, 2026

Uh oh!

OSBotify commented Mar 4, 2026

Uh oh!

OSBotify commented Mar 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

DylanDylann commented Mar 2, 2026 •

edited

Loading

codecov bot commented Mar 2, 2026 •

edited by github-actions bot

Loading