[NO QA] Create .MD files with guidelines for writing help articles #83650
[NO QA] Create .MD files with guidelines for writing help articles #83650mjasikowski merged 5 commits intomainfrom
Conversation
|
A preview of your ExpensifyHelp changes have been deployed to https://8e9c6a49.helpdot.pages.dev ⚡️ Updated articles: |
|
@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
HelpDot Documentation ReviewOverall AssessmentThis PR introduces two new guideline documents intended to standardize how HelpDot articles are written: Scores Summary
Key FindingsInternal contradictions that must be resolved:
Conflicts with existing published articles:
Self-referential breadcrumb rule:
Missing YAML metadata on both files:
Inconsistent list indentation in HELP_AUTHORING_GUIDELINES.md:
Positive aspects worth highlighting:
Recommendations
Files Reviewed
|
|
Hi @stephanieelliott, I was tagged by the bot. Is there anything I can help with here? |
situchan
left a comment
There was a problem hiding this comment.
No need C+ review. Just approving to assign engineer
|
@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@stephanieelliott do you want to address the AI reviewer comments? |
Apply bot comments
|
thanks @mjasikowski, applied the relevant bot comments and dismissed the rest. |
|
🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.28-0 🚀
|
|
🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.30-0 🚀
|
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.3.30-3 🚀
|
Explanation of Change
Creates .MD files for humans and Melvin to reference as guidance when writing help articles.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/605102
PROPOSAL: N/A
Tests
Offline tests
QA Steps
N/A, no tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mp4
Android: mWeb Chrome
android.mweb.mp4
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
web.mp4