fix: Two expenses appears in report for user invuted to chat only#83659
fix: Two expenses appears in report for user invuted to chat only#83659Valforte merged 2 commits intoExpensify:mainfrom
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cc98910c83
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Good for product
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-03-02.at.4.25.13.PM.movAndroid: mWeb ChromeScreen.Recording.2026-03-02.at.4.23.36.PM.moviOS: HybridAppScreen.Recording.2026-03-02.at.4.25.35.PM.moviOS: mWeb SafariScreen.Recording.2026-03-02.at.4.26.03.PM.movMacOS: Chrome / SafariScreen.Recording.2026-03-02.at.4.21.21.PM.mov |
eh2077
left a comment
There was a problem hiding this comment.
works well! @nkdengineer Can you please also add unit tests to cover the change?
|
🚧 @Valforte has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/Valforte in version: 9.3.34-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.34-2 🚀
|
Explanation of Change
fix: Two expenses appears in report for user invuted to chat only
Fixed Issues
$ #83442
PROPOSAL: #83442 (comment)
Tests
Offline tests
QA Steps
Same as test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-02-27.at.14.49.38.mov
Android: mWeb Chrome
Screen.Recording.2026-02-27.at.14.48.51.mov
iOS: Native
Screen.Recording.2026-02-27.at.14.48.01.mov
iOS: mWeb Safari
Screen.Recording.2026-02-27.at.14.47.15.mov
MacOS: Chrome / Safari
Screen.Recording.2026-02-27.at.14.43.35.mov