Skip to content

Fix HEIC image processing context loss with proper error handling#83675

Draft
OlimpiaZurek wants to merge 2 commits intoExpensify:mainfrom
callstack-internal:fix/81702-heic-context-lost
Draft

Fix HEIC image processing context loss with proper error handling#83675
OlimpiaZurek wants to merge 2 commits intoExpensify:mainfrom
callstack-internal:fix/81702-heic-context-lost

Conversation

@OlimpiaZurek
Copy link
Contributor

@OlimpiaZurek OlimpiaZurek commented Feb 27, 2026

Details

Fixed HEIC image processing context loss issues by adding proper error handling and fallback processing. The changes add robust error handling to prevent crashes when HEIC conversion fails due to context loss, ensuring images can still be processed using fallback methods while providing appropriate logging for debugging.

Fixed Issues

$ #81702
PROPOSAL:

Tests

Offline tests

N/A

QA Steps

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I turned off my network connection and tested it while offline to ensure the app doesn't crash
    • I tested this PR with a High Traffic account against the staging or production API (mostly N/A)
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • Windows: Chrome
  • I verified there are no console errors (I did not introduce any new console errors)
  • I followed proper code patterns (see "Semantic naming" and "Memory usage" sections)
  • I verified that there are no duplicate components instead of reusing them
  • I verified that there is no commented out code
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent /> instead of myString && <MyComponent />
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments are clear, correct English, and explain why instead of what
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named in camelCase
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it is covered by tests (or N/A)
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (dropdown menus, menus and popups, text with inline links)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new page is added I verified it's using the ScrollView as the outermost component instead of the View (N/A)
  • If useEffect is used, I verified the dependency list is correct or the effect is only executed once (N/A)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory (N/A)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist (N/A)
    • The style can't be created with an existing StyleUtils function (N/A)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown (N/A)
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account (N/A)
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other (N/A)
    • I verified that all the visual changes look correct in all themes (default, dark, and classic), in Android, iOS, Web, mWeb
    • I verified that the UI renders on small / medium / large size screens without showing a horizontal scrollbar (N/A)
  • If a new page is added, I verified it's using the ScrollView as the outermost component instead of the View (N/A)
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps (N/A)

Screenshots/Videos

[No QA] - Internal error handling improvement only, no user-visible changes

🤖 Generated with Claude Code

Added eslint-disable comments for deprecated manipulateAsync API usage.
This is a pre-existing deprecation that should be addressed separately
from the HEIC context loss fix.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/components/AttachmentPicker/index.native.tsx 19.81% <0.00%> (-0.19%) ⬇️
src/libs/cropOrRotateImage/index.native.ts 10.00% <0.00%> (-2.50%) ⬇️
src/libs/cropOrRotateImage/index.ts 0.00% <0.00%> (ø)
... and 10 files with indirect coverage changes

@OlimpiaZurek OlimpiaZurek changed the title [No QA] Fix HEIC image processing context loss with proper error handling Fix HEIC image processing context loss with proper error handling Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant