[No QA] Add reasonAttributes to MergeExpensesSkeleton in MergeTransactionsListContent by sosek108 · Pull Request #83679 · Expensify/App

sosek108 · 2026-02-27T12:28:52Z

Explanation of Change

The MergeExpensesSkeleton component accepts a reasonAttributes prop for telemetry/tracing purposes, but the call site in MergeTransactionsListContent.tsx was not passing it. This change adds the missing reasonAttributes object using useMemo, providing context about which component is rendering the skeleton and whether the eligible transactions data has loaded. This ensures skeleton span tracing is correctly attributed when the merge expenses list is in a loading state.

Fixed Issues

$ #83405
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

codecov · 2026-02-27T12:36:39Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
.../TransactionMerge/MergeTransactionsListContent.tsx	`0.00% <0.00%> (ø)`
... and 10 files with indirect coverage changes

…tContent

melvin-bot · 2026-02-27T12:45:44Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 092bb11ddc

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-02-27T12:50:30Z

src/pages/TransactionMerge/MergeTransactionsListContent.tsx

+    const reasonAttributes: SkeletonSpanReasonAttributes = {
+        context: 'MergeTransactionsListContent',
+        isEligibleTransactionsLoaded: eligibleTransactions !== undefined,
+    };


Memoize reason attributes passed to skeleton

reasonAttributes is created as a new object on every render, and MergeExpensesSkeleton forwards it to useSkeletonSpan, whose update effect depends on reasonAttributes; while the loading placeholder is visible, any parent re-render (e.g., Onyx/network updates) will repeatedly call span.setAttributes/span.addEvent with identical data, creating noisy telemetry and avoidable work. Please memoize this object (as done in other call sites) so updates only happen when the loaded state actually changes.

Useful? React with 👍 / 👎.

This component is already using useMemo and useCallback so React compiler will skip this compoent. We can either:

add useMemo for this constant

Remove all usaged of useMemo and useCallback in this component.

I decided to Remove all usaged of useMemo and useCallback in this component.

hoangzinh · 2026-03-03T17:30:18Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-03-04.at.19.10.30.mov

Android: mWeb Chrome

Screen.Recording.2026-03-04.at.19.08.38.mov

iOS: HybridApp

Screen.Recording.2026-03-04.at.19.18.26.mov

iOS: mWeb Safari

Screen.Recording.2026-03-04.at.19.12.24.mov

MacOS: Chrome / Safari

Screen.Recording.2026-03-04.at.19.05.18.mov

hoangzinh · 2026-03-03T17:39:45Z

@sosek108, there is some lag on the merge transaction list page

Screen.Recording.2026-03-04.at.00.38.25.mov

…leton

sosek108 · 2026-03-04T09:00:16Z

@hoangzinh I did merge main to the branch. Can you check this again? I see nothing that could lead to this kind of lag. And on my machine it works well

Component is properly memoized by React Compiler

hoangzinh · 2026-03-04T12:06:34Z

It works well for me. Hmm, it seems I need to reset npm run

hoangzinh

LGTM 🚢

youssef-lr · 2026-03-05T02:43:42Z

We have conflicts

…leton

sosek108 · 2026-03-05T09:29:48Z

Conflicts resolved

github-actions · 2026-03-05T09:33:00Z

🚧 @youssef-lr has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-05T09:37:52Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83679.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-375ad05-a1e5d7f-03d6ee73093e1be2d0113da75608833ab6220e1e/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-375ad05-a1e5d7f-565e6abbafe7102ba036c3d3a04325945964166d/index.html

Web 🕸️
https://83679.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-05T09:39:39Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-03-06T04:15:06Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.3.32-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-06T22:44:19Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.32-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot bot assigned sosek108 Feb 27, 2026

Add reasonAttributes to MergeExpensesSkeleton in MergeTransactionsLis…

092bb11

…tContent

sosek108 force-pushed the fix/add-reasonAttributes-to-MergeExpensesSkeleton branch from e02293d to 092bb11 Compare February 27, 2026 12:40

sosek108 marked this pull request as ready for review February 27, 2026 12:45

sosek108 requested review from a team as code owners February 27, 2026 12:45

melvin-bot bot requested review from hoangzinh and removed request for a team February 27, 2026 12:45

melvin-bot bot requested review from heyjennahay and removed request for a team February 27, 2026 12:45

chatgpt-codex-connector bot reviewed Feb 27, 2026

View reviewed changes

sosek108 mentioned this pull request Feb 27, 2026

Add reasonAttributes to MergeExpensesSkeleton usage sites #83405

Closed

sosek108 added 2 commits March 3, 2026 10:32

remove useMemo/useCallback to re-enable React Compiler

4a3e717

prettier

bbaa0a1

sosek108 added 2 commits March 4, 2026 09:27

Merge branch 'main' into fix/add-reasonAttributes-to-MergeExpensesSke…

6dca2b3

…leton

clean merge

d0d45cb

hoangzinh approved these changes Mar 4, 2026

View reviewed changes

melvin-bot bot requested a review from youssef-lr March 4, 2026 12:19

youssef-lr previously approved these changes Mar 5, 2026

View reviewed changes

Merge branch 'main' into fix/add-reasonAttributes-to-MergeExpensesSke…

dbcecfb

…leton

sosek108 dismissed youssef-lr’s stale review via dbcecfb March 5, 2026 08:14

youssef-lr approved these changes Mar 5, 2026

View reviewed changes

youssef-lr merged commit 375ad05 into Expensify:main Mar 5, 2026
30 checks passed

OSBotify mentioned this pull request Mar 6, 2026

Deploy Checklist: New Expensify 2026-03-06 #84352

Closed

92 tasks

hoangzinh mentioned this pull request Mar 24, 2026

[Due for payment 2026-03-24] Add reasonAttributes to ActivityIndicator usage sites #83394

Open

Conversation

sosek108 commented Feb 27, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Feb 27, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Feb 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

hoangzinh Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

sosek108 Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

hoangzinh commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

hoangzinh commented Mar 3, 2026

Uh oh!

sosek108 commented Mar 4, 2026

Uh oh!

hoangzinh commented Mar 4, 2026

Uh oh!

hoangzinh left a comment

Choose a reason for hiding this comment

Uh oh!

youssef-lr commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sosek108 commented Mar 5, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

OSBotify commented Mar 5, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Feb 27, 2026 •

edited by github-actions bot

Loading

hoangzinh commented Mar 3, 2026 •

edited

Loading

youssef-lr commented Mar 5, 2026 •

edited

Loading