-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Add tooltip on hover of labels #83704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
puneetlath
merged 37 commits into
Expensify:main
from
software-mansion-labs:add-tooltip-for-labels
Mar 12, 2026
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
f0d8e81
add tooltip on hover of labels, add debounce on hover start
borys3kk ad89eec
fix hover when entering the label from the left
borys3kk 61502d7
merge main
borys3kk 0350a55
add tooltip on label hover in pie chart
borys3kk fbec98d
adjust label bounding box positioning
borys3kk 7ab38fb
start implementing hover on label in bar chart
borys3kk 234fc99
merge main
borys3kk 3bdff09
fix hovering for line chart labels
borys3kk 50748fe
Merge branch 'main' of github.com:Expensify/App into add-tooltip-for-…
borys3kk 4bbc98b
add hover for barChart
borys3kk 57c6707
fix prettier
borys3kk a9fcd5f
fix check for vertical labels in bar chart
borys3kk d0f65ff
fix tests typecheck, fix prettier
borys3kk 5729b2e
fix bounding boxes for line and bar chart, memoize whats possible
borys3kk 021808f
add tests for new function
borys3kk f21d491
make bar and line charts use the new function
borys3kk bc68d1d
remove manual memoization in lineChartContent
borys3kk a937fe6
remove manual memoization from bar chart
borys3kk f06e95a
add utils for label hit testins/ refactor and simplify code
borys3kk 8d8a70a
add tests for common function in label hover
borys3kk 4002dbb
fix prettier
borys3kk 1187bf8
remove argument unpacking
borys3kk af9691c
remerge main
borys3kk ba84519
fix error on native devices
borys3kk 8b43d2f
move redundant code to hook
borys3kk a051d7e
fix prettier
borys3kk 79c5642
add review suggestins
borys3kk c32aa1c
fix tapping on mobile devices, make hovering more accuratee
borys3kk a443442
fix error on mobile about worklets
borys3kk 9bb1932
fix spellcheck
borys3kk e955550
update tests
borys3kk ae6aed5
fix spelling
borys3kk 9ba69f5
fix missing spaces in useChartInteractions
borys3kk 29ca3fc
fix missing spaces
borys3kk 39ecf08
add comments
borys3kk be86d9c
fxi puneets review comments
borys3kk 8913c7f
fix prettier
borys3kk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.