[CP Stag] Revert "Migration navigation from InteractionManager to TransitionTracker"#83763
Merged
roryabraham merged 1 commit intomainfrom Feb 27, 2026
Merged
Conversation
melvin-bot
bot
requested review from
luacmartins and
trjExpensify
and removed request for
a team
|
@luacmartins Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
thienlnam
changed the title
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
roryabraham
approved these changes
Feb 27, 2026
Contributor
|
not waiting for reassure for a straight revert |
Contributor
|
🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
OSBotify
pushed a commit
that referenced
this pull request
Feb 27, 2026
…action-manager [CP Stag] Revert "Migration navigation from InteractionManager to TransitionTracker" (cherry picked from commit 4b02fcc) (cherry-picked to staging by roryabraham)
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7f4df0102c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+724
to
+726
| const subscription = DeviceEventEmitter.addListener(CONST.MODAL_EVENTS.CLOSED, () => { | ||
| subscription.remove(); | ||
| callback(); |
There was a problem hiding this comment.
dismissModal() now runs its callback from a global modalClosed event, but that event is emitted by every BaseModal unmount (src/components/Modal/BaseModal.tsx:170) and also by RightModalNavigator unmount (src/libs/Navigation/AppNavigator/Navigators/RightModalNavigator.tsx:172). In flows that pass a callback (e.g., report/new-chat navigation), an unrelated modal closing first will invoke the callback early, so navigation can happen before the intended modal has actually finished closing.
Useful? React with 👍 / 👎.
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.3.27-1 🚀
|
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
7 tasks
Contributor
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.3.27-8 🚀
|
Contributor
|
🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.3.28-0 🚀
|
Contributor
|
🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.3.30-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.3.30-3 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #82587
Deploy Blockers caused by #82587
Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.