Fix #83751: prevent overwriting active transaction IDs on referential re-renders by mountiny · Pull Request #83772 · Expensify/App

mountiny · 2026-02-27T22:56:00Z

Explanation of Change

Fixes a regression from #83432 where navigating from "Review Duplicates" to SEARCH_REPORT caused wrong prev/next arrow state on first open.

Root cause: After removing useDeepCompareRef, the effect in MoneyRequestReportTransactionList used visualOrderTransactionIDs directly as its dependency. When navigating to SEARCH_REPORT, Onyx data loads triggered useMemo recomputation, producing a new array reference with the same (or slightly different) content. This caused the effect to re-fire and overwrite the transaction IDs set by TransactionDuplicateReview.onPreviewPressed, placing the clicked transaction at the wrong position in the list.

Fix: Use a join(',') primitive string key as the effect dependency. The effect only re-fires when the array content actually changes, matching the original useDeepCompareRef behavior without the deep-equal overhead or React Compiler incompatibility. The idempotent guard in setActiveTransactionIDs stays as a defense-in-depth layer.

Fixed Issues

$ #83751

Tests

Open a workspace chat with expense reports containing duplicate transactions (two expenses with the same amount)
Open the report and click "Review duplicates"
Click on the second expense preview → verify the left arrow is enabled and the right arrow is disabled (since it's the last transaction)
Close the report RHP
Click on the second expense preview again → verify the arrows are the same as step 3
Verify no JS console errors

Offline tests

Go offline
Open a report with transactions from Search
Verify the transaction list still renders correctly
Go back online and verify no duplicate or stale transaction IDs appear

QA Steps

Open the app and navigate to a workspace with duplicate expenses
Open the report and click "Review duplicates"
Click on the second expense preview — verify prev/next arrows are correct (left enabled, right disabled)
Close the RHP and click the same expense again — verify arrows are identical to step 3
Navigate to Search, open a report, click through transactions with prev/next — verify order is stable
Verify no JS console errors

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…-renders The split effects allowed the set-effect to fire on referential-only changes of visualOrderTransactionIDs. When navigating from Review Duplicates to SEARCH_REPORT, this overwrote the IDs set by onPreviewPressed, causing wrong prev/next arrow state on first open. Replace with a combined effect using a join(',') primitive key as the dependency. The effect only re-fires when the array content actually changes, matching the original useDeepCompareRef behavior without the deep-equal overhead or React Compiler incompatibility. Made-with: Cursor

melvin-bot · 2026-02-27T22:56:06Z

@ChavdaSachin Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Made-with: Cursor

codecov · 2026-02-27T23:22:32Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...stReportView/MoneyRequestReportTransactionList.tsx	`1.32% <0.00%> (ø)`
... and 302 files with indirect coverage changes

ChavdaSachin · 2026-03-04T15:07:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-03-04.at.8.28.54.PM.mov

Android: mWeb Chrome

Screen.Recording.2026-03-04.at.8.34.17.PM.mov

iOS: HybridApp

Screen.Recording.2026-03-04.at.7.52.42.PM.mov

iOS: mWeb Safari

Screen.Recording.2026-03-04.at.7.57.17.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2026-03-04.at.7.07.31.PM.mov

ChavdaSachin

LGTM ✅

melvin-bot · 2026-03-04T15:10:32Z

@Gonals Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-03-05T13:34:45Z

🚧 @Gonals has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-03-05T13:38:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-03-05T13:39:15Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83772.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-6f567df-18d2287-e648523f04e5106217dae3b5cf5c74d08a223e9e/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-6f567df-18d2287-5eaa4bf14ee6d54997288fd2457eb78c4d7ba3bb/index.html

Web 🕸️
https://83772.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-06T04:15:15Z

🚀 Deployed to staging by https://github.com/Gonals in version: 9.3.32-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-06T22:44:28Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.32-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

mountiny requested review from a team as code owners February 27, 2026 22:56

melvin-bot bot assigned mountiny Feb 27, 2026

melvin-bot bot requested review from ChavdaSachin and removed request for a team February 27, 2026 22:56

melvin-bot bot requested review from heyjennahay and removed request for a team February 27, 2026 22:56

This was referenced Feb 27, 2026

[$250] Expense - Different report sequence when duplicate expense is opened for 1st and 2nd time #83751

Open

Fix duplicate expense navigation arrows showing inverted state on first open #83753

Closed

Add explanatory comment for visualOrderTransactionIDsKey

bd042c8

Made-with: Cursor

ChavdaSachin approved these changes Mar 4, 2026

View reviewed changes

melvin-bot bot requested a review from Gonals March 4, 2026 15:10

Gonals approved these changes Mar 4, 2026

View reviewed changes

Gonals merged commit 6f567df into main Mar 5, 2026
35 of 36 checks passed

Gonals deleted the vit-removeDeepCompareRef-transactionList branch March 5, 2026 13:28

OSBotify mentioned this pull request Mar 6, 2026

Deploy Checklist: New Expensify 2026-03-06 #84352

Closed

92 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #83751: prevent overwriting active transaction IDs on referential re-renders#83772

Fix #83751: prevent overwriting active transaction IDs on referential re-renders#83772
Gonals merged 2 commits intomainfrom
vit-removeDeepCompareRef-transactionList

mountiny commented Feb 27, 2026 •

edited

Loading

Uh oh!

melvin-bot bot commented Feb 27, 2026

Uh oh!

codecov bot commented Feb 27, 2026 •

edited by github-actions bot

Loading

Uh oh!

ChavdaSachin commented Mar 4, 2026 •

edited

Loading

Uh oh!

ChavdaSachin left a comment

Uh oh!

melvin-bot bot commented Mar 4, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

OSBotify commented Mar 5, 2026

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

mountiny commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 27, 2026

Uh oh!

codecov bot commented Feb 27, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ChavdaSachin commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ChavdaSachin left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Mar 4, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

OSBotify commented Mar 5, 2026

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mountiny commented Feb 27, 2026 •

edited

Loading

codecov bot commented Feb 27, 2026 •

edited by github-actions bot

Loading

ChavdaSachin commented Mar 4, 2026 •

edited

Loading