Fix: Android crash std::__ndk1::default_delete<T>::operator() [abi:ne180000]#83792
Fix: Android crash std::__ndk1::default_delete<T>::operator() [abi:ne180000]#83792rlinoz merged 3 commits intoExpensify:mainfrom
Conversation
|
|
|
@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0e55de3d7a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
...tive-worklets/react-native-worklets+0.7.2+001+fix-app-crash-SerializableRemoteFunction.patch
Show resolved
Hide resolved
|
bump @sobitneupane on reviewing this one |
|
Sorry for the delay @rlinoz I won't be able to review the PR for the next few days. Could you please reassign it to someone else? |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-03-11.at.9.59.58.PM.movAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
@rlinoz Could you generate an ad hoc build? I think it's better to test this on an ad hoc build. |
|
🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
eh2077
left a comment
There was a problem hiding this comment.
Tested well on Android App for ad-hoc build.
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #82146 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
|
@rlinoz I believe this is your review |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.3.37-0 🚀
|
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.37-10 🚀
|
Explanation of Change
This PR applies a patch to fix the issue
std::__ndk1::default_delete<T>::operator() [abi:ne180000].Thanks to @tjzel for the help creating the patch.
Fixed Issues
$ #82146
PROPOSAL: N/A
Tests
Test 1:
Test 2:
Offline tests
Same as test above
QA Steps
Same as test above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-02-28.at.18.48.32.mov
Android: mWeb Chrome
Screen.Recording.2026-02-28.at.18.54.26.mov
iOS: Native
Screen.Recording.2026-02-28.at.19.16.08.mov
iOS: mWeb Safari
Screen.Recording.2026-02-28.at.17.58.52.mov
MacOS: Chrome / Safari
Screen.Recording.2026-02-28.at.17.56.26.mov