Conversation
|
|
|
This one surely looks like the PR I was working on back then - #72248 I can help as C+ here if needed. |
|
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
melvin-bot
bot
requested review from
dukenv0307 and
heyjennahay
and removed request for
a team
|
Triggered a fresh build for @Expensify/design |
|
🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
src/components/MultifactorAuthentication/config/scenarios/index.ts
Outdated
Show resolved
Hide resolved
| disabled={!!isDisabled} | ||
| style={styles.ml3} | ||
| containerStyle={styles.m0} | ||
| focusable={false} |
There was a problem hiding this comment.
is this not a default false param? Do you know why?
| accessibilityLabel={accessibilityLabel} | ||
| pressDimmingValue={1} | ||
| wrapperStyle={wrapperStyle} | ||
| focusable={focusable} |
There was a problem hiding this comment.
@zfurtak why would we ever want this to be false? I see we used false for this PR, could you help me understand?
| isChecked && styles.checkedContainer, | ||
| isChecked && styles.borderColorFocus, | ||
| ]} | ||
| isNested |
There was a problem hiding this comment.
This applies to all RadioButtons, what does this change do?
| function renderOption(item: OnboardingListItem) { | ||
| return ( |
There was a problem hiding this comment.
is it intentional to remove this useCallback?
There was a problem hiding this comment.
Good point, after checking, React Complier will skip this file
There was a problem hiding this comment.
I checked it by React Compiler Marker and it says that this file will be compiled by React Compiler so I just removed it as a code cleanup
There was a problem hiding this comment.
@zfurtak I run npm run react-compiler-compliance-check check src/pages/OnboardingAccounting/BaseOnboardingAccounting.ts, the I see:
- Checking
src/pages/OnboardingAccounting/BaseOnboardingAccounting.tsx:182:39
React Compiler has skipped optimizing this component because the existing manual memoization could not be preserved. The inferred dependencies did not match the manually specified dependencies, which could cause the value to change more or less frequently than expected
Oh, it seems like React Complier skips handleContinue, not renderOption, so I think that's fine to remove useCallback here
grgia
left a comment
grgia
left a comment
There was a problem hiding this comment.
this PR is HUGE so I've left some initial questions to start. It might be helpful to add an overview of the design decisions you made in the PR description or as comments in the code for reviewers.
thank you for taking this on!
|
Can't focus on the item when using the down/up key Screen.Recording.2026-03-24.at.09.29.01.mov |
|
@zfurtak what happened to tests here? |
Working on it 👍 |
|
After merging main with the previous PR, this one became much more reviewer friendly 😊 |
Some git problems, fixed now! |
|
Thank you @zfurtak! Lemme know when you're good for a fresh review ❤️ |
7 participants
Explanation of Change
In the PR I:
The idea is to enhanced consistency among lists with selection.
Important
This PR requires #84880 to be merged first
Fixed Issues
$ #74938
PROPOSAL:
Tests
same as qa tests
Offline tests
QA Steps
Single selection list
For each of the following pages verify:
Reports
Workspace
Overview
Members
Reports
Accounting - QBO
-Accounting - QBD
import > classes > displayed as
import > customers/projects > displayed as
export > preferred exporter
export > export date
export > export out-of-pocket expenses as > export as
export > export out-of-pocket expense as > account
export > export invoices to
export > export company card expenses as > export as
export > export company card expenses as > credit card account
Accounting - Xero
Accounting - NetSuite
Accounting - Sage Intacct
Categories
Tags
tag > approver
Taxes
Workflows
Rules
Distance rates
Expensify cards
Company cards
Per diem
Account
Profile
Subscription
Wallet
Expense rules
Preferences
Security
FAB
Create expense
Create report > choose workspace
Start chat
Chat
-Tracked expense
submit to someone > choose recipient
Workspace expense
create task > assignee
task > assignee
room chat
Onboarding
Multi selection
For each of the following pages verify:
Reports
Filters > type = expense
Filters > type = chat
Filters > type = task
Workspace
Overview
Members
Workflows
FAB
Onboarding
New chat item
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari