Fix card widget title clipping on Android 16#83807
Conversation
Remove redundant flexRow and alignItemsCenter styles from WidgetContainer title wrapper. On Android 16, flexDirection: 'row' with wrap-content text causes the title to be clipped at word boundaries. Since the View only contains a single Text child, these styles are unnecessary. Made-with: Cursor
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
This should be fixed #83791 (comment) |
|
@MelvinBot can you sync up this PR with main please? |
…ner-title-clipping Co-authored-by: Vit Horacek <mountiny@users.noreply.github.com>
|
Merged |
|
@MelvinBot can you merge main again? the typescript should be fixed on main |
…ner-title-clipping Co-authored-by: Vit Horacek <mountiny@users.noreply.github.com>
|
Merged |
|
@brunovjk can you please make sure to test on all the platforms? thanks |
|
@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
trjExpensify
left a comment
There was a problem hiding this comment.
Straightforward bug 👍
|
Asked about the review in Slakc https://expensify.slack.com/archives/C02NK2DQWUX/p1772663037384719 |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp83807_android_native.movAndroid: mWeb Chrome83807_android_web.moviOS: HybridApp83807_ios_native.moviOS: mWeb Safari83807_ios_web.movMacOS: Chrome / Safari83807_web_chrome.mov |
|
🚧 @lakchote has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/lakchote in version: 9.3.32-0 🚀
|
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.3.32-3 🚀
|
Explanation of Change
On Android 16, the card widget section title "Tus tarjetas Expensify" (Spanish) is truncated to "Tus tarjetas" on narrow devices. This is an Android 16 rendering limitation where text gets clipped when a parent View has
flexDirection: 'row'and text width is wrap-content.The fix removes the redundant
styles.flexRowandstyles.alignItemsCenterfrom theWidgetContainertitle wrapper View. Since this View only contains a singleTextchild, these styles are unnecessary and removing them allows the text to take the full available width, preventing clipping.Fixed Issues
$ #83791
PROPOSAL: #83791 (comment)
Tests
Offline tests
N/A - This is a styling fix that does not affect network behavior.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari