[No QA] Fix flaky date preset tests in SearchUIUtilsTest by MelvinBot · Pull Request #83809 · Expensify/App

MelvinBot · 2026-03-01T21:59:45Z

Explanation of Change

Two tests in SearchUIUtilsTest.ts (should intersect date preset with additional constraints instead of overwriting and should intersect date preset end limit with additional constraints) use CONST.SEARCH.DATE_PRESETS.LAST_MONTH which resolves relative to the real system clock via getDateRangeForPreset(). The expected values were hardcoded assuming "last month" = January 2026, which was only true when tests ran in February 2026. On any other month, the tests fail.

This PR wraps the two flaky tests in a describe block with jest.useFakeTimers() / jest.setSystemTime() to freeze the clock to February 2026, making LAST_MONTH always resolve to January 2026. This follows the same pattern used in 10+ other test files in this repo.

Fixed Issues

$ #83808
PROPOSAL: #83808 (comment)

Tests

Run npm test -- tests/unit/Search/SearchUIUtilsTest.ts --no-coverage
Verify all 212 tests pass, including the two date preset intersection tests
Verify no console errors related to the change

Verify that no errors appear in the JS console

Offline tests

N/A — this is a test-only change with no runtime behavior.

QA Steps

[No QA]

This is a test-only fix (no production code changes). The flaky tests now pass deterministically regardless of what month CI runs.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

N/A — test-only change

Android: mWeb Chrome

N/A — test-only change

iOS: Native

N/A — test-only change

iOS: mWeb Safari

N/A — test-only change

MacOS: Chrome / Safari

N/A — test-only change

The two date preset intersection tests used LAST_MONTH preset which resolves relative to the real system clock via getDateRangeForPreset(). The hardcoded expected dates assumed LAST_MONTH = January 2026, which was only true when run in February 2026. Freeze the clock with jest.useFakeTimers/setSystemTime to make these tests deterministic. Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>

MelvinBot · 2026-03-01T21:59:55Z

I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-fixFlakyDatePresetTests
git checkout -b claude-fixFlakyDatePresetTests upstream/claude-fixFlakyDatePresetTests
git push -u origin claude-fixFlakyDatePresetTests

Then you can close this PR and open a new one from your fork.

Krishna2323 · 2026-03-01T22:15:56Z

@MelvinBot move it out of draft state

melvin-bot · 2026-03-01T22:17:16Z

@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MelvinBot · 2026-03-01T22:17:19Z

PR has been marked as ready for review.

Krishna2323 · 2026-03-01T22:20:08Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Krishna2323

LGTM! 🎉

The fix is minimal, correct, follows established repo patterns, and no other files are at risk.

rafecolton

LGTM 👍

mountiny

LGTM

OSBotify · 2026-03-02T23:05:32Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.28-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-04T03:20:24Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.30-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-04T18:10:23Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.30-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot assigned Krishna2323 Mar 1, 2026

MelvinBot requested a review from a team March 1, 2026 21:59

MelvinBot mentioned this pull request Mar 1, 2026

[Due for payment 2026-03-11] [$125] Investigate workflow job failing on main: test / test (job 1) #83808

Closed

MelvinBot marked this pull request as ready for review March 1, 2026 22:17

melvin-bot bot requested a review from Krishna2323 March 1, 2026 22:17

melvin-bot bot removed the request for review from a team March 1, 2026 22:17

Krishna2323 approved these changes Mar 1, 2026

View reviewed changes

melvin-bot bot requested a review from mountiny March 1, 2026 22:23

rafecolton approved these changes Mar 1, 2026

View reviewed changes

mountiny approved these changes Mar 1, 2026

View reviewed changes

mountiny merged commit 0ded9f6 into main Mar 1, 2026
31 checks passed

mountiny deleted the claude-fixFlakyDatePresetTests branch March 1, 2026 22:45

rafecolton mentioned this pull request Mar 1, 2026

Fix time based group expansion in Reports/Search #81418

Merged

53 tasks

francoisl mentioned this pull request Mar 2, 2026

fix: payments is enabled when workspace is created offline #82981

Merged

53 tasks

OSBotify mentioned this pull request Mar 2, 2026

Deploy Checklist: New Expensify 2026-03-02 #83947

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[No QA] Fix flaky date preset tests in SearchUIUtilsTest#83809

[No QA] Fix flaky date preset tests in SearchUIUtilsTest#83809
mountiny merged 1 commit intomainfrom
claude-fixFlakyDatePresetTests

MelvinBot commented Mar 1, 2026

Uh oh!

MelvinBot commented Mar 1, 2026

Uh oh!

Krishna2323 commented Mar 1, 2026

Uh oh!

melvin-bot bot commented Mar 1, 2026

Uh oh!

MelvinBot commented Mar 1, 2026

Uh oh!

Krishna2323 commented Mar 1, 2026

Uh oh!

Krishna2323 left a comment

Uh oh!

rafecolton left a comment

Uh oh!

mountiny left a comment

Uh oh!

Uh oh!

OSBotify commented Mar 2, 2026

Uh oh!

OSBotify commented Mar 4, 2026

Uh oh!

OSBotify commented Mar 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

MelvinBot commented Mar 1, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Mar 1, 2026

Uh oh!

Krishna2323 commented Mar 1, 2026

Uh oh!

melvin-bot bot commented Mar 1, 2026

Uh oh!

MelvinBot commented Mar 1, 2026

Uh oh!

Krishna2323 commented Mar 1, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Krishna2323 left a comment

Choose a reason for hiding this comment

Uh oh!

rafecolton left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Mar 2, 2026

Uh oh!

OSBotify commented Mar 4, 2026

Uh oh!

OSBotify commented Mar 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants