refactor getWelcomeMessage to use conciergeReportID from useOnyx#83813
Merged
rlinoz merged 7 commits intoExpensify:mainfrom Mar 11, 2026
Merged
refactor getWelcomeMessage to use conciergeReportID from useOnyx#83813rlinoz merged 7 commits intoExpensify:mainfrom
rlinoz merged 7 commits intoExpensify:mainfrom
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
melvin-bot
bot
requested review from
JmillsExpensify
and removed request for
a team
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| localeCompare, | ||
| conciergeReportID, | ||
| isReportArchived, | ||
| // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing |
Contributor
There was a problem hiding this comment.
❌ CONSISTENCY-5 (docs)
The eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing comment lacks a justification explaining why the rule is being disabled. While this comment existed before the PR (and also lacked justification), since it was moved to a new position it should be given a proper explanation.
Add a comment explaining why || is used instead of ?? here. For example:
isReportArchived,
// We use || instead of ?? because we want to fall back when messageText is an empty string, not just null/undefined
// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
}).messageText || translate('report.noActivityYet'),Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
Contributor
Author
There was a problem hiding this comment.
I didn't change it
Contributor
JmillsExpensify
left a comment
JmillsExpensify
left a comment
There was a problem hiding this comment.
No product review required.
Contributor
Author
|
@DylanDylann kindly bump |
Contributor
Author
|
@DylanDylann bump |
Contributor
|
Please merge new main to remove the duplicated code change |
Contributor
Author
|
@DylanDylann it's fine now |
Contributor
Reviewer Checklist
Screenshots/Videos
|
Contributor
Author
|
@DylanDylann you forgot to approve |
DylanDylann
approved these changes
Mar 10, 2026
Contributor
|
cc @tgolen For review |
Contributor
|
@dukenv0307 Could you merge new main? |
52 tasks
rlinoz
approved these changes
Mar 10, 2026
Contributor
|
@dukenv0307 we got a failed test |
Contributor
Author
|
@DylanDylann, I've merged main and it's fixed |
Contributor
|
cc @rlinoz For final review |
Contributor
|
🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Contributor
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.3.36-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.36-10 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #66411
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-03-02.at.10.54.55.mov