Fix bulk merge post-merge navigation to open target thread report#83825
Open
marufsharifi wants to merge 7 commits intoExpensify:mainfrom
Open
Fix bulk merge post-merge navigation to open target thread report#83825marufsharifi wants to merge 7 commits intoExpensify:mainfrom
marufsharifi wants to merge 7 commits intoExpensify:mainfrom
Conversation
Contributor
Author
|
PR changes:
|
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Contributor
Author
|
@rojiphil, thanks for your patience the pr is ready for your review. The failure unit test doesn't seem related to my changes, btw. thanks. |
Contributor
Author
|
@rojiphil, kindly bump. thanks. |
Contributor
|
@marufsharifi There are two issues which needs fix:
Attaching staging and pr version test videos for reference. 83825-pr-issues.mp483825-staging-issues.mp4 |
Contributor
Author
|
Sorry for the delay, I will try to update this tomorrow. |
7 tasks
Contributor
Author
|
Sorry for the delay i was OOO, i will update here today. Thanks. |
Contributor
Author
|
I've fixed the case where we select more than one expense from bulk actions, then merge. But for one expense selected from bulk action, it sometimes doesn't work. I will update here tomorrow. Thanks for your patience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Bulk expense merge now follows the same destination behavior as individual merge.
Before this update, bulk merge from
Reports > Expensescould open the wrong place (for example, self-DM) after merge because the app sometimes lost the intended transaction-thread destination during the multi-step merge flow.Now, the app determines the correct target transaction thread earlier in the merge process and carries that destination through to confirmation. That makes post-merge navigation consistent and predictable across flows, especially when merging workspace and
self-DMexpenses from search.follow-up of #79766
Fixed Issues
$ #83257
PROPOSAL:
Tests
Create an expense in self DM.
Create an expense in workspace chat.
Go to Reports > Expenses.
Select the workspace expense via the checkbox.
Click the dropdown button > Merge.
Select self DM expense > Continue.
Select the second option in each section > Next > Merge expenses.
Verify the transaction thread is open after merging expenses via the bulk option
Offline tests
Same as Tests.
QA Steps
Same as Tests.
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.native.mp4
Android: mWeb Chrome
android.web.mp4
iOS: Native
Screen.Recording.2026-03-06.at.5.49.31.PM.mov
iOS: mWeb Safari
Screen.Recording.2026-03-06.at.5.52.45.PM.mov
MacOS: Chrome / Safari
web.mp4