Perf: skip reportAttributes full recompute on initial locale load by sosek108 · Pull Request #83828 · Expensify/App

sosek108 · 2026-03-02T10:19:51Z

Explanation of Change

On cold start, reportAttributes was performing a full recompute over all reports when the preferred locale key first arrived from Onyx. This was unnecessary because:

Initialize isFullyComputed = true so startup defaults to incremental update mode
Add previousLocale guard: only reset isFullyComputed = false on locale changes when a previous locale was already set (!!previousLocale). The very first locale load is skipped
Guard previousLocale assignment to only update when preferredLocale is truthy, preventing a null value from masking a subsequent real locale change

Fixed Issues

$ #83043
PROPOSAL:

Tests

Cold start the app and verify LHN loads correctly with proper report names in the user's locale
Change locale in settings and verify all report names update correctly (full recompute still fires via !!previousLocale guard)
Verify no regression on first-time login (no previous locale set)

Offline tests

N/A

QA Steps

Prerequisites: have two different account where you can easily check if report's names are correct.

Log in as first user
Check inbox and report names.
Go to settings and change language
Check report names again
Log out and log in as different user
Verify if presented reports are only from second user's account

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Nagranie.z.ekranu.2026-03-6.o.09.12.07.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Nagranie.z.ekranu.2026-03-6.o.09.10.05.mov

adhorodyski · 2026-03-02T10:42:18Z

src/libs/actions/OnyxDerived/configs/reportAttributes.ts

 import type {PersonalDetailsList, ReportAttributesDerivedValue} from '@src/types/onyx';

-let isFullyComputed = false;
+let isFullyComputed = true;


this should be documented with a comment

added comment, as requested

codecov · 2026-03-02T11:47:28Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...bs/actions/OnyxDerived/configs/reportAttributes.ts	`96.63% <100.00%> (-0.09%)`	⬇️
... and 10 files with indirect coverage changes

…tial-locale

sosek108 · 2026-03-09T10:06:32Z

Performance

Before

After

melvin-bot · 2026-03-11T10:07:33Z

@brunovjk Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

joekaufmanexpensify · 2026-03-11T19:08:37Z

No product review needed

brunovjk · 2026-03-12T13:41:08Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

83828_android_native.mov

Android: mWeb Chrome

iOS: HybridApp

83828_ios_native.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

83828_web_chrome.mov

brunovjk · 2026-03-16T13:03:23Z

Sorry for the delay. @sosek108, when I reload the app (iOS Native) for a second, the translations don't seem to load:

Screen.Recording.2026-03-16.at.09.54.25.mov

In the main menu it seems ok:

Screen.Recording.2026-03-16.at.09.56.52.mov

Can you reproduce it? Thank you.

…tial-locale

sosek108 · 2026-03-16T14:43:44Z

@brunovjk Hi, I can reproduce this on both main and my branch.

I think that on production this is hidden by loading splash screen which is not visible on dev

brunovjk · 2026-03-16T15:50:41Z

@brunovjk Hi, I can reproduce this on both main and my branch.

I think that on production this is hidden by loading splash screen which is not visible on dev

Thank for clarifying. I will check now, bit I think is everything ok than

…tial-locale

NikkiWines

…tial-locale

sosek108 · 2026-03-18T08:55:07Z

I've fixed CI checks problems.

github-actions · 2026-03-18T16:12:36Z

🚧 @NikkiWines has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-03-18T16:12:41Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-03-18T16:18:55Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83828.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-8d7ae70-e8d9bf4-2cba843e1fd9483edd0b6f4395a63097e86ec863/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-8d7ae70-e8d9bf4-09d1a8f36c1e339a044c667b758c807763b1b261/index.html

Web 🕸️
https://83828.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-19T20:23:54Z

🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.3.41-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-03-23T09:25:45Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.41-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

skip reportAttributes full recompute on initial locale load

2429136

melvin-bot bot assigned sosek108 Mar 2, 2026

adhorodyski reviewed Mar 2, 2026

View reviewed changes

simplify locale change detection using currentValue?.locale

a8e4e6d

sosek108 added 3 commits March 6, 2026 08:57

Merge branch 'main' into perf/skip-report-attributes-recompute-on-ini…

95a0cb5

…tial-locale

replace isFullyComputed flag with currentValue-based incremental check

18f99e0

Merge branch 'main' into perf/skip-report-attributes-recompute-on-ini…

3333593

…tial-locale

sosek108 marked this pull request as ready for review March 11, 2026 10:07

sosek108 requested review from a team as code owners March 11, 2026 10:07

melvin-bot bot requested review from brunovjk and removed request for a team March 11, 2026 10:07

melvin-bot bot requested review from joekaufmanexpensify and removed request for a team March 11, 2026 10:07

joekaufmanexpensify removed their request for review March 11, 2026 19:08

Merge branch 'main' into perf/skip-report-attributes-recompute-on-ini…

dfb94d6

…tial-locale

brunovjk approved these changes Mar 17, 2026

View reviewed changes

melvin-bot bot requested a review from NikkiWines March 17, 2026 14:22

Merge branch 'main' into perf/skip-report-attributes-recompute-on-ini…

3dc085f

…tial-locale

NikkiWines previously approved these changes Mar 18, 2026

View reviewed changes

sosek108 added 2 commits March 18, 2026 09:26

Merge branch 'main' into perf/skip-report-attributes-recompute-on-ini…

dae2cdd

…tial-locale

fix merge conflict

e03c025

sosek108 dismissed NikkiWines’s stale review via e03c025 March 18, 2026 08:43

NikkiWines approved these changes Mar 18, 2026

View reviewed changes

NikkiWines merged commit 8d7ae70 into Expensify:main Mar 18, 2026
32 checks passed

MelvinBot mentioned this pull request Mar 19, 2026

[$250] Chat - Green dot for inbox not display when message in group come. #85779

Open

7 tasks

OSBotify mentioned this pull request Mar 19, 2026

Deploy Checklist: New Expensify 2026-03-19 #85862

Closed

melvin-bot bot mentioned this pull request Mar 23, 2026

[Due for payment 2026-03-30] [Due for payment 2026-03-13] Investigate slow app cold start (11s to reach Settings page) #83043

Open

Conversation

sosek108 commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

adhorodyski Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

sosek108 Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Mar 2, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sosek108 commented Mar 9, 2026

Performance

Uh oh!

melvin-bot bot commented Mar 11, 2026

Uh oh!

joekaufmanexpensify commented Mar 11, 2026

Uh oh!

brunovjk commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

brunovjk commented Mar 16, 2026

Uh oh!

sosek108 commented Mar 16, 2026

Uh oh!

brunovjk commented Mar 16, 2026

Uh oh!

NikkiWines left a comment

Choose a reason for hiding this comment

Uh oh!

sosek108 commented Mar 18, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 18, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

github-actions bot commented Mar 18, 2026

Uh oh!

OSBotify commented Mar 19, 2026

Uh oh!

OSBotify commented Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sosek108 commented Mar 2, 2026 •

edited

Loading

codecov bot commented Mar 2, 2026 •

edited by github-actions bot

Loading

brunovjk commented Mar 12, 2026 •

edited

Loading