Implement core "Duplicate report" action logic. by Krishna2323 · Pull Request #83896 · Expensify/App

Krishna2323 · 2026-03-02T15:09:45Z

Explanation of Change

Fixed Issues

$ #82153
PROPOSAL:

Tests

1. Basic Report Duplication

Open an expense report with 2-3 cash expenses
Click the three-dot menu
Select "Duplicate report"
Verify button text changes to "Duplicated" with a checkmark, then reverts
Verify you stay on the source report (no navigation)
Verify only one sound plays and duplicate report is created in the expense chat

2. Duplicated Report Name and Contents

After duplicating a report, navigate to the LHN
Find the newly created report
Verify report name is "Copy of [Original report name]"
Verify all expenses from the original are present with same merchant, amount, category, tag, currency
Verify each expense date is today's date (not the original date)
Verify no receipt images are attached to any duplicated expense

3. Modified Merchant Preserved

Edit a merchant on an expense in the source report so modifiedMerchant is set
Duplicate the report
Open the duplicated report
Verify the duplicated expense uses the modified merchant, not the original

4. Card and Scanning Expenses Excluded

Have a report with a mix of: cash expense, corporate card expense, and a scanning receipt
Duplicate the report
Open the duplicated report
Verify only the cash expense appears; card and scanning expenses are excluded

5. Distance Expense Duplication

Have a report with a distance (mileage) expense
Duplicate the report
Open the duplicated report
Verify the distance expense is present with correct distance and amount
Verify it is recognized as a distance type (shows route info)

6. Per Diem Expense Duplication

Have a report with a per diem expense
Duplicate the report
Open the duplicated report
Verify the per diem expense has correct subrates, dates, and amount

7. Mixed Transaction Types

Have a report with cash, distance, and per diem expenses
Duplicate the report
Open the duplicated report
Verify all three appear, each correctly typed

8. Workspace Targeting

Leave a workspace, then open a report from that workspace
Duplicate the report
Verify the duplicated report is created under your default/primary workspace, not the one you left

9. Cross-workspace duplication (not a member of source workspace)**

Leave a workspace, then open a report from that workspace
Duplicate the report
Verify the duplicated report is created under your default/primary workspace
Verify the following transaction types are skipped (not included in the duplicate):
- Per diem expenses
- Distance expenses
- Credit card imported expenses
- Partially created or scanning expenses
- Expenses with a "custom unit out of policy" violation
Verify that cash and time transactions are duplicated correctly

Note: credit card imports, accountant expenses, partial/scanning, and custom unit violations are skipped regardless of whether it's cross-workspace or same-workspace. Per diem and distance are only skipped when the target workspace differs from the source.

Verify that no errors appear in the JS console

Offline tests

Go offline (disconnect network)
Open a report and duplicate it
Verify the optimistic report appears immediately in the LHN with correct name
Verify expenses show in the duplicated report with correct amounts
Go back online
Verify the report syncs successfully with no duplicate reports or "not found" errors

QA Steps

Same as tests
Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

test_1.mp4

test_2.mp4

test_3.mp4

test_4.mp4

test_5.mp4

test_6.mp4

test_7.mp4

test_8.mp4

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 48f6c1199a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/libs/actions/IOU/Duplicate.ts

src/components/MoneyReportHeader.tsx

codecov · 2026-03-02T15:57:48Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`93.60% <ø> (ø)`
src/components/MoneyReportHeaderKYCDropdown.tsx	`0.00% <ø> (ø)`
src/components/MoneyRequestHeader.tsx	`0.00% <ø> (ø)`
src/libs/ReportSecondaryActionUtils.ts	`92.65% <100.00%> (ø)`
src/libs/actions/IOU/PerDiem.ts	`70.56% <100.00%> (+0.65%)`	⬆️
src/libs/actions/IOU/index.ts	`72.92% <100.00%> (+0.04%)`	⬆️
src/libs/actions/Report/index.ts	`67.28% <100.00%> (+0.05%)`	⬆️
src/libs/actions/IOU/Duplicate.ts	`96.86% <94.36%> (-0.88%)`	⬇️
src/components/MoneyReportHeader.tsx	`0.00% <0.00%> (ø)`
... and 140 files with indirect coverage changes

melvin-bot · 2026-03-05T20:46:26Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

- Pass reportName to CREATE_APP_REPORT instead of separate SET_REPORT_NAME call - Route distance/per-diem transactions through specialized creation flows - Exclude pending-deletion expenses from duplication - Add translations for report copy name (en, es) - Add tests for duplicateReport covering filtering and transaction type routing Made-with: Cursor

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2026-03-06T07:23:39Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7bafa0f4f4

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/libs/actions/IOU/Duplicate.ts

…e sounds Signed-off-by: krishna2323 <belivethatkg@gmail.com>

…dback. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

…for accurate running totals. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2026-03-06T17:11:14Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5715b18d41

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/libs/actions/IOU/Duplicate.ts

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Resolve conflicts in MoneyReportHeader.tsx and IOU/index.ts. Per-diem functions were moved to IOU/PerDiem.ts on main; applied feature modifications (shouldPlaySound, optimisticReportPreviewActionID, return iouReport) to PerDiem.ts. Made-with: Cursor

Krishna2323 · 2026-03-10T22:21:54Z

@codex review

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9fa3dce750

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/libs/actions/IOU/Duplicate.ts

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

…ation paths Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2026-03-17T18:46:02Z

@hungvu193 could you please test again?

hungvu193 · 2026-03-18T06:14:06Z

@Krishna2323 Can we prevent the text "Duplicate report" appear again while closing the PopoverMenu?

Screen.Recording.2026-03-18.at.13.13.06.mov

Krishna2323 · 2026-03-18T06:24:06Z

@hungvu193 I think that would need a workaround and would be an overkill. The duplicate expense also behaves the same.

Screen_Recording_20260318_115124_Expensify.mp4

hungvu193 · 2026-03-18T06:27:50Z

@hungvu193 I think that would need a workaround and would be an overkill. The duplicate expense also behaves the same.

Make senses 😄

hungvu193 · 2026-03-18T06:30:14Z

src/components/MoneyReportHeader.tsx

+        wasDuplicateReportTriggered.current = false;
+        dropdownMenuRef.current?.setIsMenuVisible(false);


I guess we need to clean up this effect? Otherwise, we have this issue

Screen.Recording.2026-03-18.at.13.29.37.mov

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2026-03-18T10:13:01Z

@hungvu193 I’ve made some recent changes — could you please check them? I introduced a bug while refactoring.

hungvu193 · 2026-03-18T16:19:49Z

Thanks for the update. I'll review in the morning

Krishna2323 · 2026-03-19T15:56:23Z

@codex review

chatgpt-codex-connector · 2026-03-19T16:23:01Z

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

Failed to set up container

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

hungvu193

Looking good from my end.

There's a small issue here, but I think we can move forward

github-actions · 2026-03-20T13:32:51Z

🚧 @Valforte has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-20T13:37:07Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83896.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-33bd31a-fe6e12a-3794e7177f866b89660ee875e22e1cc6b33126a0/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-33bd31a-fe6e12a-c2e4e52dd4c3b18d9aa456573fc568050ff894b6/index.html

Web 🕸️
https://83896.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-20T14:54:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-03-23T09:50:09Z

🚀 Deployed to staging by https://github.com/Valforte in version: 9.3.42-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

jponikarchuk · 2026-03-23T12:45:25Z

Deploy Blocker #86091 was identified to be related to this PR.

hungvu193 · 2026-03-23T12:52:35Z

Deploy Blocker #86091 was identified to be related to this PR.

Thanks for the ping. Looking into it in a couple of hours

Cc @Krishna2323

jponikarchuk · 2026-03-23T12:57:52Z

Deploy Blocker #86093 was identified to be related to this PR.

jponikarchuk · 2026-03-23T13:08:48Z

Deploy Blocker #86095 was identified to be related to this PR.

Implement core "Duplicate report" action logic.

48f6c11

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 requested review from a team as code owners March 2, 2026 15:09

Krishna2323 marked this pull request as draft March 2, 2026 15:09

chatgpt-codex-connector bot reviewed Mar 2, 2026

View reviewed changes

src/libs/actions/IOU/Duplicate.ts Outdated Show resolved Hide resolved

src/components/MoneyReportHeader.tsx Outdated Show resolved Hide resolved

Merge branch 'main' into krishna2323/issue/82153

ae47408

Krishna2323 added 2 commits March 6, 2026 02:30

fix ESLint.

7bafa0f

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

chatgpt-codex-connector bot reviewed Mar 6, 2026

View reviewed changes

src/libs/actions/IOU/Duplicate.ts Show resolved Hide resolved

src/libs/actions/IOU/Duplicate.ts Outdated Show resolved Hide resolved

Krishna2323 added 4 commits March 6, 2026 21:03

Fix duplicate report preview, remove navigation, and suppress multipl…

5a45141

…e sounds Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Rename DUPLICATE to DUPLICATE_EXPENSE and add duplicate report UI fee…

bdd2c7d

…dback. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Merge branch 'main' into krishna2323/issue/82153

e2eebe2

Return iouReport from createDistanceRequest and submitPerDiemExpense …

5715b18

…for accurate running totals. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

chatgpt-codex-connector bot reviewed Mar 6, 2026

View reviewed changes

src/libs/actions/IOU/Duplicate.ts Outdated Show resolved Hide resolved

Krishna2323 added 4 commits March 7, 2026 02:49

address codex review.

67c0c1d

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

add more tests.

596552b

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Merge branch 'main' into krishna2323/issue/82153

3c85160

fix tests.

b2a8595

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

chatgpt-codex-connector bot reviewed Mar 10, 2026

View reviewed changes

src/libs/actions/IOU/Duplicate.ts Outdated Show resolved Hide resolved

Krishna2323 added 5 commits March 12, 2026 13:21

Merge branch 'Expensify:main' into krishna2323/issue/82153

58e368e

fix split distance transaction case.

2713647

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

minor fix.

213517b

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

add more tests.

80a7aa7

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

fix: pass existingIOUReport through distance and per-diem expense cre…

4d21ec2

…ation paths Signed-off-by: krishna2323 <belivethatkg@gmail.com>

hungvu193 reviewed Mar 18, 2026

View reviewed changes

Krishna2323 added 4 commits March 18, 2026 15:19

Fix popover auto-closing on reopen after duplicate report action

b191499

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Use source report's workspace for duplicate report instead of default

5e049e5

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

pass sourceReport from UI

9611b6b

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

fix tests.

6485987

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

hungvu193 approved these changes Mar 20, 2026

View reviewed changes

melvin-bot bot requested a review from Valforte March 20, 2026 08:07

Valforte approved these changes Mar 20, 2026

View reviewed changes

Valforte merged commit 33bd31a into Expensify:main Mar 20, 2026
33 checks passed

github-actions bot mentioned this pull request Mar 20, 2026

Investigate workflow job failing on main: chooseDeployActions #85948

Closed

OSBotify mentioned this pull request Mar 23, 2026

Deploy Checklist: New Expensify 2026-03-23 #86080

Open

69 tasks

jponikarchuk mentioned this pull request Mar 23, 2026

[RCA #83896] Expense - Second expense shows error when duplicating report on instant submit workflow #86091

Open

7 tasks

jponikarchuk mentioned this pull request Mar 23, 2026

[RCA #83896] Expense - Negative amount is changed to positive amount after duplicating expense #86093

Closed

7 tasks

jponikarchuk mentioned this pull request Mar 23, 2026

[RCA #83896] Expense - Error when duplicating report from deleted workspace #86095

Open

7 tasks

		wasDuplicateReportTriggered.current = false;
		dropdownMenuRef.current?.setIsMenuVisible(false);

Conversation

Krishna2323 commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

1. Basic Report Duplication

2. Duplicated Report Name and Contents

3. Modified Merchant Preserved

4. Card and Scanning Expenses Excluded

5. Distance Expense Duplication

6. Per Diem Expense Duplication

7. Mixed Transaction Types

8. Workspace Targeting

9. Cross-workspace duplication (not a member of source workspace)**

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Mar 2, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Mar 5, 2026

Uh oh!

Krishna2323 commented Mar 6, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Krishna2323 commented Mar 6, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Krishna2323 commented Mar 10, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Krishna2323 commented Mar 17, 2026

Uh oh!

hungvu193 commented Mar 18, 2026

Uh oh!

Krishna2323 commented Mar 18, 2026

Uh oh!

hungvu193 commented Mar 18, 2026

Uh oh!

hungvu193 Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

Krishna2323 Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

Krishna2323 commented Mar 18, 2026

Uh oh!

hungvu193 commented Mar 18, 2026

Uh oh!

Krishna2323 commented Mar 19, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 19, 2026

Uh oh!

hungvu193 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Krishna2323 commented Mar 2, 2026 •

edited

Loading

codecov bot commented Mar 2, 2026 •

edited by github-actions bot

Loading