[No QA] Revert network Sentry spans to reduce 429 rate limiting by roryabraham · Pull Request #83924 · Expensify/App

roryabraham · 2026-03-02T18:37:49Z

Explanation of Change

Reverts #82731 which added Sentry performance spans across the networking pipeline (SequentialQueue, middleware pipeline, OnyxUpdates, RequestThrottle, etc.).

These spans are causing Sentry to rate-limit our app with 429 Too Many Requests errors, which means we're losing important error and performance data. Furthermore, prod data shows that nearly all of these spans are sub-millisecond (except the OnyxUpdates span at P95 6.5ms), so they're not providing useful performance insights relative to the cost of the additional span volume.

Fixed Issues

$ #83923

Tests

Verify that no errors appear in the JS console

Offline tests

N/A — this is a revert of observability instrumentation. No user-facing behavior changes.

QA Steps

No QA — this reverts internal Sentry instrumentation only. No user-facing behavior changes.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

N/A — no UI changes. This is a revert of internal instrumentation code only.

Made with Cursor

…spans" This reverts commit cb56ce7, reversing changes made to f8ce6e9.

codecov · 2026-03-02T18:50:21Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`94.30% <ø> (ø)`
src/libs/API/index.ts	`92.78% <100.00%> (+2.39%)`	⬆️
src/libs/Network/SequentialQueue.ts	`86.55% <100.00%> (+2.36%)`	⬆️
src/libs/Request.ts	`100.00% <100.00%> (ø)`
src/libs/RequestThrottle.ts	`93.33% <100.00%> (-0.79%)`	⬇️
src/libs/actions/OnyxUpdateManager/index.ts	`77.38% <100.00%> (+1.33%)`	⬆️
src/libs/actions/OnyxUpdates.ts	`94.04% <ø> (-1.24%)`	⬇️
... and 13 files with indirect coverage changes

melvin-bot · 2026-03-02T22:06:33Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…spans" This reverts commit cb56ce7, reversing changes made to f8ce6e9. Removes Sentry performance spans from the networking pipeline that were causing 429 rate-limit errors and providing sub-millisecond measurements that don't yield useful performance insights. Made-with: Cursor

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4558e62d4c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-02T22:20:32Z

src/libs/API/index.ts

-                span.setStatus({code: 2, message: error instanceof Error ? error.message : undefined});
-                span.end();
-            });
+        Onyx.update(optimisticData);


Handle rejected optimistic Onyx updates

This change drops the rejection handler that previously wrapped Onyx.update(optimisticData), and the promise is still fire-and-forget. If Onyx.update rejects (for example due to invalid optimistic payload shape or persistence-layer errors), it now becomes an unhandled promise rejection instead of being contained, which can surface as global errors and noisy crash reporting in production.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-03-02T22:20:32Z

src/libs/Network/SequentialQueue.ts

                            queueFlushedDataLength: queueFlushedData.length,
                        });
-                        return Onyx.update(queueFlushedData).then(() => {
+                        Onyx.update(queueFlushedData).then(() => {


Catch failures when applying flushed queue updates

The queue-flush path no longer returns or catches the Onyx.update(queueFlushedData) promise, so a storage failure here now escapes as an unhandled rejection and clearQueueFlushedData() never runs. This is a regression from the previous flow, which attached a .catch(...) to the flush chain, and it can leave queued updates stuck while emitting global async errors.

Useful? React with 👍 / 👎.

Revert "Merge pull request #82731 from Expensify/rory-network-sentry-…

e2ac483

…spans" This reverts commit cb56ce7, reversing changes made to f8ce6e9.

melvin-bot bot assigned roryabraham Mar 2, 2026

roryabraham closed this Mar 2, 2026

roryabraham reopened this Mar 2, 2026

roryabraham marked this pull request as ready for review March 2, 2026 22:06

roryabraham requested review from a team as code owners March 2, 2026 22:06

melvin-bot bot requested review from ZhenjaHorbach and joekaufmanexpensify and removed request for a team March 2, 2026 22:06

melvin-bot bot removed the request for review from a team March 2, 2026 22:06

roryabraham force-pushed the rory-revert-network-sentry-spans branch from 78dba45 to 4558e62 Compare March 2, 2026 22:06

roryabraham closed this Mar 2, 2026

roryabraham deleted the rory-revert-network-sentry-spans branch March 2, 2026 22:09

chatgpt-codex-connector bot reviewed Mar 2, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[No QA] Revert network Sentry spans to reduce 429 rate limiting#83924

[No QA] Revert network Sentry spans to reduce 429 rate limiting#83924
roryabraham wants to merge 2 commits intomainfrom
rory-revert-network-sentry-spans

roryabraham commented Mar 2, 2026

Uh oh!

codecov bot commented Mar 2, 2026 •

edited by github-actions bot

Loading

Uh oh!

melvin-bot bot commented Mar 2, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Mar 2, 2026

Uh oh!

chatgpt-codex-connector bot Mar 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

roryabraham commented Mar 2, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Mar 2, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Mar 2, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

codecov bot commented Mar 2, 2026 •

edited by github-actions bot

Loading