Update TEMPLATE.md to match help site governance #83968
Conversation
Update template to match new help site governance
|
A preview of your ExpensifyHelp changes have been deployed to https://head.helpdot.pages.dev ⚡️ Updated articles: |
Add cross-linking standards to doc
|
@ChavdaSachin Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
HelpDot Documentation ReviewOverall AssessmentThis PR makes two significant governance updates: (1) adding a new Cross-Linking Standards section to the authoring guidelines, and (2) overhauling the article template to replace the legacy structure (generic headings, Liquid includes, vague guidance) with a governance-aligned, AI-retrieval-optimized template. Both changes are well-motivated and represent a meaningful improvement to documentation standards. However, there are a few issues in the proposed changes that should be addressed before merging. Scores Summary
Key FindingsPositive aspects:
Issues that should be addressed:
Recommendations
Files Reviewed
Review generated by HelpDot Summary Reviewer. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 484a6b6918
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Reviewer Checklist
Screenshots/VideosN/A |
|
@chiragsalian Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🎯 @ChavdaSachin, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #83979. |
|
🚀 Deployed to staging by https://github.com/chiragsalian in version: 9.3.32-0 🚀
|
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.3.32-3 🚀
|
Explanation of Change
Update help site article template to match new help site governance
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/605102
PROPOSAL: N/A
Tests
Offline tests
QA Steps
N/A, no tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mp4
Android: mWeb Chrome
android.mweb.mp4
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
web.mp4