-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Fix: Patch PagerViewAdapter to call onTabSelect on initial mount for native #84002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
...act-native-tab-view/react-native-tab-view+4.1.0+004+fix-native-onTabSelect-on-mount.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| diff --git a/node_modules/react-native-tab-view/src/PagerViewAdapter.tsx b/node_modules/react-native-tab-view/src/PagerViewAdapter.tsx | ||
| index d66b0cb..a1b2c3d 100644 | ||
| --- a/node_modules/react-native-tab-view/src/PagerViewAdapter.tsx | ||
| +++ b/node_modules/react-native-tab-view/src/PagerViewAdapter.tsx | ||
| @@ -57,3 +57,5 @@ export function PagerViewAdapter<T extends Route>({ | ||
| const pagerRef = React.useRef<ViewPager>(null); | ||
| const indexRef = React.useRef<number>(index); | ||
| const navigationStateRef = React.useRef(navigationState); | ||
| + const onTabSelectRef = React.useRef(onTabSelect); | ||
| + const hasCalledInitialTabSelectRef = React.useRef(false); | ||
| @@ -64,3 +66,15 @@ export function PagerViewAdapter<T extends Route>({ | ||
| React.useEffect(() => { | ||
| navigationStateRef.current = navigationState; | ||
| + onTabSelectRef.current = onTabSelect; | ||
| }); | ||
| + | ||
| + React.useEffect(() => { | ||
| + if (hasCalledInitialTabSelectRef.current) { | ||
| + return; | ||
| + } | ||
| + hasCalledInitialTabSelectRef.current = true; | ||
| + // Call onTabSelect on initial mount (parity with web PanResponderAdapter patch) | ||
| + requestAnimationFrame(() => { | ||
| + onTabSelectRef.current?.({index: navigationStateRef.current.index}); | ||
| + }); | ||
| + }, []); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MelvinBot Do we need to use useRef here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the
useRefis needed here. TherequestAnimationFrameinside the mount-onlyuseEffect(…, [])creates an asynchronous gap — by the time the rAF callback fires (~16ms later), theonTabSelectcaptured in the closure could be stale if the parent re-rendered in that window. The ref ensures we always call the latest version.That said, the ref pattern also exists for consistency:
PanResponderAdapter(the web adapter) already usesonTabSelectRefas part of its original library source code (PanResponderAdapter.tsx:76), and patch 003 (the web fix) accessesonTabSelectRef.currentthe same way. This patch mirrors that pattern for the native adapter.In practice the stale-closure risk on mount is very small, but the ref costs only two lines and follows the established convention in the same library.