Fix double-computation of requiresAttentionFromCurrentUser in LHN filter loop by sosek108 · Pull Request #84005 · Expensify/App

sosek108 · 2026-03-03T08:57:56Z

Explanation of Change

shouldDisplayReportInLHN already had the pre-computed requiresAttention value available via reportAttributes[reportID].requiresAttention (derived by OnyxDerived), but it was not being forwarded into shouldReportBeInOptionList. As a result, reasonForReportToBeInOptionList was recomputing the value from scratch on every call by invoking requiresAttentionFromCurrentUser → getReasonAndReportActionThatRequiresAttention → getIOUReportActionToApproveOrPay, the last of which does an O(n) Object.values.find scan over all report actions — repeated for every report in the LHN loop.

The fix adds an optional requiresAttention?: boolean field to ShouldReportBeInOptionListParams. When the caller supplies it, reasonForReportToBeInOptionList uses it directly via requiresAttention ?? requiresAttentionFromCurrentUser(...), skipping the expensive recomputation. shouldDisplayReportInLHN now passes the pre-computed value from reportAttributes.

Fixed Issues

$ #83043
PROPOSAL:

Tests

log in in two browsers on separate accounts
1. on account A go to inbox and check LHN for reports that require user’s attention
On account B send a message to A
On A check if new chat shows on LHN
1. click on this chat and click away and verify if chat disappears from LHN
On B send another message to A
On A verify that chat reappers on LHN
On B create new expense for A
On A verify, new expense shows on LHN
On B add a comment to the expens
On A verify that expense with comment appears on LHN

Offline tests

N/A

QA Steps

Same as tests

log in in two browsers on separate accounts
1. on account A go to inbox and check LHN for reports that require user’s attention
On account B send a message to A
On A check if new chat shows on LHN
1. click on this chat and click away and verify if chat disappears from LHN
On B send another message to A
On A verify that chat reappers on LHN
On B create new expense for A
On A verify, new expense shows on LHN
On B add a comment to the expens
On A verify that expense with comment appears on LHN

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

ios.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

wb.mov

… value is available

…quires-attention-v2

melvin-bot · 2026-03-06T07:31:27Z

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 209c16e9c9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-06T07:40:15Z

src/libs/ReportUtils.ts

    }

-    if (requiresAttentionFromCurrentUser(report, undefined, isReportArchived)) {
+    if (requiresAttention ?? requiresAttentionFromCurrentUser(report, undefined, isReportArchived)) {


Recompute attention when cached flag can be stale

Using requiresAttention ?? ... makes a cached false value authoritative, but the derived reportAttributes cache is not refreshed for policy-only changes (reportAttributes compute builds updates from report/reportAction/transaction keys and returns early when only POLICY changes). Since requiresAttentionFromCurrentUser() depends on getPolicy(...).reimbursementChoice, a workspace reimbursement setting change can make a report actionable while requiresAttention remains stale false, and this branch will now suppress it from LHN/GSD instead of recalculating.

Useful? React with 👍 / 👎.

I'm checking this

Actually the problem is not in this file, but in reportAttributes.ts. The mentioned derived value has policies on their dependency list, but never recompute these values when anything in policy change.

@sobitneupane @shubham1206agra do you think I should modify reportAttributes.ts?

@sosek108 Can you put this in #quality channel with impact so we can discuss this?

shubham1206agra · 2026-03-08T13:33:26Z

src/libs/ReportUtils.ts

    isReportArchived: boolean | undefined;
    draftComment: string | undefined;
+    /** Pre-computed value from reportAttributes derived value. When provided, skips the expensive requiresAttentionFromCurrentUser recomputation. */
+    requiresAttention?: boolean;


@sosek108 Can you make this a required parameter? This will help us remove null check from below. NAB but it's good to have.

we want to have this optional as a fallback. And the check below is important so we know if we need to recompute this value.

…quires-attention-v2

sosek108 · 2026-03-09T09:35:19Z

Performance:

Performance benefits are smaller after merging current main

Before:

After:

shubham1206agra · 2026-03-10T12:24:58Z

src/libs/SidebarUtils.ts

    const isFocused = report.reportID === currentReportId;
    const chatReport = reports?.[`${ONYXKEYS.COLLECTION.REPORT}${report?.chatReportID}`];
    const parentReport = reports?.[`${ONYXKEYS.COLLECTION.REPORT}${report.parentReportID}`];
    const hasErrorsOtherThanFailedReceipt = hasReportErrorsOtherThanFailedReceipt(report, chatReport, doesReportHaveViolations, transactionViolations, transactions, reportAttributes);


@sosek108 Can you fix this type error?

…quires-attention-v2

shubham1206agra · 2026-03-10T14:13:35Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
xIf a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-03-10.at.7.42.37.PM.mov

JmillsExpensify

Product behavior outlined in the testing steps looks good.

github-actions · 2026-03-19T16:26:50Z

🚧 @NikkiWines has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-19T16:31:31Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84005.

Android 🤖	iOS 🍎
❌ FAILED ❌	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-1bd7c38-c628576-961e83ec63718b95d7cbda7d0da7981acf939e0d/index.html
The QR code can't be generated, because the Android build failed

Web 🕸️
https://84005.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-19T16:33:09Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-03-19T20:24:06Z

🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.3.41-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-03-23T09:25:54Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.41-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

skip requiresAttentionFromCurrentUser recomputation when pre-computed…

1d554ee

… value is available

melvin-bot bot assigned sosek108 Mar 3, 2026

sosek108 added 2 commits March 3, 2026 10:05

extract requiresAttention to variable to avoid double lookup

a098f5f

Merge remote-tracking branch 'refs/remotes/exfy/main' into fix/lhn-re…

209c16e

…quires-attention-v2

sosek108 marked this pull request as ready for review March 6, 2026 07:31

sosek108 requested review from a team as code owners March 6, 2026 07:31

melvin-bot bot requested a review from sobitneupane March 6, 2026 07:31

melvin-bot bot requested review from JmillsExpensify and removed request for a team March 6, 2026 07:31

chatgpt-codex-connector bot reviewed Mar 6, 2026

View reviewed changes

shubham1206agra reviewed Mar 8, 2026

View reviewed changes

sosek108 added 2 commits March 9, 2026 09:45

Merge remote-tracking branch 'refs/remotes/exfy/main' into fix/lhn-re…

771dbc0

…quires-attention-v2

make reportAttributes required parameter

dc41d99

shubham1206agra reviewed Mar 10, 2026

View reviewed changes

sosek108 added 2 commits March 10, 2026 13:29

Merge remote-tracking branch 'refs/remotes/exfy/main' into fix/lhn-re…

98d7c99

…quires-attention-v2

prettier fix

c23f7ac

JmillsExpensify reviewed Mar 16, 2026

View reviewed changes

shubham1206agra approved these changes Mar 18, 2026

View reviewed changes

melvin-bot bot requested a review from NikkiWines March 18, 2026 19:11

sosek108 mentioned this pull request Mar 19, 2026

[Due for payment 2026-03-30] [Due for payment 2026-03-13] Investigate slow app cold start (11s to reach Settings page) #83043

Open

NikkiWines approved these changes Mar 19, 2026

View reviewed changes

NikkiWines merged commit 1bd7c38 into Expensify:main Mar 19, 2026
31 checks passed

OSBotify mentioned this pull request Mar 19, 2026

Deploy Checklist: New Expensify 2026-03-19 #85862

Closed

Conversation

sosek108 commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 6, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

sosek108 Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

sosek108 Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

shubham1206agra Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

shubham1206agra Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

sosek108 Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

sosek108 commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Performance:

Uh oh!

shubham1206agra Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

shubham1206agra commented Mar 10, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

OSBotify commented Mar 19, 2026

Uh oh!

OSBotify commented Mar 19, 2026

Uh oh!

OSBotify commented Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sosek108 commented Mar 3, 2026 •

edited

Loading

sosek108 commented Mar 9, 2026 •

edited

Loading