[No QA] Use AuthorizeTransaction.allowedAuthenticationMethods directly in useNavigateTo3DSAuthorizationChallenge#84027
Conversation
…NavigateTo3DSAuthorizationChallenge
|
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
I'm gonna have @DylanDylann review this as C+ since he has the most context on the project |
trjExpensify
left a comment
There was a problem hiding this comment.
Core PR for an WN project. 👍
| @@ -1,5 +1,6 @@ | |||
| import {findFocusedRoute} from '@react-navigation/native'; | |||
| import {useEffect, useMemo} from 'react'; | |||
| import AuthorizeTransaction from '@components/MultifactorAuthentication/config/scenarios/AuthorizeTransaction'; | |||
There was a problem hiding this comment.
| import AuthorizeTransaction from '@components/MultifactorAuthentication/config/scenarios/AuthorizeTransaction'; | |
| import {allowedAuthenticationMethods} from '@components/MultifactorAuthentication/config/scenarios/AuthorizeTransaction'; |
There was a problem hiding this comment.
This actually doesn't work here, since it's an object as a default export rather than a set of named exports. Some JS bundlers will allow it anyway because they don't differentiate between an object and a module, but ours doesn't seem to allow it.
Reviewer Checklist
Screenshots/Videos |
|
@MarioExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
MarioExpensify
left a comment
There was a problem hiding this comment.
All good, moving forward with merge!
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @MarioExpensify has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/MarioExpensify in version: 9.3.32-0 🚀
|
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.3.32-3 🚀
|
Explanation of Change
Not sure why, but I'm no longer observing the crash behavior I originally was when I filed #83021. Remove the hard-coded list of allowedAuthenticationMethods, read it directly from the scenario config instead.
Fixed Issues
$ #83021
PROPOSAL:
Tests
useNavigateTo3DSAuthorizationChallenge no-ops in a browser
useNavigateTo3DSAuthorizationChallenge works as expected on mobile native
Offline tests
N/A
QA Steps
N/A - we do not have a way to QA 3DS challenges
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
2026-03-03_04-42-51.mp4
iOS: Native
2026-03-03_04-39-40.mp4
MacOS: Chrome / Safari