[Home Page] Filter cancelled travel reservations from trip data#84038
Conversation
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@mountiny Could you please create adhoc build so @JmillsExpensify could test this? I wasn't able to prepare the testing env on my end, so we may need to iterate 🤞 it won't be necessary |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
I'll switch @JmillsExpensify in for the product review given that this is his baby. |
grgia
left a comment
There was a problem hiding this comment.
report.tripData.payload.pnrs.data.bookingStatus could we handle the higher level case too @adamgrzybowski? There can be a cancelled status on the entire object as well as the legs/flights etc
|
Tests really well. Cancellations are removed pretty much immediately. |
|
I tried uploading the video but GH says it's too big, so you'll just have to believe me haha. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2026-02-26.15.01.10.movAndroid: mWeb Chrome2026-02-26.15.03.19.moviOS: HybridApp2026-02-26.15.01.10.moviOS: mWeb Safari2026-02-26.15.03.19.movMacOS: Chrome / Safari2026-02-26.14.58.06.mov |
|
Few comments left |
|
@adamgrzybowski |
|
@ZhenjaHorbach haha sorry, I had the same PR created on our SWM fork, and I wanted to close it |
|
@ZhenjaHorbach I applied change requests |
|
Jest issues |
|
@adamgrzybowski can you please fix the author checklist? |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.32-0 🚀
|
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.3.32-3 🚀
|
Explanation of Change
Filter out cancelled travel reservations (flights, hotels, cars, and rail) from trip data so they are not displayed in the app. This adds:
PNR_STATUSandLEG_STATUSconstants for identifying cancelled/voided reservationsisPnrCancelledhelper that checks cancellation status across all reservation types (hotel, car, air, rail)getReservationsFromSpotnanaPayloadgetAirReservationsFixed Issues
$ #81529
Tests
Offline tests
N/A - this change only affects data filtering logic, no network requests are modified.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari