Fix search inline filter bar changes being wiped by useSearchFilterSync race condition by adhorodyski · Pull Request #84050 · Expensify/App

adhorodyski · 2026-03-03T16:22:50Z

Explanation of Change

useSearchFilterSync was previously called inside useSearchFiltersBar, which is rendered as part of the inline filter bar. This created a race condition: when a user selects a value in an inline filter (e.g. the "From" filter), the filter picker closes via Modal.close(), which defers Navigation.setParams to after the modal close animation. During that window, useSearchFilterSync would run and overwrite the pending param change with stale values, effectively wiping the user's filter selection.

The fix moves useSearchFilterSync (and its dependency useFilterFormValues) back up to SearchPage.tsx, which is the correct owner of this sync logic. This matches the original placement before PR #83602 and ensures the sync hook runs at the page level rather than inside a child component that may re-render at the wrong time.

Fixed Issues

$ #83988
$ #83951
PROPOSAL:

Tests

Navigate to the Search page and apply a filter using the inline filter bar (e.g. select a contact in the "From" filter).
Verify the filter persists correctly after the filter picker modal closes — the filter value should remain applied in the URL/params and in the filter bar.
Repeat with other inline filters (e.g. date range, merchant, category) to confirm none of them get wiped after modal close.
Navigate away from the Search page and back — verify the filters are still intact.
Verify no JS console errors appear during any of the above steps.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…ition The filter sync hook was moved to useSearchFiltersBar in Expensify#83602, which introduced a race condition where inline filter changes get wiped by the sync hook before Navigation.setParams fires (deferred by Modal.close()). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…-sync

melvin-bot · 2026-03-03T16:24:53Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7c286aafde

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-03T16:31:54Z

src/pages/Search/SearchPage.tsx

    const isMobileSelectionModeEnabled = useMobileSelectionMode(clearSelectedTransactions);

    const queryJSON = useMemo(() => buildSearchQueryJSON(route.params.q, route.params.rawQuery), [route.params.q, route.params.rawQuery]);
+    const filterFormValues = useFilterFormValues(queryJSON);


Keep filter-form subscriptions out of SearchPage

useFilterFormValues() subscribes to broad Onyx collections (CARD_LIST, POLICY, REPORT, etc. in src/hooks/useFilterFormValues.tsx), and this new call in SearchPage makes the entire page re-render whenever those datasets change, even if the search query is unchanged. Because useSearchFiltersBar still calls useFilterFormValues(queryJSON), this commit introduces a second subscription path and expands the rerender scope from the filter bar to the full search screen, which can noticeably degrade performance during frequent Onyx/Pusher updates.

Useful? React with 👍 / 👎.

This used to be the case before https://github.com/Expensify/App/pull/83602/changes

Pujan92 · 2026-03-03T17:29:38Z

@luacmartins I can review this in case we are looking for a C+ as other PR(which I am reviewing) testing needs this to be fixed.

Pujan92 · 2026-03-03T18:53:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Pujan92 · 2026-03-03T19:04:11Z

Bug(not sure): Updated filter value in advance filter visible in the search filter bar without the final button(View Results) click

To highlight, it is not from this PR, reproducible on prod too.

Screen.Recording.2026-03-04.at.00.28.23.mov

Pujan92

LGTM!

Screen.Recording.2026-03-04.at.00.34.26.mov

OSBotify · 2026-03-03T20:36:15Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…ters-sync Fix search inline filter bar changes being wiped by useSearchFilterSync race condition (cherry picked from commit 4283bed) (cherry-picked to staging by blimpich)

github-actions · 2026-03-03T21:10:06Z

🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-03T21:15:49Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84050.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-4283bed-cd8cd82-32a9bb9aa8ec905ab446bbe24b827cb3aa0d2034/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-4283bed-cd8cd82-db089cd56177c05aa70b7133aaa653ce1ba5fde8/index.html

Web 🕸️
https://84050.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-03T21:41:54Z

🚀 Cherry-picked to staging by https://github.com/blimpich in version: 9.3.28-7 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-04T03:21:25Z

🚀 Cherry-picked to staging by https://github.com/blimpich in version: 9.3.30-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-04T18:11:08Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.30-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-04T18:38:03Z

🚀 Cherry-picked to staging by https://github.com/blimpich in version: 9.3.31-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-06T03:50:38Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.31-12 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

adhorodyski and others added 2 commits March 3, 2026 17:20

Merge remote-tracking branch 'exfy/main' into fix-search-page-filters…

7c286aa

…-sync

melvin-bot bot assigned adhorodyski Mar 3, 2026

adhorodyski marked this pull request as ready for review March 3, 2026 16:24

adhorodyski requested review from a team as code owners March 3, 2026 16:24

melvin-bot bot requested review from hungvu193 and removed request for a team March 3, 2026 16:24

melvin-bot bot requested review from trjExpensify and removed request for a team March 3, 2026 16:24

chatgpt-codex-connector bot reviewed Mar 3, 2026

View reviewed changes

luacmartins approved these changes Mar 3, 2026

View reviewed changes

Pujan92 mentioned this pull request Mar 3, 2026

feat/81501: Add Range filter for all date type filters #81897

Merged

53 tasks

yuwenmemon approved these changes Mar 3, 2026

View reviewed changes

yuwenmemon requested review from Pujan92 and removed request for hungvu193 March 3, 2026 18:53

Pujan92 approved these changes Mar 3, 2026

View reviewed changes

melvin-bot bot requested a review from yuwenmemon March 3, 2026 19:13

luacmartins merged commit 4283bed into Expensify:main Mar 3, 2026
31 of 35 checks passed

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Mar 3, 2026

OSBotify mentioned this pull request Mar 3, 2026

Deploy Checklist: New Expensify 2026-03-02 #83947

Closed

adhorodyski deleted the fix-search-page-filters-sync branch March 4, 2026 15:50

melvin-bot bot mentioned this pull request Mar 6, 2026

[Due for payment 2026-03-13] [$250] Expense - Columns show options that are not applicable to IOU expenses #83988

Closed

7 tasks

melvin-bot bot mentioned this pull request Mar 6, 2026

[Due for payment 2026-03-13] [$250] Reports - Reports - Filter is not applied #83951

Closed

7 tasks

Conversation

adhorodyski commented Mar 3, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 3, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

luacmartins Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Pujan92 commented Mar 3, 2026

Uh oh!

Pujan92 commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Pujan92 commented Mar 3, 2026

Uh oh!

Pujan92 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Mar 3, 2026

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

OSBotify commented Mar 3, 2026

Uh oh!

OSBotify commented Mar 4, 2026

Uh oh!

OSBotify commented Mar 4, 2026

Uh oh!

OSBotify commented Mar 4, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Pujan92 commented Mar 3, 2026 •

edited

Loading