Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
I’ll take a look at this one shortly |
|
@suneox please prioritize this one when you're online |
Yes, I'm working on it now. |
| cardList?: OnyxTypes.CardList, | ||
| ): [TransactionCardGroupListItemType[], number] { | ||
| const cardSections: Record<string, TransactionCardGroupListItemType> = {}; | ||
| const cardDescriptionByCardID = new Map<number, string>(); |
There was a problem hiding this comment.
I think we can also move it to the top-level scope of the file.
There was a problem hiding this comment.
I think we can keep it inside the function to avoid issues where the locale is changed and the description doesn't change
There was a problem hiding this comment.
Ah, I agree. I can see the cardTransactions.notActivated translation
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppCleanShot.2026-03-07.at.00.26.37.mp4Android: mWeb ChromeCleanShot.2026-03-07.at.00.26.37.4.mp4iOS: HybridAppCleanShot.2026-03-07.at.00.24.50.3.mp4iOS: mWeb SafariCleanShot.2026-03-07.at.00.23.08.2.mp4MacOS: Chrome / SafariCleanShot.2026-03-07.at.00.12.57.1.mp4 |
|
🚧 @inimaga has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/inimaga in version: 9.3.34-0 🚀
|
|
Hi @luacmartins. Do we need QA this? |
|
@IuliiaHerets yea, you can follow the below: Pre-condition:
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.34-2 🚀
|


Explanation of Change
Caches the
getBankNamefunction to improve performance.Fixed Issues
$ #84064
Tests
N/A
Main

Branch

Offline tests
N/A
QA Steps
Pre-condition:
CardcolumnPR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari