Show Submit/Approve/Pay options when all expenses within a report are selected#84077
Conversation
… selected Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…firmApproval. Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Made-with: Cursor
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
Not sure why ESLint check is failing. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b05d4ed6bd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0472c54bbe
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Review on-going. Waiting for updates. |
|
@Krishna2323 conflicts. and please check #84077 (review) |
…02-2 Made-with: Cursor # Conflicts: # src/components/MoneyReportHeader.tsx # src/components/MoneyReportHeaderKYCDropdown.tsx
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@situchan all done! |
|
Nice! @puneetlath another one of your improvements ready for review. |
|
Sorry for the delay @Krishna2323. Mind fixing the conflicts and then pinging me? |
Krishna2323
dismissed stale reviews from heyjennahay and puneetlath
via
e9e75f2
|
@puneetlath conflicts resolved. |
|
🚧 @puneetlath has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.3.38-0 🚀
|
|
Hi @Krishna2323. Do we have QA steps here? |
|
@IuliiaHerets yes, it's in the OP's QA Test section. |
|
@IuliiaHerets and this feature is web-only. Not available yet on mobile |
|
Deploy Blocker #85413 was identified to be related to this PR. |
|
This PR failing because of the issue #85413 |
|
Closed that issue as not a bug. |
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.38-4 🚀
|
9 participants
Explanation of Change
Fixed Issues
$ #72502
PROPOSAL:
Tests
Same as QA Steps
Verify that no errors appear in the JS console
Offline tests
QA Steps
Submit action via selection mode
Approve action via selection mode
Pay action via selection mode
Approve with delegate restriction (bug fix verification)
Approve with held expenses
Pay as business
Pay with delegate restriction
Partial selection (no report-level actions)
###Non-regression: regular Submit button
Non-regression: regular Approve button
Non-regression: regular Pay button
Non-regression: "More" dropdown
Offline behavior
isDisabled={isOffline})PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android_native.mp4
Android: mWeb Chrome
android_chrome.mp4
iOS: Native
ios_native.mp4
iOS: mWeb Safari
ios_safari.mp4
MacOS: Chrome / Safari
Submit/Approve/Pay action via selection mode
test_1.2.4.mp4
Approve with delegate restriction (bug fix verification)
test_3.mp4
Approve with held expenses
test_5.mp4
Pay as business
test_6.mp4
Partial selection (no report-level actions)
test_8.mp4
Non-regression: regular Submit/Approve/Pay button
test_9.10.11.mp4
Offline behavior
test_9.10.12.mp4
Pay with delegate restriction
delegate_pay_test.mp4