Skip to content

[No QA] Add Expensify Card 3D Secure verification HelpDot article#84098

Merged
stephanieelliott merged 5 commits intomainfrom
claude-3dSecureArticleRevisions
Mar 5, 2026
Merged

[No QA] Add Expensify Card 3D Secure verification HelpDot article#84098
stephanieelliott merged 5 commits intomainfrom
claude-3dSecureArticleRevisions

Conversation

@MelvinBot
Copy link
Contributor

@MelvinBot MelvinBot commented Mar 4, 2026

Explanation of Change

Create help docs for 3DS issues and updating linked phone number

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/606970
PROPOSAL: N/A

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

N/A, no tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android.mp4
Android: mWeb Chrome
android.mweb.mp4
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
web.mp4

Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
@MelvinBot MelvinBot force-pushed the claude-3dSecureArticleRevisions branch from 829f526 to a3caa5d Compare March 4, 2026 00:22
@MelvinBot
Copy link
Contributor Author

Fixed the failing verifySignedCommits check. The original commit was unsigned — I recreated it on top of current main with a proper SSH signature. The article content is identical.

@github-actions github-actions bot changed the title Add Expensify Card 3D Secure verification HelpDot article [No QA] Add Expensify Card 3D Secure verification HelpDot article Mar 4, 2026
@OSBotify
Copy link
Contributor

OSBotify commented Mar 4, 2026

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

HelpDot Documentation Review

Overall Assessment

This PR adds a well-structured, standalone HelpDot article covering Expensify Card 3D Secure verification. The article addresses a clear user need with three task-based sections (approving, troubleshooting, and updating phone number) plus a targeted FAQ. The writing is clean, accessible, and appropriately scoped to a single workflow family. A few gaps against the authoring guidelines and minor style items are noted below.

Scores Summary

  • Readability: 9/10 - Excellent plain-language writing at an appropriate reading level. Steps are clear and sequential. The troubleshooting section uses a helpful bold-label + em-dash pattern that makes scanning easy. One minor concern: the phrase "card provider" is used without ever naming it, which could be slightly ambiguous for readers unfamiliar with the Expensify Card infrastructure.
  • AI Readiness: 7/10 - Headings are descriptive and task-based, keywords are comprehensive, and the description is strong. However, the YAML front matter is missing the internalScope field, which is required by the authoring guidelines (HELP_AUTHORING_GUIDELINES.md, section 3). This field helps AI retrieval systems understand audience, scope, and exclusions. A suitable value would be something like: internalScope: Audience is Expensify Cardholders. Covers approving 3D Secure verification prompts, troubleshooting failed 3D Secure transactions, and updating the phone number linked to an Expensify Card. Does not cover general card decline troubleshooting or Workspace Admin card management.
  • Style Compliance: 8/10 - Good adherence to Expensify terminology (Expensify Card, New Expensify, Concierge, Workspace). Button labels are bolded correctly. Navigation instructions properly separate web and mobile flows. A few items to tighten are listed below.

Key Findings

Strengths:

  • The article solves a focused, well-scoped problem and matches real user search intent (declined 3DS transactions, missing verification prompts, wrong phone number for SMS codes)
  • Keywords list is thorough and includes natural search phrases like "Expensify Card being declined" and "verification code not received"
  • The FAQ section is well-targeted, addressing realistic user confusion points (in-app prompt vs. SMS, desktop support, deny behavior)
  • The troubleshooting section is particularly strong, with actionable steps presented in a logical order
  • Proper use of "Click" for web and "Tap" for mobile throughout

Items to address:

  1. Missing internalScope metadata (required per HELP_AUTHORING_GUIDELINES.md section 3). Several newer articles in the repo include this field. Adding it will improve AI retrieval accuracy.
  2. Heading hierarchy uses # only (no ## sub-sections) -- The authoring guidelines state articles should include "One primary # heading" and "Task-based ## sections." Currently the article uses four # headings plus ## only inside the FAQ. Consider whether the troubleshooting steps or the web/mobile sub-instructions under the phone number section should use ## to create a clearer hierarchy under a primary # heading. That said, the current structure is consistent with several existing sibling articles (e.g., Expensify-Card-Notifications.md), so this is a soft recommendation rather than a blocker.
  3. Navigation instructions for the phone number update (web) -- The article says Click **Settings** in the navigation tabs on the left, but existing sibling articles use a slightly different pattern, e.g., Go to **Account > Wallet > Expensify Card** using the navigation tabs on the left (from Troubleshoot-Expensify-Card-issues.md). Consider aligning with the established breadcrumb pattern: Click **Settings** using the navigation tabs on the left or verifying the exact nav path matches the current UI.
  4. Horizontal rule separators -- Several existing articles in this directory (e.g., Troubleshoot-Expensify-Card-issues.md, Cardholder-Settings-and-Features.md, Expensify-Card-Notifications.md) use --- horizontal rules between major sections. The new article omits these entirely. This is not a guideline requirement, but adding them would improve visual consistency with sibling articles.

Recommendations

  1. (Priority) Add the internalScope YAML field to comply with the authoring guidelines.
  2. (Low priority) Consider adding --- horizontal rules between major sections for visual consistency with sibling articles in the same directory.
  3. (Low priority) Verify that the navigation path for updating phone number matches the current UI exactly (the path Settings > [your name] > Phone number on web and profile picture > Phone number on mobile).

Files Reviewed

  • docs/articles/new-expensify/expensify-card/Expensify-Card-3D-Secure-Verification.md (new file, 71 lines) -- Well-written article with one required metadata gap (internalScope) and minor style alignment opportunities.

Review based on HELP_AUTHORING_GUIDELINES.md and HELPSITE_NAMING_CONVENTIONS.md standards, and comparison with existing articles in docs/articles/new-expensify/expensify-card/.

stephanieelliott and others added 3 commits March 3, 2026 14:39
…ecure-Verification.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Create 3ds article for New Expensify
Fix 'Savee' typo to 'Save' in 3D Secure article, and add
'passcodes' to the cspell word list.

Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
@MelvinBot MelvinBot requested a review from a team as a code owner March 4, 2026 01:02
@MelvinBot
Copy link
Contributor Author

Fixed the failing spellcheck check with two changes:

  1. Typo fix: SaveeSave (with added period) on line 50 of the 3D Secure article
  2. Dictionary update: Added passcodes to the cspell word list in cspell.json

@melvin-bot
Copy link

melvin-bot bot commented Mar 4, 2026

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @lydiabarclay

@melvin-bot melvin-bot bot requested review from AndrewGable and lydiabarclay and removed request for a team March 4, 2026 01:03
@melvin-bot
Copy link

melvin-bot bot commented Mar 4, 2026

@AndrewGable @lydiabarclay One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@stephanieelliott stephanieelliott removed the request for review from AndrewGable March 4, 2026 02:11
@stephanieelliott stephanieelliott merged commit b43e02b into main Mar 5, 2026
17 of 20 checks passed
@stephanieelliott stephanieelliott deleted the claude-3dSecureArticleRevisions branch March 5, 2026 03:37
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

🚧 @stephanieelliott has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify
Copy link
Contributor

OSBotify commented Mar 5, 2026

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Mar 6, 2026

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.32-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Mar 6, 2026

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.32-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants