Skip to content

[No QA] Help site updates for change accounting section into multiple sections#84106

Merged
JmillsExpensify merged 2 commits intomainfrom
helpsite-change-accounting-section
Mar 4, 2026
Merged

[No QA] Help site updates for change accounting section into multiple sections#84106
JmillsExpensify merged 2 commits intomainfrom
helpsite-change-accounting-section

Conversation

@stephanieelliott
Copy link
Contributor

Help site changes for: #82030

…ation and section names for Statement Matching, Reconciliation, and Unapproved Spend. Adjusted instructions and visibility notes for improved clarity.
@stephanieelliott stephanieelliott self-assigned this Mar 4, 2026
@stephanieelliott stephanieelliott changed the title Update reports and expenses documentation to reflect changes in navig… Help site updates for change accounting section into multiple sections Mar 4, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

HelpDot Documentation Review

Overall Assessment

This PR updates three help articles to reflect a UI restructuring where the former single "Accounting" section in the Reports page has been split into two distinct sections: Monthly accrual and Reconciliation, with more granular sub-items under each. The changes are well-scoped and accurately update navigation paths, step-by-step instructions, and FAQ answers. The reconciliation steps have been condensed from 5 steps to 2 by removing filter selections that are now handled by the new navigation structure itself, which is a sensible simplification.

Scores Summary

  • Readability: 8/10 - The updated navigation paths are clear and the condensed reconciliation steps reduce cognitive load. However, the condensed step 2 in both Expensify Card and Out-of-pocket Reconciliation sections packs three distinct actions (group, filter, compare) into a single step, which is slightly dense for a procedural instruction.
  • AI Readiness: 8/10 - Navigation paths are descriptive and use full section names. The new FAQ heading "Why don't I see the Reconciliation section or some of its options?" is more descriptive than the original. YAML metadata (keywords) was not updated to include new terms like "monthly accrual" or "card statements", which could slightly reduce discoverability. No internalScope field is present in any of the files, though this is an existing gap rather than something introduced by this PR.
  • Style Compliance: 7/10 - There is a capitalization inconsistency introduced by the diff: the navigation paths now use lowercase ("Unapproved cash", "Unapproved card") to match the new UI labels, but the unchanged body text in Unapproved-Spend.md still references "Unapproved Cash" and "Unapproved Card" with title case (lines 11 and 63 in the current file). While those lines are outside the diff, the PR creates a visible inconsistency within the same document. Additionally, the keywords in the YAML front matter for both Statement-Matching-and-Reconciliation.md and Unapproved-Spend.md still reference "accounting" and "accounting workflows" but not the new section names.

Key Findings

Positive aspects:

  • All three affected files are updated consistently with the new navigation structure
  • The split from a single "Reconciliation" path into three sub-paths (Card statements, Expensify Card, Reimbursements) accurately reflects the new UI and removes the need for manual "Withdrawal type" filter steps
  • The FAQ in Statement-Matching-and-Reconciliation.md is improved: it now explains conditional visibility of individual options, not just the section as a whole
  • The addition to Using-Search-on-the-Reports-Page.md is appropriately placed and concise, correctly noting these are admin-only sections
  • The new FAQ answer in Unapproved-Spend.md helpfully explains which sub-items appear based on workspace configuration (cash-only vs. card-only)

Items to consider:

  • Condensed reconciliation steps: The original 5-step procedures for Expensify Card and Out-of-pocket Reconciliation have been reduced to 2 steps. While the navigation step is cleaner, step 2 now combines grouping, filtering, and comparing into a single instruction. For users new to reconciliation, breaking "compare totals per withdrawal against your bank statement" into its own step might improve scannability.
  • Capitalization inconsistency in Unapproved-Spend.md: The diff changes the nav paths to lowercase ("Unapproved cash", "Unapproved card") but the body text at line 11 ("two views: Unapproved Cash and Unapproved Card") and the FAQ at line 63 ("Both Unapproved Cash and Unapproved Card") still use title case. If these labels are now lowercase in the UI, the unchanged references should also be updated for consistency.
  • YAML keywords not updated: The keywords metadata in Statement-Matching-and-Reconciliation.md includes "accounting workflows" and "accounting" but does not include "card statements" or "reimbursements reconciliation." Similarly, Unapproved-Spend.md keywords do not include "monthly accrual." Adding these new section names to keywords would improve search discoverability.

Recommendations

  1. Consider updating body text capitalization in Unapproved-Spend.md to match the new lowercase UI labels ("Unapproved cash" / "Unapproved card") at lines 11 and 63, since the diff already establishes lowercase as the correct form.
  2. Consider adding new section names to YAML keywords -- specifically "monthly accrual" for Unapproved-Spend.md, and "card statements" for Statement-Matching-and-Reconciliation.md.
  3. Optional: Split the condensed reconciliation step 2 into two steps (one for grouping/filtering, one for comparing) to maintain the step-by-step clarity that procedural documentation benefits from.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Statement-Matching-and-Reconciliation.md -- Navigation paths, steps, and FAQ updated correctly. Reconciliation steps condensed. No issues in the diff itself.
  • docs/articles/new-expensify/reports-and-expenses/Unapproved-Spend.md -- Navigation paths and FAQ updated. Minor capitalization inconsistency with unchanged body text.
  • docs/articles/new-expensify/reports-and-expenses/Using-Search-on-the-Reports-Page.md -- Clean, well-placed one-line addition for admin sections. No issues.

Review performed on the proposed diff only. Pre-existing content outside the diff was not scored.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot changed the title Help site updates for change accounting section into multiple sections [No QA] Help site updates for change accounting section into multiple sections Mar 4, 2026
@OSBotify
Copy link
Contributor

OSBotify commented Mar 4, 2026

Copy link
Contributor

@JmillsExpensify JmillsExpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, all looks good!

@JmillsExpensify
Copy link
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@JmillsExpensify JmillsExpensify merged commit d294233 into main Mar 4, 2026
13 checks passed
@JmillsExpensify JmillsExpensify deleted the helpsite-change-accounting-section branch March 4, 2026 09:29
@OSBotify
Copy link
Contributor

OSBotify commented Mar 4, 2026

🚀 Deployed to staging by https://github.com/JmillsExpensify in version: 9.3.31-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Mar 6, 2026

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.31-12 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants