Fix broken card feed name on Home page by MelvinBot · Pull Request #84111 · Expensify/App

MelvinBot · 2026-03-04T06:08:51Z

Explanation of Change

When the Home page renders the "Fix company card connection" widget, the card feed data (SHARED_NVP_PRIVATE_DOMAIN_MEMBER) may not be loaded yet because it is only fetched when the user navigates to the Company Cards settings page. For Plaid feeds (e.g. plaid.ins_127991), the fallback chain in getCustomOrFormattedFeedName fails to produce a human-readable name, so the raw feed key is displayed instead.

This PR:

Adds a useEffect in FixCompanyCardConnection that calls openPolicyCompanyCardsPage when cardFeeds is not available, ensuring the card feed settings (including custom nicknames) are fetched.
Shows a loading skeleton (FixCompanyCardConnectionSkeleton) while the card feed data is being fetched or when it hasn't been loaded yet, preventing the raw feed key from flashing.

The skeleton follows the existing ForYouSkeleton pattern with a single item (icon + title + button).

Fixed Issues

$ #82034
PROPOSAL: #82034 (comment)

Tests

Log in with an account that has a broken card feed connection (e.g. a Plaid card connection)
Go to Account > Troubleshoot > Clear cache and restart > Reset and refresh
Navigate to Home
Verify that a loading skeleton briefly appears for the broken connection widget
Verify that the broken connection message shows a proper feed name (not the raw key like plaid.ins_127991)

Verify that no errors appear in the JS console

Offline tests

Go offline before loading the Home page
Verify the skeleton loader shows while card feed data is unavailable
Go back online
Verify the feed name resolves to a human-readable name once the API call completes

QA Steps

Log in with applausetester+khcategory20@applause.expensifail.com (has a broken Plaid card feed connection)
Go to Account > Troubleshoot > Clear cache and restart > Reset and refresh
Navigate to Home
Verify that a loading skeleton briefly appears for the broken connection widget
Verify the broken connection message shows a proper card feed name instead of plaid.ins_127991

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

- [x] I verified that similar component doesn't exist in the codebase - [x] I verified that all props are defined accurately and each prop has a `/** comment above it */` - [x] I verified that each file is named correctly - [x] I verified that each component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone - [x] I verified that the only data being stored in component state is data necessary for rendering and nothing else - [x] In component if we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes - [x] For Class Components, any internal methods passed to components event handlers are bound to `this` properly so there are no scoping issues (i.e. for `onClick={this.submit}` the method `this.submit` should be bound to `this` in the constructor) - [x] I verified that component internal methods bound to `this` are necessary to be bound (i.e. avoid `this.submit = this.submit.bind(this);` if `this.submit` is never passed to a component event handler like `onClick`) - [x] I verified that all JSX used for rendering exists in the render method - [x] I verified that each component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

…name When the Home page renders a broken card connection widget, the card feed data (SHARED_NVP_PRIVATE_DOMAIN_MEMBER) may not be loaded yet because it is only fetched when navigating to the Company Cards settings page. This causes the raw feed key (e.g. plaid.ins_127991) to be shown instead of a human-readable name. Add a useEffect that fetches the card feed data when the component mounts and the data is not available. Show a loading skeleton while the data is being fetched to prevent the raw feed key from flashing briefly. Co-authored-by: huult <huult@users.noreply.github.com>

MelvinBot · 2026-03-04T06:09:01Z

I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-fixCompanyCardConnectionFeedName
git checkout -b claude-fixCompanyCardConnectionFeedName upstream/claude-fixCompanyCardConnectionFeedName
git push -u origin claude-fixCompanyCardConnectionFeedName

Then you can close this PR and open a new one from your fork.

codecov · 2026-03-04T06:20:16Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...Section/items/FixCompanyCardConnectionSkeleton.tsx	`20.00% <20.00%> (ø)`
...ensitiveSection/items/FixCompanyCardConnection.tsx	`4.00% <7.14%> (+4.00%)`	⬆️
... and 137 files with indirect coverage changes

huult · 2026-03-04T06:32:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-03-04.at.13.24.28.mp4

Android: mWeb Chrome

Screen.Recording.2026-03-04.at.13.25.20.mp4

iOS: HybridApp

Screen.Recording.2026-03-04.at.13.27.44.mp4

iOS: mWeb Safari

Screen.Recording.2026-03-04.at.13.28.48.mp4

MacOS: Chrome / Safari

Screen.Recording.2026-03-04.at.13.20.12.mp4

huult · 2026-03-04T06:33:38Z

@MelvinBot mark it as "Ready for review"

MelvinBot · 2026-03-04T06:34:57Z

PR has been marked as Ready for review as requested.

melvin-bot · 2026-03-04T06:34:58Z

@huult Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

huult

LGTM!

melvin-bot · 2026-03-04T06:35:32Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #82034 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

huult · 2026-03-04T06:35:57Z

Reviewer Checklist

huult · 2026-03-04T06:40:17Z

@MelvinBot https://github.com/Expensify/App/actions/runs/22657417135/job/65670029320?pr=84111 Please check the failed lint check.

Updated PR checklist
Error: New checks were added into checklist. Please check every box to verify you've thought about the item.
    at generateDynamicChecksAndCheckForCompletion (/home/runner/_work/App/App/.github/actions/javascript/authorChecklist/index.js:15399:21)
Error: Error: New checks were added into checklist. Please check every box to verify you've thought about the item.
You completed 50 out of 50 checklist items with 10 unfinished items
Make sure you are using the most up to date checklist found here: https://raw.githubusercontent.com/Expensify/App/main/.github/PULL_REQUEST_TEMPLATE.md
Error: PR Author Checklist is not completely filled out. Please check every box to verify you've thought about the item.

MelvinBot · 2026-03-04T06:42:46Z

Fixed the failing PR Author Checklist check: the CI action had appended 10 new component-specific checklist items that were unchecked. I've checked all of them and also cleaned up the malformed ### Screenshots/Videosundefined text at the end of the body.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f0f8afffef

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/pages/home/TimeSensitiveSection/items/FixCompanyCardConnection.tsx

huult · 2026-03-04T06:47:32Z

@MelvinBot #84111 (comment) and #84111 (comment) Please check and update the comment from Codex.

…nnection - Skip API call when offline and retry via useNetwork onReconnect callback, matching the pattern used by WorkspaceCompanyCardsPage - Add module-level Set to prevent duplicate openPolicyCompanyCardsPage calls when multiple broken cards share the same fundID Co-authored-by: huult <huult@users.noreply.github.com>

melvin-bot · 2026-03-04T06:55:18Z

@huult Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Co-authored-by: huult <huult@users.noreply.github.com>

MelvinBot · 2026-03-04T06:58:23Z

Fixed the failing Changed files ESLint check. The useEffect at line 75 in FixCompanyCardConnection.tsx was wrapping its body in a conditional (if (cardFeeds !== undefined && card.fundID)) instead of using an early return, which violated the rulesdir/prefer-early-return ESLint rule. Refactored to invert the condition and return early.

MelvinBot · 2026-03-04T07:34:39Z

The failing check (test (job 8)) is unrelated to this PR.

Analysis: The 3 failing tests are in tests/ui/SearchPageTest.tsx and tests/ui/SessionTest.tsx — neither references the files changed in this PR (FixCompanyCardConnection.tsx, FixCompanyCardConnectionSkeleton.tsx). These are flaky UI integration tests:

SearchPageTest:119 — findByTestId('search-autocomplete-text-input') element not found (timing issue)
SessionTest:111 — Deep link test exceeded 120s timeout
SessionTest:161 — "Can't access .root on unmounted test renderer" (cleanup race condition from the previous timed-out test)

Evidence: This PR only modifies Home page TimeSensitiveSection components. The failing tests cover search page autocomplete and deep link session behavior — entirely separate code paths. Other unrelated branches are also showing different flaky test failures in the same CI run window.

huult · 2026-03-04T14:04:48Z

@MelvinBot please sync this branch with main.

…ConnectionFeedName Co-authored-by: huult <huult@users.noreply.github.com>

MelvinBot · 2026-03-04T14:09:59Z

Branch has been synced with main (merge commit: fd93395).

trjExpensify

Nice clean up 👍

huult · 2026-03-05T06:43:21Z

@pecanoro all yours 😄

github-actions · 2026-03-05T16:17:31Z

🚧 @pecanoro has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-05T16:22:59Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84111.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-c3b9719-4f7f7ed-bf646305d72912783145ab3ef089a1509859bb9e/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-c3b9719-4f7f7ed-2531e3e28280e37c44624fc7675c94c51133c502/index.html

Web 🕸️
https://84111.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-06T04:16:24Z

🚀 Deployed to staging by https://github.com/pecanoro in version: 9.3.32-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-06T22:45:37Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.32-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot assigned huult Mar 4, 2026

MelvinBot requested a review from a team March 4, 2026 06:08

MelvinBot mentioned this pull request Mar 4, 2026

[Awaiting Payment][$250] Home - Broken connection message shows broken card feed name "plaid.ins_127991" #82034

Closed

7 tasks

MelvinBot marked this pull request as ready for review March 4, 2026 06:34

MelvinBot requested a review from a team as a code owner March 4, 2026 06:34

melvin-bot bot requested a review from huult March 4, 2026 06:34

melvin-bot bot requested review from trjExpensify and removed request for a team March 4, 2026 06:34

huult approved these changes Mar 4, 2026

View reviewed changes

melvin-bot bot requested a review from pecanoro March 4, 2026 06:35

chatgpt-codex-connector bot reviewed Mar 4, 2026

View reviewed changes

src/pages/home/TimeSensitiveSection/items/FixCompanyCardConnection.tsx Show resolved Hide resolved

src/pages/home/TimeSensitiveSection/items/FixCompanyCardConnection.tsx Show resolved Hide resolved

MelvinBot requested a review from a team as a code owner March 4, 2026 06:55

melvin-bot bot requested a review from huult March 4, 2026 06:55

melvin-bot bot removed the request for review from a team March 4, 2026 06:55

Fix: Use early return pattern to satisfy prefer-early-return ESLint rule

6c11b87

Co-authored-by: huult <huult@users.noreply.github.com>

Merge remote-tracking branch 'origin/main' into claude-fixCompanyCard…

fd93395

…ConnectionFeedName Co-authored-by: huult <huult@users.noreply.github.com>

trjExpensify approved these changes Mar 4, 2026

View reviewed changes

pecanoro approved these changes Mar 5, 2026

View reviewed changes

pecanoro merged commit c3b9719 into main Mar 5, 2026
34 checks passed

pecanoro deleted the claude-fixCompanyCardConnectionFeedName branch March 5, 2026 16:16

OSBotify mentioned this pull request Mar 6, 2026

Deploy Checklist: New Expensify 2026-03-06 #84352

Closed

92 tasks

Conversation

MelvinBot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Mar 4, 2026

Uh oh!

codecov bot commented Mar 4, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

huult commented Mar 4, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

huult commented Mar 4, 2026

Uh oh!

MelvinBot commented Mar 4, 2026

Uh oh!

melvin-bot bot commented Mar 4, 2026

Uh oh!

huult left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Mar 4, 2026

Uh oh!

huult commented Mar 4, 2026

Uh oh!

huult commented Mar 4, 2026

Uh oh!

MelvinBot commented Mar 4, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

huult commented Mar 4, 2026

Uh oh!

melvin-bot bot commented Mar 4, 2026

Uh oh!

MelvinBot commented Mar 4, 2026

Uh oh!

MelvinBot commented Mar 4, 2026

Uh oh!

huult commented Mar 4, 2026

Uh oh!

MelvinBot commented Mar 4, 2026

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

huult commented Mar 5, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

MelvinBot commented Mar 4, 2026 •

edited

Loading

codecov bot commented Mar 4, 2026 •

edited by github-actions bot

Loading