Remove unnecessary custom types from translations - Batch 11 by jakubstec · Pull Request #84118 · Expensify/App

jakubstec · 2026-03-04T07:56:42Z

Explanation of Change

Continue the work of @mrejdak removing unnecessary custom types from translations. His last PR:
#80342. (Batch 10, currently Batch 11).

Fixed Issues

$ #76429

PROPOSAL: #76429 (comment)

Tests

Testing every modified component is not necessary since the changes are all related to types only, and TypeScript already checks types and enforces correct parameter usage.

Below are a few example places where the changes can be observed in the UI.

WorkspaceMembersPage.tsx
1. Click Workspaces
2. Select a workspace
3. Click Members
4. You'll see the members count text at the top.

WorkspaceOverviewSharePage.tsx
1. Click Workspaces
2. Select a workspace
3. Click Overview
4. Click More, then Share
5. You'll see the share note with an #admin room link.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

iOS: Native

WorkspaceMembersPage.tsx

Simulator Screenshot - iPhone 14 Pro - 2026-03-03 at 12 39 30

WorkspaceOverviewSharePage.tsx

MacOS: Chrome / Safari

WorkspaceMembersPage.tsx

WorkspaceOverviewSharePage.tsx

melvin-bot · 2026-03-04T07:56:48Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

github-actions · 2026-03-04T07:57:03Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

jakubstec · 2026-03-04T07:58:02Z

I have read the CLA Document and I hereby sign the CLA

sumo-slonik · 2026-03-06T08:53:05Z

Nice work 🚀

codecov · 2026-03-06T14:15:03Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/AddressForm.tsx	`98.00% <100.00%> (ø)`
...components/OnboardingMergingAccountBlockedView.tsx	`92.30% <ø> (ø)`
...m/TransactionPreview/TransactionPreviewContent.tsx	`77.31% <ø> (ø)`
...ponents/SupportalPermissionDeniedModalProvider.tsx	`100.00% <100.00%> (ø)`
src/components/UploadFile.tsx	`0.00% <ø> (ø)`
src/libs/ReportNameUtils.ts	`84.05% <100.00%> (+0.54%)`	⬆️
...ilValidation/BaseOnboardingWorkEmailValidation.tsx	`95.00% <ø> (ø)`
src/pages/ReportChangeApproverPage.tsx	`0.00% <ø> (ø)`
src/pages/inbox/report/PureReportActionItem.tsx	`56.74% <ø> (-0.02%)`	⬇️
.../pages/settings/Subscription/PaymentCard/index.tsx	`91.66% <ø> (ø)`
... and 26 more
... and 356 files with indirect coverage changes

…rom-translations-batch1

github-actions · 2026-03-09T15:36:38Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

…ove-unnecessary-types-from-translations-batch1 # Conflicts: # src/languages/de.ts # src/languages/en.ts # src/languages/es.ts # src/languages/fr.ts # src/languages/it.ts # src/languages/ja.ts # src/languages/nl.ts # src/languages/pl.ts # src/languages/pt-BR.ts # src/languages/zh-hans.ts

jakubstec · 2026-03-09T16:01:43Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

I had some difficulties while making the 'merge commit' verified, so please ignore.

melvin-bot · 2026-03-10T08:25:40Z

@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

trjExpensify · 2026-03-10T11:47:50Z

PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself.

…rom-translations-batch1

…ypes

jakubstec · 2026-03-11T13:35:50Z

hey @QichenZhu, whenever you get a chance, could you take a look at this PR? thanks!

…rom-translations-batch1

QichenZhu · 2026-03-12T11:33:27Z

This PR is quite large. I'll get back to you by Monday.

QichenZhu · 2026-03-16T01:32:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

Simulator Screenshot - iPhone 17 - 2026-03-16 at 14 29 38

Simulator Screenshot - iPhone 17 - 2026-03-16 at 14 29 45

iOS: mWeb Safari

Simulator Screenshot - iPhone 17 - 2026-03-16 at 14 30 38

Simulator Screenshot - iPhone 17 - 2026-03-16 at 14 30 44

MacOS: Chrome / Safari

QichenZhu

Some minor style or typo issues.

src/languages/es.ts

src/languages/nl.ts

QichenZhu

Thanks!

github-actions · 2026-03-16T17:51:32Z

🚧 @iwiznia has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-03-16T17:52:21Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-03-16T17:55:02Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84118.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-7713882-a6a9d5f-67aff241e9e59e4d00ddfc2b8c090bc34471907d/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-7713882-a6a9d5f-ae8cd9cb4d9c28b1b0240dd3d59fc01738f396e8/index.html

Web 🕸️
https://84118.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-17T11:55:20Z

🚀 Deployed to staging by https://github.com/iwiznia in version: 9.3.39-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-18T13:02:26Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.39-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

melvin-bot bot assigned jakubstec Mar 4, 2026

CLABotify added a commit to Expensify/CLA that referenced this pull request Mar 4, 2026

@jakubstec has signed the CLA in Expensify/App#84118

ab8dc95

jakubstec added 3 commits March 4, 2026 11:43

(refactor): simplify translation param types to standalone params

72966ec

(refactor): simplify translation param types to standalone params part2

3d8ad12

(refactor): run prettier

eaf6024

jakubstec force-pushed the feature/jakubstec/remove-unnecessary-types-from-translations-batch1 branch from f881164 to eaf6024 Compare March 4, 2026 10:44

jakubstec mentioned this pull request Mar 5, 2026

Remove unnecessary custom types from translations - Batch 12 #84256

Draft

52 tasks

jakubstec force-pushed the feature/jakubstec/remove-unnecessary-types-from-translations-batch1 branch from 27563c8 to eaf6024 Compare March 9, 2026 14:18

Merge branch 'main' into feature/jakubstec/remove-unnecessary-types-f…

e188fbf

…rom-translations-batch1

jakubstec force-pushed the feature/jakubstec/remove-unnecessary-types-from-translations-batch1 branch 4 times, most recently from 2047994 to e244325 Compare March 9, 2026 15:36

jakubstec force-pushed the feature/jakubstec/remove-unnecessary-types-from-translations-batch1 branch 2 times, most recently from c8bb068 to bf598f6 Compare March 9, 2026 15:57

jakubstec force-pushed the feature/jakubstec/remove-unnecessary-types-from-translations-batch1 branch from bf598f6 to 1b00c86 Compare March 9, 2026 15:59

fix type error

31e00f9

fix type errors

79aadb9

jakubstec marked this pull request as ready for review March 10, 2026 08:25

jakubstec requested review from a team as code owners March 10, 2026 08:25

melvin-bot bot requested a review from QichenZhu March 10, 2026 08:25

melvin-bot bot requested review from trjExpensify and removed request for a team March 10, 2026 08:25

melvin-bot bot removed the request for review from a team March 10, 2026 08:25

trjExpensify removed their request for review March 10, 2026 11:48

jakubstec and others added 5 commits March 11, 2026 09:07

Merge branch 'main' into feature/jakubstec/remove-unnecessary-types-f…

8425ff9

…rom-translations-batch1

Resolve errors after merge

1eada14

revert deletion of SizeExceededParams and NotAllowedExtensionParams t…

c68bcfc

…ypes

add missing type annotations

d147f30

rerun tests

397c690

jakubstec mentioned this pull request Mar 11, 2026

[$250] Remove unnecessary types from translations #76429

Open

Merge branch 'main' into feature/jakubstec/remove-unnecessary-types-f…

7c29a51

…rom-translations-batch1

QichenZhu suggested changes Mar 16, 2026

View reviewed changes

src/languages/es.ts Outdated Show resolved Hide resolved

src/languages/es.ts Outdated Show resolved Hide resolved

src/languages/nl.ts Outdated Show resolved Hide resolved

fix: typo and style issues found in review

18506c4

QichenZhu approved these changes Mar 16, 2026

View reviewed changes

melvin-bot bot requested a review from iwiznia March 16, 2026 07:15

iwiznia approved these changes Mar 16, 2026

View reviewed changes

iwiznia merged commit 7713882 into Expensify:main Mar 16, 2026
33 checks passed

OSBotify mentioned this pull request Mar 17, 2026

Deploy Checklist: New Expensify 2026-03-17 #85529

Closed

75 tasks

Conversation

jakubstec commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 4, 2026

Uh oh!

github-actions bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakubstec commented Mar 4, 2026

Uh oh!

sumo-slonik commented Mar 6, 2026

Uh oh!

codecov bot commented Mar 6, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Mar 9, 2026

Uh oh!

jakubstec commented Mar 9, 2026

Uh oh!

melvin-bot bot commented Mar 10, 2026

Uh oh!

trjExpensify commented Mar 10, 2026

Uh oh!

jakubstec commented Mar 11, 2026

Uh oh!

QichenZhu commented Mar 12, 2026

Uh oh!

QichenZhu commented Mar 16, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

QichenZhu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

QichenZhu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 16, 2026

Uh oh!

OSBotify commented Mar 16, 2026

Uh oh!

github-actions bot commented Mar 16, 2026

Uh oh!

OSBotify commented Mar 17, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jakubstec commented Mar 4, 2026 •

edited

Loading

github-actions bot commented Mar 4, 2026 •

edited

Loading

codecov bot commented Mar 6, 2026 •

edited by github-actions bot

Loading