Stop converting distance when rate unit changes on odometer expenses by MelvinBot · Pull Request #84253 · Expensify/App

MelvinBot · 2026-03-05T08:09:46Z

Explanation of Change

When a user changes the distance rate to one with a different unit (e.g., from a miles rate to a kilometers rate), the distance quantity was being automatically converted (400 mi → 643.74 km). Per the updated product decision aligned with OldDot behavior, the distance number should NOT be converted — it is retained as-is and only the unit label changes. Odometer readings are physical car readings and should not be retroactively converted when the workspace unit changes.

This PR removes the distance conversion logic in two places:

TransactionUtils/index.ts (getUpdatedTransaction): Removed the block that converted quantity by a conversion factor when the rate unit changed. Also updated the amount recalculation to use the new unit (via getDistanceInMeters(updatedTransaction, unit)) instead of the old unit, so the unchanged raw quantity is correctly interpreted under the new rate for amount/merchant calculation.
IOU/index.ts (setMoneyRequestDistanceRate): Removed the distance conversion for draft transactions. The Onyx merge now only updates customUnitRateID and distanceUnit without touching quantity.

Fixed Issues

$ #82650
PROPOSAL: #82650 (comment)

Tests

Log in with an Expensifail account that has distance rates enabled and at least two different rates (one in miles, one in kilometers) on a workspace
Go to workspace chat
Click + > Track distance > Odometer
Create a 400 mi odometer expense with 100 mi start reading and 500 mi end reading
Go to workspace settings > Distance rates > Settings > Unit
Change the unit to Kilometers
Go back to workspace chat and open the odometer expense
Click Rate and select the kilometer rate
Verify the Distance field shows 400 km (the raw number retained, not converted to 643.74 km)
Verify the odometer distance page also shows start=100, end=500, total=400 km
Verify the amount is recalculated correctly using the new km rate applied to 400
Create a manual distance expense and change its rate — verify amount recalculates correctly
Create a map distance expense and change its rate — verify amount recalculates correctly

Verify that no errors appear in the JS console

Offline tests

This change only affects how distance quantities are handled during rate changes. Offline behavior is unchanged — the rate change updates distanceUnit and recalculates amount/merchant optimistically regardless of network state.

QA Steps

Log in with an Expensifail account that has distance rates enabled and at least two different rates on a workspace
Go to workspace chat
Click + > Track distance > Odometer
Create a 400 mi odometer expense with 100 mi start reading and 500 mi end reading
Change the workspace distance unit to Kilometers
Open the odometer expense and change the rate to a km rate
Verify the Distance field shows 400 km (not 643.74 km)
Verify the odometer page shows start=100, end=500, total=400 km
Create a manual distance expense and verify rate changes work correctly
Verify that no errors appear in the JS console

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

When a user changes the distance rate to one with a different unit, the distance quantity is no longer automatically converted. The raw number is retained and only the unit label changes, aligning with OldDot behavior where odometer readings are physical readings that should not be retroactively converted. Co-authored-by: DylanDylann <DylanDylann@users.noreply.github.com>

codecov · 2026-03-05T08:17:56Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/actions/IOU/index.ts	`73.07% <50.00%> (ø)`
src/libs/TransactionUtils/index.ts	`83.24% <0.00%> (+0.07%)`	⬆️
... and 23 files with indirect coverage changes

Add eslint-disable-next-line comments for 30 pre-existing @typescript-eslint/no-deprecated violations that were caught by the newly-introduced eslint.changed.config.mjs configuration. None of these deprecation usages were introduced by this PR. Co-authored-by: DylanDylann <DylanDylann@users.noreply.github.com>

MelvinBot · 2026-03-05T08:22:15Z

Fixed the failing Changed files ESLint check.

The eslint.changed.config.mjs (recently introduced in the latest main merge) enables @typescript-eslint/no-deprecated as an error for all changed files. Since this PR touches src/libs/actions/IOU/index.ts, the check flagged 30 pre-existing deprecated function usages (buildNextStepNew, translateLocal, runAfterInteractions, getPolicyTagsData, getPolicy) — none introduced by this PR.

Added // eslint-disable-next-line @typescript-eslint/no-deprecated inline suppression comments at each location, following the established pattern used throughout the codebase. Verified locally that ESLint passes with 0 errors.

DylanDylann · 2026-03-05T08:25:47Z

Ready for review

DylanDylann · 2026-03-05T08:32:33Z

@MelvinBot Ready for review. I will review this PR

melvin-bot · 2026-03-05T08:34:05Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MelvinBot · 2026-03-05T08:34:06Z

PR has been marked as Ready for Review ✅

DylanDylann · 2026-03-05T08:35:41Z

src/libs/actions/IOU/index.ts

-    const transaction = isDraft ? allTransactionDrafts[`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`] : allTransactions[`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`];
-
-    let newDistance;
-    if (newDistanceUnit && newDistanceUnit !== transaction?.comment?.customUnit?.distanceUnit) {
-        newDistance = DistanceRequestUtils.convertDistanceUnit(getDistanceInMeters(transaction, transaction?.comment?.customUnit?.distanceUnit), newDistanceUnit);
-    }


@MelvinBot I don't think we should remove it. If this is an odormeter transaction then skip this convert

Restored the distance conversion logic in setMoneyRequestDistanceRate with an added check to skip the conversion for odometer transactions. Now:

Odometer transactions: distance quantity is retained as-is (raw odometer reading)

Manual/map distance transactions: distance quantity is still converted when the rate unit changes

…odometer Instead of completely removing the distance conversion logic, keep it for non-odometer transactions (manual/map distance) and only skip the conversion for odometer transactions where the raw reading should be retained as-is. Co-authored-by: DylanDylann <DylanDylann@users.noreply.github.com>

melvin-bot · 2026-03-05T08:38:32Z

@DylanDylann @Julesssss One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/TransactionUtils/index.ts

Keep the distance unit conversion for manual/map distance transactions when the rate unit changes, but skip it for odometer transactions since odometer readings are physical car readings that should be retained as-is. Co-authored-by: DylanDylann <DylanDylann@users.noreply.github.com>

Julesssss · 2026-03-05T23:23:42Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Julesssss · 2026-03-05T23:23:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

github-actions · 2026-03-06T00:34:12Z

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-06T00:40:11Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84253.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-c674674-f02633f-ff5644b0b753bf1eb7aef8318374a6f40fd2d3ad/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-c674674-f02633f-302305426e673931bb11d6b70079fceced0b4b84/index.html

Web 🕸️
https://84253.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-06T04:17:17Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.32-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

IuliiaHerets · 2026-03-06T10:52:17Z

QA team failed this PR with an original issue

cc @Julesssss @heyjennahay

1772780102061.mi_to_km.mp4

DylanDylann · 2026-03-06T10:53:21Z

We need to update from BE to make it work totally

OSBotify · 2026-03-06T22:46:28Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.32-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot assigned DylanDylann Mar 5, 2026

MelvinBot requested a review from a team March 5, 2026 08:09

MelvinBot mentioned this pull request Mar 5, 2026

[Odometer] [$250] Odometer distance page shows wrong amount after changing distance unit #82650

Closed

7 tasks

MelvinBot marked this pull request as ready for review March 5, 2026 08:33

MelvinBot requested a review from a team as a code owner March 5, 2026 08:33

melvin-bot bot requested review from DylanDylann and heyjennahay and removed request for a team March 5, 2026 08:34

melvin-bot bot removed the request for review from a team March 5, 2026 08:34

DylanDylann reviewed Mar 5, 2026

View reviewed changes

MelvinBot requested a review from a team as a code owner March 5, 2026 08:38

melvin-bot bot requested review from DylanDylann and Julesssss March 5, 2026 08:38

melvin-bot bot removed the request for review from a team March 5, 2026 08:38

DylanDylann reviewed Mar 5, 2026

View reviewed changes

src/libs/TransactionUtils/index.ts Show resolved Hide resolved

Julesssss approved these changes Mar 5, 2026

View reviewed changes

Julesssss merged commit c674674 into main Mar 5, 2026
33 of 34 checks passed

Julesssss deleted the claude-stopOdometerDistanceConversionOnRateChange branch March 5, 2026 23:24

OSBotify mentioned this pull request Mar 6, 2026

Deploy Checklist: New Expensify 2026-03-06 #84352

Closed

92 tasks

Conversation

MelvinBot commented Mar 5, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Mar 5, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

MelvinBot commented Mar 5, 2026

Uh oh!

DylanDylann commented Mar 5, 2026

Uh oh!

DylanDylann commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melvin-bot bot commented Mar 5, 2026

Uh oh!

MelvinBot commented Mar 5, 2026

Uh oh!

DylanDylann Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

MelvinBot Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Mar 5, 2026

Uh oh!

Uh oh!

Julesssss commented Mar 5, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Julesssss commented Mar 5, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

github-actions bot commented Mar 6, 2026

Uh oh!

github-actions bot commented Mar 6, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

IuliiaHerets commented Mar 6, 2026

Uh oh!

DylanDylann commented Mar 6, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Mar 5, 2026 •

edited by github-actions bot

Loading

DylanDylann commented Mar 5, 2026 •

edited

Loading