Align optimistic task chatType inheritance with backend behavior by c3024 · Pull Request #84263 · Expensify/App

c3024 · 2026-03-05T10:01:33Z

Explanation of Change

This PR aligns optimistic task report chatType behavior with backend task creation behavior.

Adds optional parentChatType input to buildOptimisticTaskReport.
Inherits chatType only when parent chatType is policyAdmins.
Keeps chatType unset for policyExpenseChat (and other chat types), so tasks are not misclassified.
Updates task creation and onboarding task flows to pass parent chatType into buildOptimisticTaskReport.
Adds regression tests to verify:
- tasks in admins rooms get chatType: policyAdmins
- tasks in policy expense chats keep chatType unset

Fixed Issues

$ #84258
PROPOSAL: N/A

Tests

Turn off network.
Create a task in an admins room.
Verify from Application > Storage > Onyx DB, the task report keyValuePairs includes chatType: policyAdmins.
Create a task in a policy expense chat.
Verify from Application > Storage > Onyx DB, the task report keyValuePairs does not include chatType: policyExpenseChat.
Turn on network and verify step 3 and 5.

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Create a task in an admins room.
Go to the task report and add a comment.
Verify that you see a message "Concierge is thinking" in the report.
Create a task in a policy expense chat.
Verify that you do not see a message "Concierge is thinking" in the report.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…ment

codecov · 2026-03-06T06:28:07Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/ReportUtils.ts	`79.61% <100.00%> (+0.03%)`	⬆️
src/libs/actions/Task.ts	`52.53% <100.00%> (ø)`
... and 37 files with indirect coverage changes

c3024 · 2026-03-16T05:15:08Z

Auth PR merged. I will continue working on this once the Auth PR is deployed to production.

c3024 · 2026-03-17T05:16:27Z

@codex review

…ment

chatgpt-codex-connector · 2026-03-17T05:37:15Z

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

We were unable to download your code in a timely manner.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

c3024 · 2026-03-17T05:48:57Z

@MelvinBot is the Jest Unit Test failure related to this PR?

MelvinBot · 2026-03-17T05:50:40Z

No, the failing Jest test is not related to this PR.

Failing test: tests/ui/SessionTest.tsx — "should not remember the report path of the last deep link login after signing out and in again" (timeout after 120s)

Why it's unrelated:

This PR modifies src/libs/ReportUtils.ts, src/libs/actions/Task.ts, and tests/actions/TaskTest.ts — none of which are related to the session/deep-linking test.
The exact same test (SessionTest.tsx) is also failing on main with the identical timeout error, confirming it's a pre-existing flaky test.

melvin-bot · 2026-03-17T05:55:03Z

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0a649012e0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/libs/ReportUtils.ts

Ensure onboarding tasks inherit policyAdmins when admins chat data is fallback-only, and strengthen unit coverage by asserting chatType on each generated onboarding task report.

c3024 · 2026-03-17T06:32:21Z

@codex review.

chatgpt-codex-connector · 2026-03-17T06:41:34Z

Codex Review: Didn't find any major issues. Hooray!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

joekaufmanexpensify · 2026-03-17T21:47:18Z

No product review needed

…ment

c3024 · 2026-03-23T04:42:47Z

Sobit does not seem to have enough spare cycles to review this. @shubham1206agra, would you like to review this?

shubham1206agra · 2026-03-23T06:45:07Z

@c3024 I will review this shortly then

src/libs/actions/Task.ts

shubham1206agra · 2026-03-30T08:59:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
xIf a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-03-30.at.2.25.22.PM.mov

melvin-bot · 2026-03-30T08:59:30Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #84258 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

src/libs/ReportUtils.ts

Use optional chaining to read chatType from targetChatReport, avoiding a verbose object/type guard.

…ment

arosiclair · 2026-03-31T12:35:28Z

@c3024 I don't think Applause can follow the QA steps you listed since it involves debugging Onyx. Can you update those to something they can test?

…ment

c3024 · 2026-04-01T12:01:30Z

Yes, they might not be able to follow the steps. Updated them. Thanks!

OSBotify · 2026-04-02T15:36:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-04-02T15:55:18Z

🚧 @arosiclair has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-02T16:00:31Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84263.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-26f9ae1-9f1b0ad-0a79936beae2168a2513c412dee66ed2dd58adf2/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-26f9ae1-9f1b0ad-268bd62f525d16118b50b44206db6f5a28da862d/index.html

Web 🕸️
https://84263.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-02T20:19:05Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.3.52-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-02T20:20:31Z

No help site changes are required for this PR.

The changes here are purely internal — they align the optimistic task report's chatType field in the Onyx data store with what the backend already produces. No user-facing behavior, UI labels, workflows, or features are affected.

The existing help article at docs/articles/new-expensify/chat/Assign-Tasks.md remains accurate as-is.

OSBotify · 2026-04-07T01:10:01Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.52-9 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Align optimistic task chatType inheritance with backend behavior

f16ab1d

melvin-bot bot assigned c3024 Mar 5, 2026

c3024 added 2 commits March 5, 2026 15:39

Merge branch 'main' into chaitanya/fix-task-optimistic-chatType-align…

c2efd22

…ment

Merge branch 'main' into chaitanya/fix-task-optimistic-chatType-align…

4abcdd2

…ment

c3024 changed the title ~~Align optimistic task chatType inheritance with backend behavior~~ [HOLD Auth#20242] Align optimistic task chatType inheritance with backend behavior Mar 6, 2026

Merge branch 'main' into chaitanya/fix-task-optimistic-chatType-align…

0a64901

…ment

c3024 changed the title ~~[HOLD Auth#20242] Align optimistic task chatType inheritance with backend behavior~~ Align optimistic task chatType inheritance with backend behavior Mar 17, 2026

c3024 mentioned this pull request Mar 17, 2026

[Due for payment 2026-04-14] Align optimistic task chatType with Auth for admins-room tasks #84258

Open

c3024 marked this pull request as ready for review March 17, 2026 05:54

c3024 requested review from a team as code owners March 17, 2026 05:54

c3024 marked this pull request as draft March 17, 2026 05:55

melvin-bot bot requested review from joekaufmanexpensify and sobitneupane and removed request for a team March 17, 2026 05:55

melvin-bot bot removed the request for review from a team March 17, 2026 05:55

c3024 marked this pull request as ready for review March 17, 2026 05:59

chatgpt-codex-connector bot reviewed Mar 17, 2026

View reviewed changes

src/libs/ReportUtils.ts Outdated Show resolved Hide resolved

Preserve policyAdmins chatType in onboarding task fallback

b94401b

Ensure onboarding tasks inherit policyAdmins when admins chat data is fallback-only, and strengthen unit coverage by asserting chatType on each generated onboarding task report.

joekaufmanexpensify removed their request for review March 17, 2026 21:47

Merge branch 'main' into chaitanya/fix-task-optimistic-chatType-align…

d7ddff5

…ment

c3024 requested review from shubham1206agra and removed request for sobitneupane March 23, 2026 06:55

shubham1206agra reviewed Mar 23, 2026

View reviewed changes

src/libs/actions/Task.ts Show resolved Hide resolved

shubham1206agra approved these changes Mar 30, 2026

View reviewed changes

melvin-bot bot requested a review from arosiclair March 30, 2026 08:59

arosiclair reviewed Mar 30, 2026

View reviewed changes

src/libs/ReportUtils.ts Show resolved Hide resolved

arosiclair reviewed Mar 30, 2026

View reviewed changes

src/libs/ReportUtils.ts Outdated Show resolved Hide resolved

c3024 added 3 commits March 30, 2026 21:46

Simplify onboarding target chatType access.

4f59d6b

Use optional chaining to read chatType from targetChatReport, avoiding a verbose object/type guard.

Merge branch 'main' into chaitanya/fix-task-optimistic-chatType-align…

df089a5

…ment

Merge branch 'main' into chaitanya/fix-task-optimistic-chatType-align…

3e5b625

…ment

c3024 requested a review from arosiclair March 31, 2026 08:19

arosiclair approved these changes Mar 31, 2026

View reviewed changes

Merge branch 'main' into chaitanya/fix-task-optimistic-chatType-align…

be428f0

…ment

c3024 requested a review from arosiclair April 1, 2026 12:01

arosiclair merged commit 26f9ae1 into Expensify:main Apr 2, 2026
32 checks passed

OSBotify mentioned this pull request Apr 2, 2026

Deploy Checklist: New Expensify 2026-04-02 #86989

Closed

jponikarchuk mentioned this pull request Apr 3, 2026

[Exploratory] - Chat - The Concierge message is displayed with a user’s custom avatar #87043

Open

7 tasks

Conversation

c3024 commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Mar 6, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

c3024 commented Mar 16, 2026

Uh oh!

c3024 commented Mar 17, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 17, 2026

Uh oh!

c3024 commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MelvinBot commented Mar 17, 2026

Uh oh!

melvin-bot bot commented Mar 17, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

c3024 commented Mar 17, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 17, 2026

Uh oh!

joekaufmanexpensify commented Mar 17, 2026

Uh oh!

c3024 commented Mar 23, 2026

Uh oh!

shubham1206agra commented Mar 23, 2026

Uh oh!

Uh oh!

shubham1206agra commented Mar 30, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 30, 2026

Uh oh!

Uh oh!

Uh oh!

arosiclair commented Mar 31, 2026

Uh oh!

c3024 commented Apr 1, 2026

Uh oh!

Uh oh!

OSBotify commented Apr 2, 2026

Uh oh!

github-actions bot commented Apr 2, 2026

Uh oh!

github-actions bot commented Apr 2, 2026

Uh oh!

OSBotify commented Apr 2, 2026

Uh oh!

MelvinBot commented Apr 2, 2026

Uh oh!

OSBotify commented Apr 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

c3024 commented Mar 5, 2026 •

edited

Loading

codecov bot commented Mar 6, 2026 •

edited by github-actions bot

Loading

c3024 commented Mar 17, 2026 •

edited

Loading