[NoQA] Bump `eslint-config-expensify` and add `context-provider-split-values` eslint rule by staszekscp · Pull Request #84274 · Expensify/App

staszekscp · 2026-03-05T12:38:15Z

Explanation of Change

This PR bumps eslint-config-expensify to add a rule that forbids to mix state and actions in the context provider value.

Fixed Issues

$ #80271
PROPOSAL: N/A

Tests

Eslint rule in an IDE

Pick any context provider.
To the actionsValue object add a new key that is not a function
To the stateValue object add new key with a function
See if errors ar detected by eslint

TabSelectorContext

Go to FAB -> Track Distance
See if you can switch the tabs correctly and the picked one gets highlighted

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-03-13.at.10.24.57.mov

melvin-bot · 2026-03-05T12:38:21Z

@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-03-05T12:38:22Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

codecov · 2026-03-05T12:47:05Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/LocaleContextProvider.tsx	`83.72% <ø> (ø)`
src/components/TabSelector/TabSelectorBase.tsx	`8.33% <ø> (ø)`
src/components/TabSelector/TabSelectorItem.tsx	`100.00% <ø> (ø)`
...gPersonalDetails/MissingPersonalDetailsContent.tsx	`0.00% <ø> (ø)`
...s/MissingPersonalDetails/subPages/Confirmation.tsx	`0.00% <ø> (ø)`
src/pages/MissingPersonalDetails/subPages/PIN.tsx	`0.00% <ø> (ø)`
.../Wallet/TravelCVVPage/TravelCVVContextProvider.tsx	`100.00% <100.00%> (+37.50%)`	⬆️
...es/settings/Wallet/TravelCVVPage/TravelCVVPage.tsx	`0.00% <ø> (ø)`
...allet/TravelCVVPage/TravelCVVVerifyAccountPage.tsx	`0.00% <ø> (ø)`
src/components/TabSelector/TabSelectorContext.tsx	`13.33% <40.00%> (+2.22%)`	⬆️
... and 4 more
... and 28 files with indirect coverage changes

staszekscp · 2026-03-06T07:59:46Z

Marking as ready for review just to test the workflows!

…-eslint-rule

joekaufmanexpensify · 2026-03-06T20:48:12Z

No product review needed

mkhutornyi · 2026-03-09T09:11:27Z

Is this on hold for Expensify/eslint-config-expensify#176 or ready for review?

staszekscp · 2026-03-10T12:13:50Z

Hey @mkhutornyi! I think we can hold it for a moment until the conversation is resolved in the eslint PR. When I get a green light from @mountiny I think you can proceed with testing here!

mountiny · 2026-03-12T21:15:55Z

The eslint was merged so we can update this PR I think

…-eslint-rule

staszekscp · 2026-03-13T10:39:14Z

Hey! 👋🏻 The PR is basically ready, but I'm not able to test the TravelCVV and PINContext flows, since I don't have access to do it - @mkhutornyi are you able to see if they work fine? If not I can revert them and just disable the rule for them

mkhutornyi · 2026-03-13T14:26:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

mkhutornyi · 2026-03-13T14:30:05Z

src/pages/MissingPersonalDetails/PINContext.tsx

        setIsPINHidden((prev) => !prev);
    }, []);

-    // Clear PIN when the context provider unmounts (user leaves the flow)


Keep original comment

mkhutornyi · 2026-03-13T14:33:06Z

src/pages/settings/Wallet/TravelCVVPage/TravelCVVPage.tsx

    const {isAccountLocked} = useLockedAccountState();
    const {showLockedAccountModal} = useLockedAccountActions();

-    // Get CVV from context - shared with TravelCVVVerifyAccountPage


Keep original comment

mkhutornyi · 2026-03-13T15:08:15Z

Hey! 👋🏻 The PR is basically ready, but I'm not able to test the TravelCVV and PINContext flows, since I don't have access to do it - @mkhutornyi are you able to see if they work fine? If not I can revert them and just disable the rule for them

I am not able to access these pages either. For this testing, I think we need help from engineer.
Codewise looks good.

chatgpt-codex-connector · 2026-03-13T15:09:22Z

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

mkhutornyi · 2026-03-13T15:19:43Z

I tried to test manually with deep link but not working properly (same on main)
We need real account to test.

Screen.Recording.2026-03-13.at.3.10.05.pm.mov

mountiny · 2026-03-15T23:14:25Z

@staszekscp can you please resolve conflicts?

…-eslint-rule

mountiny

Looking good, thank you!

github-actions · 2026-03-16T12:35:39Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-16T12:42:30Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84274.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-e08fca0-a6a9d5f-67aff241e9e59e4d00ddfc2b8c090bc34471907d/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-e08fca0-a6a9d5f-ae8cd9cb4d9c28b1b0240dd3d59fc01738f396e8/index.html

Web 🕸️
https://84274.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-16T12:43:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-03-17T11:55:23Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.39-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-18T13:02:29Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.39-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

Test es-lint change

eb1ff12

staszekscp requested a review from a team as a code owner March 5, 2026 12:38

melvin-bot bot assigned staszekscp Mar 5, 2026

melvin-bot bot requested review from mkhutornyi and removed request for a team March 5, 2026 12:38

staszekscp marked this pull request as draft March 5, 2026 12:38

Test es-lint change

9af4fcc

staszekscp marked this pull request as ready for review March 6, 2026 07:59

staszekscp added 7 commits March 6, 2026 09:00

Merge remote-tracking branch 'origin/main' into perf/migrate-contexts…

078a45f

…-eslint-rule

Merge remote-tracking branch 'origin/main' into perf/migrate-contexts…

bcb2486

…-eslint-rule

Test es-lint change

8fc87dc

Test es-lint change

f84b3b3

Test new implementation

f984ac4

Test new implementation

493e9bb

Disable rules where necessary

09fffc5

staszekscp requested a review from a team as a code owner March 6, 2026 12:09

melvin-bot bot requested review from joekaufmanexpensify and removed request for a team March 6, 2026 12:09

Update the rule

a215d5d

joekaufmanexpensify removed their request for review March 6, 2026 20:48

Update the rule

c4fa942

staszekscp changed the title ~~Test es-lint change~~ Bump eslint-config-expensify and add context-provider-split-values eslint rule Mar 13, 2026

staszekscp added 6 commits March 13, 2026 08:25

Migrate TravelCVVContext

7ddeba9

Migrate ScrollableTabSelectorContext

8e6c922

Remove comments

6e5e76e

Restore ScrollableTabSelector

aedc26b

Merge remote-tracking branch 'origin/main' into perf/migrate-contexts…

ca1d7bc

…-eslint-rule

Migrate TabSelectorContext

390a484

staszekscp changed the title ~~Bump eslint-config-expensify and add context-provider-split-values eslint rule~~ [NoQA] Bump eslint-config-expensify and add context-provider-split-values eslint rule Mar 13, 2026

staszekscp added 2 commits March 13, 2026 10:36

Merge remote-tracking branch 'origin/main' into perf/migrate-contexts…

3786af2

…-eslint-rule

Migrate PINContext

4838eac

mkhutornyi reviewed Mar 13, 2026

View reviewed changes

mkhutornyi approved these changes Mar 13, 2026

View reviewed changes

melvin-bot bot requested a review from mountiny March 13, 2026 15:20

staszekscp added 3 commits March 16, 2026 09:35

Merge remote-tracking branch 'origin/main' into perf/migrate-contexts…

89fc746

…-eslint-rule

Readd a removed comment and fix TS after merge

33de937

Fix linter

8a32880

mountiny approved these changes Mar 16, 2026

View reviewed changes

mountiny merged commit e08fca0 into Expensify:main Mar 16, 2026
41 of 42 checks passed

OSBotify mentioned this pull request Mar 17, 2026

Deploy Checklist: New Expensify 2026-03-17 #85529

Closed

75 tasks

melvin-bot bot mentioned this pull request Mar 18, 2026

[Due for payment 2026-03-25] [Due for payment 2026-03-11] Split context providers to return State and Actions separately #80271

Open

Conversation

staszekscp commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 5, 2026

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

codecov bot commented Mar 5, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

staszekscp commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joekaufmanexpensify commented Mar 6, 2026

Uh oh!

mkhutornyi commented Mar 9, 2026

Uh oh!

staszekscp commented Mar 10, 2026

Uh oh!

mountiny commented Mar 12, 2026

Uh oh!

staszekscp commented Mar 13, 2026

Uh oh!

mkhutornyi commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mkhutornyi Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

mkhutornyi Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

mkhutornyi commented Mar 13, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 13, 2026

Uh oh!

mkhutornyi commented Mar 13, 2026

Uh oh!

mountiny commented Mar 15, 2026

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 16, 2026

Uh oh!

github-actions bot commented Mar 16, 2026

Uh oh!

OSBotify commented Mar 16, 2026

Uh oh!

OSBotify commented Mar 17, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

staszekscp commented Mar 5, 2026 •

edited

Loading

codecov bot commented Mar 5, 2026 •

edited by github-actions bot

Loading

staszekscp commented Mar 6, 2026 •

edited

Loading

mkhutornyi commented Mar 13, 2026 •

edited

Loading