Skip to content

fix: Updated task title isn't reflected in Reports > Chats in Offline and infinite loading when click on the time of the task in Reports > Chats#84290

Merged
inimaga merged 9 commits intoExpensify:mainfrom
Uzaifm127:fix/84134
Mar 18, 2026

Conversation

@Uzaifm127
Copy link
Contributor

Explanation of Change

In this PR, we are solving three things:

  1. When click on the time of offline created Task in Reports > Chats, it shows infinite loading
  2. Offline created Task title isn't reflecting the updated title in Reports > Chats after updating the title offline.
  3. Clean the unnecessary snapshot type in failure data.

Fixed Issues

$ #84134
PROPOSAL:

Tests

  1. Open the app either in mobile or web.
  2. Go to Reports > Chats and let it load completely.
  3. Go offline.
  4. Create a task to 1:1 chat.
  5. Go to Reports > Chats (or select Type: chat from dropdown in Reports page).
  6. Click on the Task (on the task which we added from Reports > Chats).
  7. Update the title of the task (we still needs to be offline while updating).
  8. Verify that the title of the task is updated correctly and reflected the updated title in Reports > Chats.
  9. Now staying on Reports > Chats page, click on the time of the offline created task.
  10. Verify that the RHP opens up without the infinite loading.
  • Verify that no errors appear in the JS console

Offline tests

Same as Test

QA Steps

Same as Test

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android-native.mp4
Android: mWeb Chrome
Android-mweb.mp4
iOS: Native
ios-native.mp4
iOS: mWeb Safari
ios-mweb.mp4
MacOS: Chrome / Safari
macOS.mp4

… and infinite loading when click on the time of the task in Reports > Chats
@Uzaifm127 Uzaifm127 requested review from a team as code owners March 5, 2026 15:36
@melvin-bot melvin-bot bot requested review from a team and hungvu193 and removed request for a team March 5, 2026 15:36
@melvin-bot
Copy link

melvin-bot bot commented Mar 5, 2026

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested review from heyjennahay and inimaga and removed request for a team March 5, 2026 15:36
@melvin-bot
Copy link

melvin-bot bot commented Mar 5, 2026

@inimaga Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@Uzaifm127
Copy link
Contributor Author

The failing eslint test seems unrelated to the changes made in this PR as buildNextStepNew and runAfterInteractions were added a long time ago. Though they are deprecated now.

@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/libs/actions/Report/index.ts 66.70% <100.00%> (ø)
src/libs/SearchUIUtils.ts 69.86% <66.66%> (-0.05%) ⬇️
src/components/Search/index.tsx 33.57% <0.00%> (-0.13%) ⬇️
src/components/ReportActionItem/TaskPreview.tsx 0.00% <0.00%> (ø)
src/libs/actions/Task.ts 46.66% <27.27%> (-0.84%) ⬇️
... and 5 files with indirect coverage changes

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 17c4dbe1da

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@hungvu193
Copy link
Contributor

@Uzaifm127 Can you merge main to resolve these ESlint issue? Also can you please provide more context about the RCA so I can review it more carefully? Thanks

@Uzaifm127
Copy link
Contributor Author

Will provide RCA within 3 hours.

@Uzaifm127
Copy link
Contributor Author

Uzaifm127 commented Mar 6, 2026

RCA analysis

Issue 1 root cause (title not updating in Reports > Chats)

In created-task chat rows, TaskPreview builds the displayed title with:

const taskTitle = action?.childReportName ?? taskReport?.reportName ?? '';

action.childReportName is a snapshot value from the task-created action, so after offline rename it can stay stale.

Issue 2 root cause (timestamp click opens infinite-loading RHP offline)

In Search chat-row navigation, we always routed with reportActionID for report-action items:

const reportActionID = reportActionItem.reportActionID;
Navigation.navigate(ROUTES.SEARCH_REPORT.getRoute({reportID, reportActionID, backTo}));

For offline-created task rows, that action can still be optimistic/in-flight (isOptimisticAction or pendingAction: ADD), so anchoring to that reportActionID (the app may not be able to resolve that ID in the target report’s loaded actions at navigation time) can fail in RHP resolution and cause indefinite loading.

The bug is specifically in the “anchor-to-action” navigation decision, not in generic report opening.

@Uzaifm127
Copy link
Contributor Author

Soon I'll review this and provide the overview of what this PR changes.

@Uzaifm127
Copy link
Contributor Author

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@Uzaifm127
Copy link
Contributor Author

In this PR, we are:

  1. prioritizing the task report name instead of the child report name from snapshot.
  2. skipping the reportActionID only for offline, non-optimistic created task.
  3. Removed the snapshot type from failure data.
  4. Using parent report id instead of child one, using getReportOrDraftReport as prior and data[${ONYXKEYS.COLLECTION.REPORT}${reportID}] as fallback.

@hungvu193
Copy link
Contributor

Looking good so far! I'm doing some testing

@Uzaifm127
Copy link
Contributor Author

I'm doing some testing

@hungvu193 Can you tell me what kind of testing you are doing? Just curious to know.

@hungvu193
Copy link
Contributor

I'm doing some testing

@hungvu193 Can you tell me what kind of testing you are doing? Just curious to know.

Nothing special, just general testing, QA steps, offline steps, simulate connection fail...

@hungvu193
Copy link
Contributor

hungvu193 commented Mar 11, 2026

@Uzaifm127 It doesn't update the task title for me, can you take a look?

Screen.Recording.2026-03-11.at.12.36.23.mov

@Uzaifm127
Copy link
Contributor Author

@hungvu193 Checking from my side...

@Uzaifm127
Copy link
Contributor Author

mac-chrome.mov

@hungvu193 Fixed!

The issue you pointed out only occuring when we created the task online and then update the online created task offline.

Previously (before the fix):

  1. offline created task - offline task update -> reflected the true value.
  2. online created task - online task update -> reflected the true value.
  3. online created task - offline task update -> Didn't reflect the true value. (This is the case which I fixed now).

@hungvu193
Copy link
Contributor

hungvu193 commented Mar 12, 2026

@Uzaifm127 Can you check this bug?

  1. Create task online.
  2. Go offline > Edit task title , description.
  3. Go to Reports > Chats > Verify they're updated.
  4. Go back to that Report Screen > Marks that task as completed.
  5. Go to Reports > Chats > See the task status.
Screen.Recording.2026-03-12.at.23.40.51.mov
Screen.Recording.2026-03-12.at.23.43.16.mov

@hungvu193
Copy link
Contributor

Follup-up from #84290 (comment) There's an inconsistency between Task between Reports > Chats and inside Report Screen. We can't mark task as completed in Reports > Chats after editing offline, but we can do it inside Report Sreen (Check the second video).

@hungvu193
Copy link
Contributor

@MelvinBot Review this pull request, check the optimisticData that is added, and verify if there's lack of optimistic data

@MelvinBot
Copy link
Contributor

Optimistic Data Review for PR #84290

I reviewed all the optimistic, success, and failure data in this PR. Here's the analysis:


1. editTaskchildReportName sync (Task.ts)

What's added:

  • optimisticData (line 618–628): Updates parentReportAction.childReportName to parsedTitle when the task title is edited
  • failureData (line 666–676): Reverts childReportName to report.reportName on API failure

Missing successData?No, this is correct. The omission of successData for childReportName follows the established pattern in this codebase. For example, buildTaskData sets childStateNum/childStatusNum on the parent report action optimistically and reverts on failure, but also omits successData for those fields. The server response provides the authoritative values via Onyx merge, so explicit successData is unnecessary.

No pendingAction/pendingFields on the parent report action update — Also consistent with existing patterns. Only the task report itself gets pending indicators; the parent action's child fields are updated silently.

Verdict: ✅ Complete — optimistic + failure data are both present and follow established conventions.


2. TaskPreview.tsx — Priority swap

Changed from action?.childReportName ?? taskReport?.reportNametaskReport?.reportName ?? action?.childReportName.

This is the right call. taskReport comes from Onyx (live data reflecting optimistic updates), while action.childReportName is a snapshot that could be stale. Combined with the editTask optimistic update above, both sources now stay in sync — taskReport.reportName is the primary display path, and childReportName is the fallback when the task report object isn't loaded.

Verdict: ✅ Correct approach.


3. SearchUIUtils.tsgetReportOrDraftReport fallback chain

The old code only looked up reports from the search API response data (data[...]). The new code adds getReportOrDraftReport() which reads from Onyx memory first, where optimistic/draft reports exist. This ensures offline-created task reports (which exist in Onyx but not in the search API snapshot) can be resolved for display.

The fallback chain tries 4 sources: getReportOrDraftReport(reportIDFromKey)getReportOrDraftReport(reportAction.reportID)data[reportIDFromKey]data[reportAction.reportID].

Verdict: ✅ Good coverage. This matches the existing pattern in getTaskSections (line 2041–2042) which already uses getReportOrDraftReport.


4. SearchUIUtils.tsreportID always uses reportIDFromKey

Changed from reportAction.reportID ?? reportIDFromKeyreportIDFromKey.

For task-creation actions (ADD_COMMENT with taskReportID), reportAction.reportID could point to the child task report, causing navigation to the wrong chat. Since search data groups actions under reportActions_{parentReportID}, reportIDFromKey is always the parent/container report. The overridden reportID is then written into the item and consumed by ChatListItem.tsx:30 via useOnyx.

Verdict: ✅ Correct. Thread/task actions in search data are grouped by parent report, so this should always resolve correctly.


5. Search/index.tsx — Skip reportActionID for optimistic task actions

The condition isCreatedTaskReportAction(reportActionItem) && (isOptimisticAction || pendingAction === ADD) is specific enough:

  • isCreatedTaskReportAction requires ADD_COMMENT type + taskReportID in original message — regular chat messages won't match
  • isOptimisticAction is set to true during creation (ReportUtils.ts:6416) and cleared to null on success (Task.ts:309)
  • pendingAction === ADD covers the edge case where isOptimisticAction might already be cleared but the action is still pending

When reportActionID is undefined, ROUTES.SEARCH_REPORT.getRoute generates search/view/${reportID} without the action suffix, which navigates to the report without anchoring to a specific action. This avoids the infinite loading.

Verdict: ✅ Correct and specific enough to avoid false positives.


6. Type annotation cleanup (SNAPSHOT removal)

Removed ONYXKEYS.COLLECTION.SNAPSHOT from failureData type annotations in both Task.ts and Report/index.ts. The failureData arrays never actually pushed snapshot entries, so this is purely a type cleanup.

Verdict: ✅ Harmless cleanup.


Summary

Area Optimistic Success Failure Verdict
editTask → parent action childReportName ✅ Added — (not needed, follows pattern) ✅ Added Complete
editTask → task report reportName ✅ Pre-existing ✅ Pre-existing ✅ Pre-existing Complete
createTaskAndNavigate → parent action childReportName ✅ Pre-existing (set in builder) — (server provides value) ✅ Pre-existing Complete
Search navigation → optimistic action handling ✅ Correctly skips deep-link N/A N/A Complete
TaskPreview → title display priority ✅ Reads live Onyx first N/A N/A Complete

I don't see any missing optimistic data. The optimistic/failure data additions for childReportName in editTask follow established patterns, the search components correctly handle optimistic reports via getReportOrDraftReport, and the deep-link skip prevents infinite loading for unresolved action IDs.

… offline and enable the task checkbox in Reports page
@Uzaifm127
Copy link
Contributor Author

Uzaifm127 commented Mar 15, 2026

@hungvu193

Fixed the two issues which you shared in the video, i.e. 1. Task status isn't synched, 2. Task status can't be updated from Reports > Chats.

I wanna give an overview of what we are solving:

There are 5 different issues which we are solving in this PR:

  1. Infinite loading when clicking on the time of Task row in Reports > Chats, only and only if the task was created offline. (This was the follow up issue).
  2. Updated task title isn't reflected in Reports > Chats when updated the title offline and the task was also created offline (This was the follow up issue).
  3. Updated task title isn't reflected in Reports > Chats when updated the task title offline and created the task online. (This is on staging too).
  4. The checkbox to mark the task completed or incomplete in Reports > Chats from Task row is disabled, that's why user can't mark the task completed from Reports > Chats unless tweaked from report screen. (This is on staging too. This feels so wierd to me as sometimes it happens and sometime its not, it seems like this issue doesn't occur when we tweaked the status in report screen).
  5. The task status isn't synched between Report screen and Reports > Chats unless we tweaked the status from report screen by going online then went offline again to test. (This is on staging too)

Issue 3, 4 and 5 are already existing issues which wasn't being covered in the scope of this PR.

Hans, can Melvin update the PR description to include the additional issues?

staging testing 1
staging-testing-1.mp4
staging testing 2
staging-testing-2.mp4
after the changes
solution-testing.mp4

@hungvu193
Copy link
Contributor

Cool. Thanks for your update. I'll verify the changes

@hungvu193
Copy link
Contributor

Hans, can Melvin update the PR description to include the additional issues?

He can if we assign @MelvinBot to this issue 😄

@Uzaifm127
Copy link
Contributor Author

He can if we assign @MelvinBot to this issue 😄

It's He. 😄,

Jokes apart, I'll update the PR description tomorrow or the day after tomorrow once the PR got approved.

Copy link
Contributor

@hungvu193 hungvu193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you merge main? I got this weird issue where the chat list is reversed?

Image

const taskReportID = taskReport?.reportID ?? action?.childReportID;
// Prefer the live task report name so offline title edits are reflected immediately.
const taskTitle = taskReport?.reportName ?? action?.childReportName ?? '';
const taskContextReport = React.useMemo(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove useMemo here and let's react-compiler do its job.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Uzaifm127 can you update this?

Copy link
Contributor Author

@Uzaifm127 Uzaifm127 Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a min...

Looking into that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the useMemo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also getting the wierd issue on latest main.

main-issue.mp4

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it happens randomly, I couldn't reproduce it now.

@hungvu193
Copy link
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android.mov
Android: mWeb Chrome
mChrome.mov
iOS: HybridApp
IOS.mov
iOS: mWeb Safari
Safari.mov
MacOS: Chrome / Safari
Chrome.mov

@hungvu193
Copy link
Contributor

@inimaga This is waiting for your final review

@inimaga inimaga merged commit 3866888 into Expensify:main Mar 18, 2026
41 of 44 checks passed
@github-actions
Copy link
Contributor

🚧 @inimaga has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/inimaga in version: 9.3.40-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/inimaga in version: 9.3.40-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.41-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants