Fix crash in Android workspace invite member flow#84298
Fix crash in Android workspace invite member flow#84298marcochavezf merged 6 commits intoExpensify:mainfrom
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid.movandroid.mp4Android: mWeb Chromemchrome.moviOS: HybridAppios.moviOS: mWeb Safarimsafari.movMacOS: Chrome / Safariweb.mov |
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@marufsharifi please correct tests step. no Invite button in More menu - overview > tap more > tap invite > invite a new user.
+ overview > tap invite > invite a new user. |
|
There was recent change on this file. |
|
@situchan, I've addressed your comment. Please take another look. thanks. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @marcochavezf has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.3.34-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.34-2 🚀
|
Explanation of Change
Auto‑focus now waits for the actual screen transition to finish (with a safe timeout fallback) before focusing the input. This prevents focus timing issues during navigation while keeping the existing safeguards for input readiness and side‑panel behavior.
Fixed Issues
$ #74153
PROPOSAL: #74153 (comment)
Tests
overview > tap invite > invite a new user.overview > tap invite > invite a new user.Offline tests
Same as Tests.
QA Steps
Same as Tests.
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.native.mp4
Android: mWeb Chrome
Screen.Recording.2026-03-05.at.10.24.33.PM.mp4
iOS: Native
ion.mp4
iOS: mWeb Safari
Screen.Recording.2026-03-05.at.10.27.01.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-03-05.at.10.22.38.PM.mov