Skip to content

fix(react-native): log soft exception for missing viewState #84303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 5 commits into from
Mar 12, 2026
Merged

fix(react-native): log soft exception for missing viewState #84303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1b3c092
fix(react-native): log soft exception for missing viewState
rohit9625 Mar 5, 2026
252029b
refactor: add details for react-native patch
rohit9625 Mar 6, 2026
390bb84
fix: update the patch file extension in the reference
rohit9625 Mar 6, 2026
08c275d
refactor: add reference to upstream issues in details.md for added patch
rohit9625 Mar 8, 2026
f9f2ff4
Merge branch 'main' into fix/log-soft-exception
rohit9625 Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions patches/react-native/details.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,3 +217,10 @@
- Upstream PR/issue: This should ideally be the default behavior upstream, but no PR has been filed yet.
- E/App issue: [#83000](https://github.com/Expensify/App/issues/83000)
- PR introducing patch: [#83256](https://github.com/Expensify/App/pull/83256)

### [react-native+0.81.4+029+log-soft-exception-if-viewState-not-found.patch](react-native+0.81.4+029+log-soft-exception-if-viewState-not-found.patch)

- Reason: This patch prevents app crashes by soft-logging the exception when JS try to send events to native views even if they are removed from view hierarchy. The approach follows existing patterns in the same file where similar events are already handled this way and is based on suggestions from other developers in upstream discussions.
- Upstream PR/issue: [#49077](https://github.com/facebook/react-native/issues/49077) [#7493](https://github.com/software-mansion/react-native-reanimated/issues/7493)
- E/App issue: [#82611](https://github.com/Expensify/App/issues/82611)
- PR introducing patch: [#84303](https://github.com/Expensify/App/pull/84303)
20 changes: 20 additions & 0 deletions patches/react-native/react-native+0.81.4+029+log-soft-exception-if-viewState-not-found.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
diff --git a/node_modules/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java b/node_modules/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java
index cdcd812..03e09d4 100644
--- a/node_modules/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java
+++ b/node_modules/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java
@@ -685,7 +685,14 @@ public class SurfaceMountingManager {
return;
}

- ViewState viewState = getViewState(reactTag);
+ ViewState viewState = getNullableViewState(reactTag);
+ if (viewState == null) {
+ ReactSoftExceptionLogger.logSoftException(
+ ReactSoftExceptionLogger.Categories.SURFACE_MOUNTING_MANAGER_MISSING_VIEWSTATE,
+ new ReactNoCrashSoftException(
+ "Unable to find viewState for tag: " + reactTag + " for updateProps"));
+ return;
+ }
viewState.mCurrentProps = new ReactStylesDiffMap(props);
View view = viewState.mView;

Loading