Skip to content

[No QA] [HOLD] [No QA] Create UK-and-EU-Expensify-Card.md‎#84319

Merged
stephanieelliott merged 10 commits intomainfrom
joekaufmanexpensify-patch-8
Mar 6, 2026
Merged

[No QA] [HOLD] [No QA] Create UK-and-EU-Expensify-Card.md‎#84319
stephanieelliott merged 10 commits intomainfrom
joekaufmanexpensify-patch-8

Conversation

@joekaufmanexpensify
Copy link
Contributor

@joekaufmanexpensify joekaufmanexpensify commented Mar 5, 2026

Explanation of Change

New version of #73266 per this.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/503962

QA Steps

N/A

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
      • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videosundefined

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f8830078d7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@joekaufmanexpensify
Copy link
Contributor Author

@MelvinBot could you investigate why the tests above are failing and how i can resolve it?

@MelvinBot
Copy link
Contributor

Both the build and verify failures have the same root cause: the filename contains a hidden Unicode character.

The file added in this PR is named:

UK-and-EU-Expensify-Card.md‎

There is an invisible U+200E (LEFT-TO-RIGHT MARK) character appended after .md. You can see it in the raw diff output as \342\200\216.

Why this breaks the build:

The createDocsRoutes.ts script (line 117-119) scans each hub directory and checks fileOrFolder.endsWith('.md') to determine if an entry is an article file. Because the filename actually ends in .md + U+200E (not .md), this check returns false. The script then falls through to line 131, where it treats the entry as a subdirectory and calls fs.readdirSync() on it — which fails with ENOTDIR because it's a file, not a directory.

Fix:

Rename the file to remove the hidden Unicode character. You can do this from your local checkout:

cd docs/articles/new-expensify/expensify-card/
# Show the hidden character
ls | cat -A | grep UK
# Rename to clean filename
mv $'UK-and-EU-Expensify-Card.md\xe2\x80\x8e' UK-and-EU-Expensify-Card.md

Or delete the file on GitHub and re-create it with a clean filename (being careful not to copy-paste the old name). This invisible character was likely introduced when the file was created through the GitHub web editor with text copied from another source.

@github-actions github-actions bot changed the title [HOLD] [No QA] Create UK-and-EU-Expensify-Card.md‎ [No QA] [HOLD] [No QA] Create UK-and-EU-Expensify-Card.md‎ Mar 5, 2026
@OSBotify
Copy link
Contributor

OSBotify commented Mar 5, 2026

A preview of your ExpensifyHelp changes have been deployed to https://67e68b19.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott
Copy link
Contributor

@MelvinBot why didn't helpdot-inline-reviewer run on this PR?

@MelvinBot
Copy link
Contributor

The helpdot inline reviewer is the "Run Claude Code (docs)" step in the claude-review.yml workflow. It did run on this PR (run 22734065190), but the docs review step was skipped.

The reason is the same hidden Unicode character issue noted above. The workflow uses a path filter to decide whether to run the docs review:

docs:
  - 'docs/**/*.md'
  - 'docs/**/*.csv'

The glob pattern docs/**/*.md expects filenames ending in .md, but the file in this PR actually ends in .md + U+200E (an invisible LEFT-TO-RIGHT MARK character). Since the filename doesn't match the *.md glob, the path filter returns false for docs, and the step is skipped.

Once the filename is fixed (by removing the hidden Unicode character as described in the earlier comment), the path filter will match correctly and the helpdot reviewer will run.

@stephanieelliott
Copy link
Contributor

@joekaufmanexpensify requested some changes here for formatting and terminology standardization, etc. Just out of curiosity, did you use the SDO for this? If yes wonder if you are accessing an old version or something, a lot of the normal rules weren't applied.

If you ever need to reference the rules, you can find them here:

Some context on my changes:

  • We should use the same terminology when referring to the feature throughout the article - that's what drives AZ retrieval precision. I used the Expensify Card in the UK and EU but feel free to use whatever you want. We should just avoid special characters in it if poss
  • All the headings should be task-based (How do I, Where can I, Who can...etc), all H2, no H3 allowed (H3 semantically separates the content from the "parent" H2 heading). I changed the ### Step X headings to task-based, feel free to change the language in them if they are off

@joekaufmanexpensify
Copy link
Contributor Author

Aligning

joekaufmanexpensify and others added 8 commits March 6, 2026 17:12
Co-authored-by: Stephanie Elliott <31225194+stephanieelliott@users.noreply.github.com>
…-Card.md

Co-authored-by: Stephanie Elliott <31225194+stephanieelliott@users.noreply.github.com>
…-Card.md

Co-authored-by: Stephanie Elliott <31225194+stephanieelliott@users.noreply.github.com>
…-Card.md

Co-authored-by: Stephanie Elliott <31225194+stephanieelliott@users.noreply.github.com>
…-Card.md

Co-authored-by: Stephanie Elliott <31225194+stephanieelliott@users.noreply.github.com>
…-Card.md

Co-authored-by: Stephanie Elliott <31225194+stephanieelliott@users.noreply.github.com>
@stephanieelliott stephanieelliott merged commit 66eea35 into main Mar 6, 2026
13 checks passed
@stephanieelliott stephanieelliott deleted the joekaufmanexpensify-patch-8 branch March 6, 2026 22:50
@melvin-bot
Copy link

melvin-bot bot commented Mar 6, 2026

@stephanieelliott looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify
Copy link
Contributor

OSBotify commented Mar 9, 2026

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.34-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.34-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants