[No QA] [HOLD] [No QA] Create UK-and-EU-Expensify-Card.md#84319
[No QA] [HOLD] [No QA] Create UK-and-EU-Expensify-Card.md#84319stephanieelliott merged 10 commits intomainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f8830078d7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@MelvinBot could you investigate why the tests above are failing and how i can resolve it? |
|
Both the The file added in this PR is named: There is an invisible U+200E (LEFT-TO-RIGHT MARK) character appended after Why this breaks the build: The Fix: Rename the file to remove the hidden Unicode character. You can do this from your local checkout: cd docs/articles/new-expensify/expensify-card/
# Show the hidden character
ls | cat -A | grep UK
# Rename to clean filename
mv $'UK-and-EU-Expensify-Card.md\xe2\x80\x8e' UK-and-EU-Expensify-Card.mdOr delete the file on GitHub and re-create it with a clean filename (being careful not to copy-paste the old name). This invisible character was likely introduced when the file was created through the GitHub web editor with text copied from another source. |
|
A preview of your ExpensifyHelp changes have been deployed to https://67e68b19.helpdot.pages.dev ⚡️ Updated articles: |
|
@MelvinBot why didn't helpdot-inline-reviewer run on this PR? |
|
The helpdot inline reviewer is the "Run Claude Code (docs)" step in the The reason is the same hidden Unicode character issue noted above. The workflow uses a path filter to decide whether to run the docs review: docs:
- 'docs/**/*.md'
- 'docs/**/*.csv'The glob pattern Once the filename is fixed (by removing the hidden Unicode character as described in the earlier comment), the path filter will match correctly and the helpdot reviewer will run. |
docs/articles/new-expensify/expensify-card/UK-and-EU-Expensify-Card.md
Outdated
Show resolved
Hide resolved
docs/articles/new-expensify/expensify-card/UK-and-EU-Expensify-Card.md
Outdated
Show resolved
Hide resolved
docs/articles/new-expensify/expensify-card/UK-and-EU-Expensify-Card.md
Outdated
Show resolved
Hide resolved
docs/articles/new-expensify/expensify-card/UK-and-EU-Expensify-Card.md
Outdated
Show resolved
Hide resolved
docs/articles/new-expensify/expensify-card/UK-and-EU-Expensify-Card.md
Outdated
Show resolved
Hide resolved
docs/articles/new-expensify/expensify-card/UK-and-EU-Expensify-Card.md
Outdated
Show resolved
Hide resolved
docs/articles/new-expensify/expensify-card/UK-and-EU-Expensify-Card.md
Outdated
Show resolved
Hide resolved
docs/articles/new-expensify/expensify-card/UK-and-EU-Expensify-Card.md
Outdated
Show resolved
Hide resolved
docs/articles/new-expensify/expensify-card/UK-and-EU-Expensify-Card.md
Outdated
Show resolved
Hide resolved
|
@joekaufmanexpensify requested some changes here for formatting and terminology standardization, etc. Just out of curiosity, did you use the SDO for this? If yes wonder if you are accessing an old version or something, a lot of the normal rules weren't applied. If you ever need to reference the rules, you can find them here: Some context on my changes:
|
Co-authored-by: Stephanie Elliott <31225194+stephanieelliott@users.noreply.github.com>
…-Card.md Co-authored-by: Stephanie Elliott <31225194+stephanieelliott@users.noreply.github.com>
…-Card.md Co-authored-by: Stephanie Elliott <31225194+stephanieelliott@users.noreply.github.com>
…-Card.md Co-authored-by: Stephanie Elliott <31225194+stephanieelliott@users.noreply.github.com>
…-Card.md Co-authored-by: Stephanie Elliott <31225194+stephanieelliott@users.noreply.github.com>
…-Card.md Co-authored-by: Stephanie Elliott <31225194+stephanieelliott@users.noreply.github.com>
|
@stephanieelliott looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.34-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.34-2 🚀
|
Explanation of Change
New version of #73266 per this.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/503962
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videosundefined