Fix export todo visibility mismatch between Home and Reports pages by mountiny · Pull Request #84333 · Expensify/App

mountiny · 2026-03-05T23:07:00Z

Explanation of Change

Follow-up to #81705. The Home page "For you" section used `isPreferredExporter()` (which checks connection-specific exporter fields like `policy.connections..config.export.exporter`) to filter export todos, while the Reports page sidebar uses `policy.exporter` (top-level policy field). When these diverge, the Home page shows "Export N reports" but the Reports sidebar has no Export option.

The Reports sidebar (`policy.exporter`) is the source of truth. This PR changes `todos.ts` to use `policy.exporter` instead of `isPreferredExporter()`, aligning the Home page with the Reports sidebar.

Fixed Issues

$ #81228

Tests

Have a workspace with an accounting integration connected (auto-sync off) and some approved/closed expense reports
Set User A as the preferred exporter in the integration export settings AND as `policy.exporter`
Verify User A sees "Export X reports" in the Home page "For you" section AND the "Export" option in the Reports To-do sidebar
Set User B as the connection-level exporter but NOT as `policy.exporter`
Verify User B does NOT see the Export todo on the Home page (matching the Reports sidebar behavior)

Verify that no errors appear in the JS console

Offline tests

Verify the Home page For You section and Reports sidebar To-do section render consistently when offline

QA Steps

Log in as a user who is `policy.exporter` on a workspace with an accounting integration
Navigate to the Home page - verify "Export N reports" appears in "For you"
Navigate to the Reports page - verify "Export" appears in the To-do sidebar
Both should be consistent (either both show Export or neither does)

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

github-actions · 2026-03-06T00:09:53Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

JmillsExpensify · 2026-03-06T08:11:24Z

That fixed it for me!

Use policy.exporter (same as Reports sidebar) instead of isPreferredExporter() (connection-level exporters) in todos.ts, ensuring the Home page For You section matches the Reports sidebar. Made-with: Cursor

mountiny · 2026-03-06T19:30:07Z

@ZhenjaHorbach can you review please?

melvin-bot · 2026-03-06T19:30:35Z

@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2026-03-06T19:31:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

2026-03-02.15.15.38.mov

ZhenjaHorbach · 2026-03-06T19:55:50Z

LGTM!

melvin-bot · 2026-03-06T19:56:38Z

@deetergp Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

joekaufmanexpensify

Good for product

github-actions · 2026-03-06T21:58:30Z

🚧 @deetergp has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-06T22:02:56Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84333.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-6cae3e5-1ad3cfa-7e78678723f01754ea69113cef81b090a01a0713/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-6cae3e5-1ad3cfa-b12475eb658c6e90cfcbe22bd23e962b091d3887/index.html

Web 🕸️
https://84333.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-06T22:04:15Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-03-06T23:03:38Z

🚀 Deployed to staging by https://github.com/deetergp in version: 9.3.33-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

OSBotify · 2026-03-09T20:38:53Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.33-5 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot bot assigned mountiny Mar 5, 2026

mountiny force-pushed the fix-export-todo-visibility-mismatch branch from 6520830 to 19135f9 Compare March 5, 2026 23:40

This comment has been minimized.

Sign in to view

Fix export todo visibility mismatch between Home and Reports pages

7593e0f

Use policy.exporter (same as Reports sidebar) instead of isPreferredExporter() (connection-level exporters) in todos.ts, ensuring the Home page For You section matches the Reports sidebar. Made-with: Cursor

mountiny force-pushed the fix-export-todo-visibility-mismatch branch from 19135f9 to 7593e0f Compare March 6, 2026 10:28

adamgrzybowski approved these changes Mar 6, 2026

View reviewed changes

mountiny requested a review from ZhenjaHorbach March 6, 2026 19:29

mountiny marked this pull request as ready for review March 6, 2026 19:29

mountiny requested review from a team as code owners March 6, 2026 19:29

melvin-bot bot requested review from joekaufmanexpensify and removed request for a team March 6, 2026 19:30

melvin-bot bot requested review from MonilBhavsar and removed request for a team March 6, 2026 19:30

ZhenjaHorbach approved these changes Mar 6, 2026

View reviewed changes

melvin-bot bot requested a review from deetergp March 6, 2026 19:56

joekaufmanexpensify approved these changes Mar 6, 2026

View reviewed changes

deetergp approved these changes Mar 6, 2026

View reviewed changes

deetergp merged commit 6cae3e5 into main Mar 6, 2026
36 of 37 checks passed

deetergp deleted the fix-export-todo-visibility-mismatch branch March 6, 2026 21:56

OSBotify mentioned this pull request Mar 6, 2026

Deploy Checklist: New Expensify 2026-03-06 #84466

Closed

52 tasks

Conversation

mountiny commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Mar 6, 2026

Uh oh!

This comment has been minimized.

JmillsExpensify commented Mar 6, 2026

Uh oh!

mountiny commented Mar 6, 2026

Uh oh!

melvin-bot bot commented Mar 6, 2026

Uh oh!

ZhenjaHorbach commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Mar 6, 2026

Uh oh!

melvin-bot bot commented Mar 6, 2026

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 6, 2026

Uh oh!

github-actions bot commented Mar 6, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

OSBotify commented Mar 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

mountiny commented Mar 5, 2026 •

edited

Loading

ZhenjaHorbach commented Mar 6, 2026 •

edited

Loading