fix: save button loading infinitely when save cropped receipt by eh2077 · Pull Request #84418 · Expensify/App

eh2077 · 2026-03-06T16:03:26Z

Explanation of Change

Fixed Issues

$ #83709
PROPOSAL: #83709 (comment)

Tests

Same as QA section

Verify that no errors appear in the JS console

Offline tests

Same as QA section

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Open staging.new.expensify.com
Go to workspace chat.
Click + > Create expense > Scan.
Upload a photo.
On confirm page, click on the receipt.
Click Crop.
Crop it to the smallest and tap Save.
Repeat Step 6 to 7 a few times.
Verify that save button works normally.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-03-06.at.11.53.51.PM.mov

Android: mWeb Chrome

Screen.Recording.2026-03-06.at.11.51.02.PM.mov

iOS: Native

Screen.Recording.2026-03-06.at.11.48.59.PM.mov

iOS: mWeb Safari

Screen.Recording.2026-03-06.at.11.50.10.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2026-03-06.at.11.45.17.PM.mov

melvin-bot · 2026-03-06T16:03:33Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-03-06T16:08:17Z

src/pages/media/AttachmentModalScreen/routes/TransactionReceiptModalContent.tsx

    const saveCrop = useCallback(() => {
-        if (!transaction?.transactionID || !sourceUri || !isImage || !cropRect) {
+        if (!transaction?.transactionID || !sourceUri || !isImage || !cropRect || cropRect.width < 1 || cropRect.height < 1) {
+            setIsCropping(false);


❌ CONSISTENCY-3 (docs)

The two lines setIsCropping(false); setCropRect(null); duplicate the logic already encapsulated in exitCropMode (defined at line 321). The .then() success path (lines 382-384) also contains the same pair of calls. Reusing exitCropMode() here would eliminate the duplication and keep the "exit crop mode" behavior defined in one place.

Suggested fix — call exitCropMode() instead of the two inline setters, and add it to the useCallback dependency array (it is stable since it has [] deps):

const saveCrop = useCallback(() => { if (!transaction?.transactionID || !sourceUri || !isImage || !cropRect || cropRect.width < 1 || cropRect.height < 1) { exitCropMode(); return; } // ... }, [transaction?.transactionID, isDraftTransaction, sourceUri, isImage, cropRect, receiptFilename, policyCategories, transaction?.receipt?.type, policy, exitCropMode]);

The same refactor could also apply to the .then() success path (lines 382-384) where setIsCropping(false); setCropRect(null); appears again alongside setIsCropSaving(false);.

Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.

Yep. This makes sense. Let's reuse our existing logic instead 👍

@MelvinBot Can you help fix this?

Fixed! Replaced the duplicated setIsCropping(false); setCropRect(null); calls with exitCropMode() in both the early-return guard (line 332) and the .then() success path (line 384). Also added exitCropMode to the useCallback dependency array.

codecov · 2026-03-06T16:37:07Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...alScreen/routes/TransactionReceiptModalContent.tsx	`0.00% <0.00%> (ø)`
... and 137 files with indirect coverage changes

joekaufmanexpensify

Makes sense

hungvu193 · 2026-03-07T16:31:35Z

src/pages/media/AttachmentModalScreen/routes/TransactionReceiptModalContent.tsx

    const saveCrop = useCallback(() => {
-        if (!transaction?.transactionID || !sourceUri || !isImage || !cropRect) {
+        if (!transaction?.transactionID || !sourceUri || !isImage || !cropRect || cropRect.width < 1 || cropRect.height < 1) {
+            setIsCropping(false);


Yep. This makes sense. Let's reuse our existing logic instead 👍

… calls Co-authored-by: Eric Han <eh2077@users.noreply.github.com>

hungvu193 · 2026-03-09T02:43:06Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android.mov

Android: mWeb Chrome

mChromne.mov

iOS: HybridApp

ios.mov

iOS: mWeb Safari

safari.mov

MacOS: Chrome / Safari

Chrome.mov

github-actions · 2026-03-09T03:51:17Z

🚧 @srikarparsi has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-09T03:56:56Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84418.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-e32727c-b9c28a3-f428a5a5f59aa0b49417b7702ab39c96b74d84a2/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-e32727c-b9c28a3-67220dc8344e7f05c980a728e55ae0b6eb41bb0d/index.html

Web 🕸️
https://84418.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-09T04:00:19Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-03-09T21:27:55Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.3.34-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-10T18:50:01Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.34-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: save button loading infinitely when save cropped receipt

629a8e4

eh2077 requested review from a team as code owners March 6, 2026 16:03

melvin-bot bot assigned eh2077 Mar 6, 2026

melvin-bot bot requested a review from hungvu193 March 6, 2026 16:03

melvin-bot bot requested review from joekaufmanexpensify and removed request for a team March 6, 2026 16:03

github-actions bot reviewed Mar 6, 2026

View reviewed changes

joekaufmanexpensify previously approved these changes Mar 6, 2026

View reviewed changes

hungvu193 suggested changes Mar 7, 2026

View reviewed changes

Reuse exitCropMode() instead of duplicating setIsCropping/setCropRect…

3553b3c

… calls Co-authored-by: Eric Han <eh2077@users.noreply.github.com>

MelvinBot dismissed joekaufmanexpensify’s stale review via 3553b3c March 9, 2026 02:17

hungvu193 approved these changes Mar 9, 2026

View reviewed changes

melvin-bot bot requested a review from srikarparsi March 9, 2026 02:43

srikarparsi approved these changes Mar 9, 2026

View reviewed changes

srikarparsi merged commit e32727c into Expensify:main Mar 9, 2026
30 of 32 checks passed

OSBotify mentioned this pull request Mar 9, 2026

Deploy Checklist: New Expensify 2026-03-09 #84634

Closed

75 tasks

melvin-bot bot mentioned this pull request Mar 10, 2026

[Due for payment 2026-03-17] [$250] Scan - Save button loads infinitely when photo is cropped to the smallest size #83709

Closed

7 tasks

Conversation

eh2077 commented Mar 6, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 6, 2026

Uh oh!

github-actions bot Mar 6, 2026

Choose a reason for hiding this comment

❌ CONSISTENCY-3 (docs)

Uh oh!

hungvu193 Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

eh2077 Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

MelvinBot Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Mar 6, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

hungvu193 Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

hungvu193 commented Mar 9, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

github-actions bot commented Mar 9, 2026

Uh oh!

github-actions bot commented Mar 9, 2026

Uh oh!

OSBotify commented Mar 9, 2026

Uh oh!

OSBotify commented Mar 9, 2026

Uh oh!

OSBotify commented Mar 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Mar 6, 2026 •

edited by github-actions bot

Loading