Conversation
|
|
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
src/pages/inbox/report/ReportActionCompose/ReportActionCompose.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eb4eba1573
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
patches/react-native/react-native+0.81.4+011+Add-onPaste-to-TextInput.patch
Outdated
Show resolved
Hide resolved
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
Kicked off a build and this action too https://github.com/Expensify/App/actions/runs/22778476616 |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Good for product
…necessary patch changes
|
On Android, when I select multiple attachments, the app only show preview for 2. 07.03.2026_18.53.07_REC.mp4 |
@parasharrajat we'll need to merge the other way around. Some of the issues you reported in this PR are reproducible on |
|
OK, I will get on other PR then. You tagged the same PR for hold status. |
perfect thanks!
Ahh thank you |
|
@parasharrajat #84423 has been merged so this is unblocked now! |
|
@chrispader Did we revert the previous PR? There was a slack discussion about it. |
@parasharrajat yes we did, because the patch caused the Android build workflow to fail. This is fixed now. I'll resolve the conflicts with the patch in a bit |
|
I mean, #70740 this PR. Is this reverted? |
No, it was not reverted |
0808085 to
fcee01e
Compare
|
Got conflicts here. |
Screenshots🔲 iOS / native02.03.2026_21.44.29_REC.mp4🔲 iOS / Safari02.03.2026_23.00.27_REC.mp4🔲 MacOS / Chrome01.03.2026_13.56.06_REC.mp423.03.2026_08.25.40_REC.mp4🔲 Android / Chrome🔲 Android / native03.03.2026_00.17.29_REC.mp4 |
|
@chrispader Please resolve conflicts. |
|
@parasharrajat conflicts resolved and verified patches still work! |
|
@parasharrajat btw this PR now allows to paste multiple files into the composer by clicking the input and selecting "Paste". Please verify whether this works for you, since i did not see it in your screen recordings |
|
WEB: Copy pasting multiple attachment does not show attachment carousel for all attachments. While this works in drag and drop. Attachments. sample.pdf Steps:
|
@parasharrajat i cannot reproduce this. Screen.Recording.2026-03-24.at.12.20.59.mov |
|
@parasharrajat aside from the above issue, everything should be ready! |
|
Let me retest. |
@parasharrajat @mountiny
Explanation of Change
This PR is a follow-up after #68551 has been reverted in #83956
Updates the native
react-nativepatch which impementsonPastecallback onTextInput, to allow pasting multiple files into the input.Updates the composer implementation to handle multiple files that were drag'n'dropped. This allows the user to drop multiple files into the composer at once, which will then be displayed in an attachment gallery preview.
Even though there is a limitation on iOS where multiple files in the clipboard are not passed to the input
onPasteFilecallback, i still adapted the implementation to allow for potentially more clipboard items.react-native-live-markdownPR: Expensify/react-native-live-markdown#753react-native-live-markdownversion bump PR: #83041Fixed Issues
$ #53493
$ #59443
PROPOSAL:
Tests
Drag'n'Drop
Paste from clipboard
Offline tests
None needed.
QA Steps
Same as in Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
XRecorder_20260218_02.mp4
iOS: Native
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-02-18.at.20.27.14.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-02-18.at.13.26.19.mov
Screen.Recording.2026-02-18.at.13.25.47.mov
MacOS: Desktop