[No QA] Update and rename Create-expense-tags.md to Create-and-manage-expense-tags.md#84478
[No QA] Update and rename Create-expense-tags.md to Create-and-manage-expense-tags.md#84478bfitzexpensify merged 2 commits intomainfrom
Conversation
update redirects file
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@Valforte @bfitzexpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] NOTE: It looks like |
|
|
||
| ## How to create a tag manually | ||
|
|
||
| 1. In the navigation tabs (on the left on web, and at the bottom on mobile), select **Workspaces** > **[workspace name]** |
There was a problem hiding this comment.
Formatting inconsistency: "navigation tabs" is not bold here, but it is bold in other sections (lines 28, 155, 164, 172). For consistency, wrap it in bold: **navigation tabs**. Also, this step is missing a period at the end.
| 1. In the navigation tabs (on the left on web, and at the bottom on mobile), select **Workspaces** > **[workspace name]** | |
| 1. In the **navigation tabs** (on the left on web, and at the bottom on mobile), select **Workspaces** > **[workspace name]**. |
|
|
||
| 1. In the navigation tabs (on the left on web, and at the bottom on mobile), select **Workspaces** > **[workspace name]** | ||
| 2. Select **Tags**. | ||
| 3. Choose **Add tag** |
There was a problem hiding this comment.
Formatting inconsistency: This step is missing a period at the end. Also, "Choose" is used here but "Select" is used in parallel steps elsewhere in the article. Pick one verb and use it consistently throughout.
| 3. Choose **Add tag** | |
| 3. Select **Add tag**. |
| ## How to create a tag manually | ||
|
|
||
| 1. In the navigation tabs (on the left on web, and at the bottom on mobile), select **Workspaces** > **[workspace name]** | ||
| 2. Select **Tags**. |
There was a problem hiding this comment.
Formatting inconsistency: Missing period at end of step.
| 2. Select **Tags**. | |
| 2. Select **Tags**. |
|
|
||
| ## How to import single-level Tags using a spreadsheet | ||
|
|
||
| Use this option when you want one flat list of tags (for example: Marketing, Sales, IT). |
There was a problem hiding this comment.
Formatting inconsistency: "navigation tabs" is not bold here but is bold in other sections. Also missing a period at the end of this step.
| Use this option when you want one flat list of tags (for example: Marketing, Sales, IT). | |
| 1. In the **navigation tabs** (on the left on web, and at the bottom on mobile), select **Workspaces** > **[workspace name]**. |
|
|
||
| Use this option when you want one flat list of tags (for example: Marketing, Sales, IT). | ||
|
|
||
| 1. In the navigation tabs (on the left on web, and at the bottom on mobile), select **Workspaces** > **[workspace name]** |
There was a problem hiding this comment.
Formatting inconsistency: Missing period at end of step.
| 1. In the navigation tabs (on the left on web, and at the bottom on mobile), select **Workspaces** > **[workspace name]** | |
| 3. Select **More** > **Import spreadsheet**. |
| --- | ||
|
|
||
| ## How to import multi-level Tags using a spreadsheet | ||
|
|
There was a problem hiding this comment.
Formatting inconsistency: "navigation tabs" is not bold here but is bold in other sections (e.g., lines 28, 155, 164). For consistency, use **navigation tabs**.
| 1. In the **navigation tabs** (on the left on web, and at the bottom on mobile), select **Workspaces** > **[workspace name]**. |
|
|
||
| --- | ||
|
|
||
| ## How to create a tag manually |
There was a problem hiding this comment.
Heading capitalization inconsistency: "tag" is lowercase here, but other headings capitalize "Tags" (e.g., "How to enable Tags on a workspace", "How to import single-level Tags"). Choose one convention and apply it to all headings throughout the article.
| ## How to create a tag manually | |
| ## How to create a Tag manually |
| 3. Select one or more tags. | ||
| 4. Choose **Selected** in the top right. | ||
| 5. Select **Delete tag**. | ||
|
|
There was a problem hiding this comment.
Heading capitalization inconsistency: "tags" is lowercase here, but other section headings capitalize "Tags" (e.g., "How to enable Tags on a workspace", "How to import single-level Tags"). For consistency:
| ## How to delete expense Tags |
| Workspaces on the Control plan can assign a GL code to each tag for exporting purposes. Tag GL codes are not visible to members. | ||
|
|
||
| 1. In the **navigation tabs** (on the left on web, and at the bottom on mobile), select **Workspaces** > **[workspace name]**. | ||
| 2. Select **Tags**. |
There was a problem hiding this comment.
Heading capitalization inconsistency: "tag" is lowercase here but capitalized ("Tags") in most other headings. For consistency:
| 2. Select **Tags**. | |
| ## How to add or edit a Tag GL code |
| - [Dependent tags with GL codes](https://help.expensify.com/assets/Files/Dependent+with+GL+codes+format.csv) | ||
| - [Dependent tags without GL codes](https://help.expensify.com/assets/Files/Dependent+without+GL+codes+format.csv) | ||
| - [Independent tags with GL codes](https://help.expensify.com/assets/Files/Independent+with+GL+codes+format.csv) | ||
| - [Independent tags without GL codes](https://help.expensify.com/assets/Files/Independent+without+GL+codes+format.csv) |
There was a problem hiding this comment.
Formatting inconsistency: "Notes:" (plural) is used here but only one bullet point follows. The rest of the article uses "Note:" (singular) for single-item notes. Use the singular form for consistency.
| - [Independent tags without GL codes](https://help.expensify.com/assets/Files/Independent+without+GL+codes+format.csv) | |
| **Note:** |
|
|
||
| 1. In the navigation tabs (on the left on web, and at the bottom on mobile), select **Workspaces** > **[workspace name]** | ||
| 2. Select **Tags**. | ||
| 3. Select **More** > **Import spreadsheet** |
There was a problem hiding this comment.
Verb inconsistency: "Choose" is used here, but most other steps in the article use "Select". For consistency, use "Select" throughout.
| 3. Select **More** > **Import spreadsheet** | |
| 4. Select **Single level of tags**. |
|
|
||
| 1. In the navigation tabs (on the left on web, and at the bottom on mobile), select **Workspaces** > **[workspace name]**. | ||
| 2. Select **Tags**. | ||
| 3. Select **More** > **Import spreadsheet**. |
There was a problem hiding this comment.
Verb inconsistency: "Choose" is used here, but most other steps in the article use "Select". For consistency, use "Select" throughout.
| 3. Select **More** > **Import spreadsheet**. | |
| 4. Select **Multi-level tags**. |
|
|
||
| --- | ||
|
|
||
| ## How to add or edit a tag GL code |
There was a problem hiding this comment.
Verb inconsistency: "Choose" is used here, but most other steps in the article use "Select". For consistency, use "Select" throughout.
| ## How to add or edit a tag GL code | |
| 4. Select **Selected** in the top right. |
|
|
||
| **Notes:** | ||
| - Only CSV and TSV files are supported for multi-level tag imports. A single file can include up to 50,000 tags. | ||
|
|
There was a problem hiding this comment.
Readability / AI Readiness: This heading is long and hard to scan. Consider shortening it while keeping the full feature name. For example:
| ## How single-level and multi-level Tags affect expenses |
| 1. In the navigation tabs (on the left on web, and at the bottom on mobile), select **Workspaces** > **[workspace name]** | ||
| 2. Select **Tags**. | ||
| 3. Choose **Add tag** | ||
| 4. Enter a tag name and select **Save**. |
There was a problem hiding this comment.
Style compliance: Per Expensify HelpDot standards, end-of-flow confirmation buttons should use "Confirm" rather than "Save." If the UI button literally reads "Save," please disregard this comment -- but if the button text is actually "Confirm," this should be updated.
Same concern applies to line 175.
| - Only CSV and TSV files are supported for multi-level tag imports. A single file can include up to 50,000 tags. | ||
|
|
||
| --- | ||
|
|
There was a problem hiding this comment.
Readability: The phrase "how many 'layers' of coding members must complete" is awkward and could be misread (it is unclear whether "coding members" is a noun phrase or "coding" modifies "layers"). Consider rephrasing for clarity:
| Single-level Tags and multi-level Tags determine how many tag fields appear on each expense. This controls how many layers of coding a member must complete when submitting expenses. |
HelpDot Documentation ReviewOverall AssessmentThis PR renames and rewrites the expense tags documentation from Scores Summary
Key FindingsPositive aspects:
Issues to address:
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
|
||
| ## What happens if a tag is disabled in my accounting system? | ||
|
|
||
| It will be removed from the workspace’s tag list. However, it will still appear on expenses or reports where it was previously applied. |
There was a problem hiding this comment.
AI Readiness: "It" at the start of this answer is a vague reference. For better clarity and AI retrieval, restate the subject.
| It will be removed from the workspace’s tag list. However, it will still appear on expenses or reports where it was previously applied. | |
| The disabled tag will be removed from the workspace's tag list. However, it will still appear on expenses or reports where it was previously applied. |
|
A preview of your ExpensifyHelp changes have been deployed to https://73ce6947.helpdot.pages.dev ⚡️ Updated articles: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d71287b255
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -0,0 +1,198 @@ | |||
| --- | |||
There was a problem hiding this comment.
Add redirect for renamed tags article URL
Renaming this markdown file changes the published article path because our docs route generator derives href directly from the filename (.github/scripts/createDocsRoutes.ts), but this commit does not add a redirect from .../Create-expense-tags to the new slug. We still have multiple links pointing at the old URL (for example in src/CONST/index.ts and src/components/SidePanel/HelpContent/helpContentMap.tsx), so those links will start returning 404 after this deploy unless docs/redirects.csv is updated.
Useful? React with 👍 / 👎.
|
🚀 Deployed to staging by https://github.com/bfitzexpensify in version: 9.3.34-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.34-2 🚀
|
Resource update request: https://github.com/Expensify/Expensify/issues/606928