[Personal Karma] Add NewDot toggle flow under Save The World by fedirjh · Pull Request #84504 · Expensify/App

fedirjh · 2026-03-08T03:32:46Z

Explanation of Change

This PR adds Personal Karma support to NewDot under /settings/teachersunite.

Adds a Personal Karma toggle card in Save The World settings.
Connects the toggle to the new UpdatePersonalKarma API action.
Shows a confirmation modal when disabling donations.
Prompts for adding a payment card when enabling without a billing card, and reverts toggle state if the modal is dismissed.
Shows the billing card details when Personal Karma is enabled.
Moves Personal Karma text to translations and adds localized strings across all app languages.
Adds reusable subtitle-with-link rendering (SectionSubtitleHTML) and reusable billing card rendering (BillingCardDetails) used by related settings sections.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/601130
PROPOSAL:

Tests

Open /settings/teachersunite.
Verify the Personal Karma card is shown with the Personal Karma title and description text:
Donate $1 to Expensify.org for every $500 you spend each month Learn more.
Toggle Personal Karma on with a payment card present.
Verify the toggle is enabled and the billing card details are shown.
Toggle Personal Karma off.
Verify the stop-donations confirmation modal appears.
Tap cancel and verify Personal Karma stays enabled.
Toggle off again and confirm disable.
Verify Personal Karma is disabled.
Enable again on an account without a billing card.
Verify add-payment-card modal appears.
Dismiss the modal without adding a card and verify the toggle reverts to disabled.

Verify that no errors appear in the JS console

Offline tests

Go offline and open /settings/teachersunite.
Toggle Personal Karma on and off.
Verify there is no crash and the UI remains stable.
Reconnect and verify the latest state is synchronized.

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

CleanShot.2026-03-12.at.00.36.48.mp4

CleanShot.2026-03-12.at.01.35.39.mp4

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

- Introduced ONYXKEYS for managing Personal Karma donation states. - Added new API command and parameters for updating Personal Karma. - Updated Subscription actions to include a function for updating Personal Karma. - Added a help URL for Personal and Corporate Karma in the constants.

- Created a new BillingCardDetails component to encapsulate billing card information display. - Replaced inline billing card rendering in CardSection with the new BillingCardDetails component for improved code organization and readability. - Removed unused imports and optimized existing code in CardSection.

- Added new translations for the Personal Karma feature in German, English, Spanish, French, Italian, Japanese, Dutch, Polish, Brazilian Portuguese, and Simplified Chinese. - Each translation includes title, description, prompts for adding a payment card, stopping donations, and the title for the donation card.

- Introduced a new SectionSubtitleHTML component to handle HTML subtitles with optional muted styling and link press handling. - Replaced instances of RenderHTML in various pages (DomainSamlPage, SecuritySettingsPage, TroubleshootPage, WorkspaceReportsPage, IndividualExpenseRulesSection) with SectionSubtitleHTML for improved consistency and maintainability. - Updated related styles and props to accommodate the new component.

- Integrated Personal Karma toggle functionality with modals for adding payment cards and disabling donations. - Added new state management for displaying billing card details and handling user interactions. - Updated UI components to include SectionSubtitleHTML for improved subtitle rendering. - Enhanced user experience with confirmation modals for payment card actions and personal karma updates.

melvin-bot · 2026-03-08T03:32:51Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

codecov · 2026-03-08T03:49:43Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`93.65% <ø> (ø)`
src/ONYXKEYS.ts	`100.00% <ø> (ø)`
src/ROUTES.ts	`15.90% <ø> (ø)`
src/SCREENS.ts	`100.00% <ø> (ø)`
src/libs/API/types.ts	`100.00% <ø> (ø)`
...igation/linkingConfig/RELATIONS/SETTINGS_TO_RHP.ts	`100.00% <ø> (ø)`
src/libs/Navigation/linkingConfig/config.ts	`76.92% <ø> (ø)`
...c/pages/workspace/reports/WorkspaceReportsPage.tsx	`0.00% <ø> (ø)`
...gation/AppNavigator/ModalStackNavigators/index.tsx	`6.87% <0.00%> (-0.01%)`	⬇️
...c/pages/settings/Security/SecuritySettingsPage.tsx	`0.00% <0.00%> (ø)`
... and 9 more
... and 6 files with indirect coverage changes

src/components/PaymentCardDetails.tsx

src/CONST/index.ts

flodnv · 2026-03-09T15:49:00Z

@garrettmknight do you want to review the product side of this PR?

…dPage and CardSection - Introduced a new PaymentCardDetails component for displaying billing card information. - Replaced instances of BillingCardDetails with PaymentCardDetails in SaveTheWorldPage and CardSection for consistency and improved functionality.

flodnv · 2026-03-10T16:03:50Z

@fedirjh checks failed

trjExpensify

Overall, looking pretty good! Just a few things:

The toggle label supplied in the mocks from @dannymcclain read Enable Personal Karma. The video in the OP is slightly different.

The video only shows one case (you have a card already). Can you show the other case where you have to add a payment card so the evidence matches the tests to sense check?
Where did this copy change in the modal come from? Looks different to the mocks supplied in the parent issue.

Parent issue:

PR:

fedirjh · 2026-03-11T19:09:55Z

3. Where did this copy change in the modal come from?

we have this copy in OldDot. Will update it to match the OP

…ature - Introduced SETTINGS_SAVE_THE_WORLD_ADD_PAYMENT_CARD route in ROUTES.ts. - Added ADD_PAYMENT_CARD screen to SCREENS.ts. - Updated TeachersUniteNavigator to include the new ADD_PAYMENT_CARD screen. - Modified linking configuration to route to the new screen. - Adjusted SaveTheWorldPage to navigate to the new payment card screen and removed the old modal implementation.

fedirjh · 2026-03-12T00:38:24Z

@MelvinBot Fix prettier and lint errors?

Co-authored-by: Fedi Rajhi <fedirjh@users.noreply.github.com>

MelvinBot · 2026-03-12T00:41:05Z

Fixed the prettier and ESLint errors:

Prettier: Reordered imports alphabetically in PaymentCardDetails.tsx, SaveTheWorldPage.tsx, CardSection.tsx, and IndividualExpenseRulesSection.tsx
ESLint (prefer-early-return): Refactored the useEffect in SaveTheWorldPage.tsx to use an early return instead of wrapping the body in a conditional

trjExpensify · 2026-03-13T13:43:30Z

Should this be out of WIP now?

melvin-bot · 2026-04-06T14:02:41Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-04-06T14:02:46Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2026-04-06T14:04:57Z

@fedirjh
Do you need help with the review?

fedirjh · 2026-04-06T14:08:14Z

Do you need help with the review?

@ZhenjaHorbach Yes, need testing and the checklist. I think this can be tested in stating till https://github.com/Expensify/Web-Expensify/pull/51567 reaches prod.

src/components/PaymentCardDetails.tsx

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f2d2b99ba8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/pages/TeachersUnite/SaveTheWorldPage.tsx

…ize useIsFocused for effect dependencies

ZhenjaHorbach · 2026-04-06T18:55:34Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

flodnv · 2026-04-07T14:43:04Z

Thanks @ZhenjaHorbach , please let me know when this is ready

ZhenjaHorbach · 2026-04-07T14:44:13Z

Thanks @ZhenjaHorbach , please let me know when this is ready

I think I will complete the review tomorrow morning!

flodnv · 2026-04-07T15:14:33Z

Thank you!

…

On Tue, Apr 7, 2026 at 10:44 AM Yauheni Horbach ***@***.***> wrote: *ZhenjaHorbach* left a comment (Expensify/App#84504) <#84504 (comment)> Thanks @ZhenjaHorbach <https://github.com/ZhenjaHorbach> , please let me know when this is ready I think I will complete the review tomorrow morning! — Reply to this email directly, view it on GitHub <#84504 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA7Y2OPRJVEMHPRQCOJKO3L4UUH5JAVCNFSM6AAAAACWKXCKNSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DCOJZHAZTOOJUGA> . You are receiving this because your review was requested.Message ID: ***@***.***>

ZhenjaHorbach · 2026-04-08T14:46:58Z

Minor comment
But should we add a pending action for Karma toggle?

2026-04-08.16.46.06.mov

As we usually do

2026-04-08.16.46.43.mov

ZhenjaHorbach · 2026-04-08T14:48:14Z

And should we have a dynamic price depending on location?
Or we will always have 1$?

src/pages/TeachersUnite/SaveTheWorldPage.tsx

ZhenjaHorbach · 2026-04-08T15:03:57Z

Minor comment
But we can directly navigate to settings/teachersunite/add-payment-card
Even when we already have a card
I suppose it's better to show Not here page

…AddPaymentCard component

fedirjh · 2026-04-08T18:10:36Z

And should we have a dynamic price depending on location? Or we will always have 1$?

IT should match the oldDot behaviour which was 1$ regardless of the location.

fedirjh added 8 commits March 8, 2026 00:56

Remove donation card title from translations in multiple languages

30c7058

Refactor imports and enhance style

824cf87

Merge remote-tracking branch 'upstream' into personal-karma-new-dot

2da801f

melvin-bot bot assigned fedirjh Mar 8, 2026

Enhance BillingCardDetails component and update translations

60c8b69

fedirjh requested a review from flodnv March 8, 2026 04:09

flodnv reviewed Mar 9, 2026

View reviewed changes

src/components/PaymentCardDetails.tsx Show resolved Hide resolved

src/CONST/index.ts Show resolved Hide resolved

fedirjh added 2 commits March 10, 2026 01:39

Merge remote-tracking branch 'upstream' into personal-karma-new-dot

cb1acb3

trjExpensify self-requested a review March 10, 2026 16:15

trjExpensify requested changes Mar 10, 2026

View reviewed changes

fedirjh added 3 commits March 11, 2026 23:39

Update personal karma copy

e4dc325

Merge remote-tracking branch 'upstream' into personal-karma-new-dot

260ae39

fedirjh assigned MelvinBot Mar 12, 2026

Fix prettier formatting and ESLint prefer-early-return error

d61d13a

Co-authored-by: Fedi Rajhi <fedirjh@users.noreply.github.com>

fedirjh requested a review from trjExpensify March 12, 2026 00:52

melvin-bot bot requested a review from heyjennahay April 6, 2026 14:02

melvin-bot bot requested review from a team and eVoloshchak and removed request for a team April 6, 2026 14:02

melvin-bot bot removed the request for review from a team April 6, 2026 14:02

fedirjh removed the request for review from eVoloshchak April 6, 2026 14:08

ZhenjaHorbach reviewed Apr 6, 2026

View reviewed changes

src/components/PaymentCardDetails.tsx Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Apr 6, 2026

View reviewed changes

src/pages/TeachersUnite/SaveTheWorldPage.tsx Outdated Show resolved Hide resolved

chore: Remove unnecessary useMemo and update SaveTheWorldPage to util…

b30b75f

…ize useIsFocused for effect dependencies

fedirjh dismissed flodnv’s stale review via b30b75f April 6, 2026 14:47

fedirjh added 2 commits April 6, 2026 19:36

Merge branch 'Expensify:main' into personal-karma-new-dot

b4dfd83

chore: Add "PINATM" to cspell.json dictionary

82b996d

ZhenjaHorbach reviewed Apr 8, 2026

View reviewed changes

src/pages/TeachersUnite/SaveTheWorldPage.tsx Outdated Show resolved Hide resolved

fedirjh added 3 commits April 8, 2026 18:39

feat: Add optimistic UI state for personal karma updates

be8f82d

feat: Integrate FullPageNotFoundView for enhanced user experience in …

61d7ea8

…AddPaymentCard component

Merge branch 'Expensify:main' into personal-karma-new-dot

dc3adc8

fedirjh requested a review from ZhenjaHorbach April 8, 2026 18:09

Conversation

fedirjh commented Mar 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 8, 2026

Uh oh!

codecov bot commented Mar 8, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

flodnv commented Mar 9, 2026

Uh oh!

flodnv commented Mar 10, 2026

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

fedirjh commented Mar 11, 2026

Uh oh!

fedirjh commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MelvinBot commented Mar 12, 2026

Uh oh!

trjExpensify commented Mar 13, 2026

Uh oh!

melvin-bot bot commented Apr 6, 2026

Uh oh!

melvin-bot bot commented Apr 6, 2026

Uh oh!

ZhenjaHorbach commented Apr 6, 2026

Uh oh!

fedirjh commented Apr 6, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ZhenjaHorbach commented Apr 6, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

flodnv commented Apr 7, 2026

Uh oh!

ZhenjaHorbach commented Apr 7, 2026

Uh oh!

flodnv commented Apr 7, 2026 via email

Uh oh!

ZhenjaHorbach commented Apr 8, 2026

Uh oh!

ZhenjaHorbach commented Apr 8, 2026

Uh oh!

Uh oh!

ZhenjaHorbach commented Apr 8, 2026

Uh oh!

fedirjh commented Apr 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

fedirjh commented Mar 8, 2026 •

edited

Loading

codecov bot commented Mar 8, 2026 •

edited by github-actions bot

Loading

fedirjh commented Mar 12, 2026 •

edited

Loading