Refactor: make changeMoneyRequestHoldStatus pure function receive iouTransaction by linhvovan29546 · Pull Request #84507 · Expensify/App

linhvovan29546 · 2026-03-08T08:27:46Z

Explanation of Change

This PR refactors changeMoneyRequestHoldStatus in ReportUtils.ts to be a pure function by receiving the iouTransaction as an explicit parameter instead of looking it up internally from the module-level allTransactions Onyx cache. And also rename module-level variables — allTransactions → deprecatedAllTransactions and reportsTransactions → deprecatedReportsTransactions

Fixed Issues

$ #66418
PROPOSAL: N/A

Tests

Test 1:

Create a new expense.
Open the expense detail view.
Tap More > Hold.
Verify that the expense is successfully held
Tap Remove Hold.
Verify that the expense is successfully unheld (status returns to normal).

Test 2:

Create a new expense.
Right-click (or long-press) on report review.
Select Hold.
Verify that the expense is successfully held.
Tap Remove Hold.
Verify that the expense is successfully unheld.

Test 3:

Create a new expense.
Go to Reports > Reports list.
Select the expense just created.
Tap the selected items dropdown > Hold.
Verify that the expense is successfully held.
Repeat step 3 then Remove Hold.
Verify that the expense is successfully unheld.

Verify that no errors appear in the JS console

Offline tests

Same as tests above

QA Steps

Same as tests above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-03-10.at.21.09.57.mov

Android: mWeb Chrome

Screen.Recording.2026-03-10.at.21.05.02.mov

iOS: Native

Screen.Recording.2026-03-10.at.21.01.10.mov

iOS: mWeb Safari

Screen.Recording.2026-03-10.at.20.57.39.mov

MacOS: Chrome / Safari

Screen.Recording.2026-03-10.at.20.50.07.mov

…nsaction

codecov · 2026-03-08T08:34:45Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/MoneyRequestHeader.tsx	`0.00% <ø> (ø)`
...report/ContextMenu/BaseReportActionContextMenu.tsx	`83.78% <ø> (+83.78%)`	⬆️
src/libs/ReportUtils.ts	`77.14% <90.00%> (+0.72%)`	⬆️
...es/inbox/report/ContextMenu/ContextMenuActions.tsx	`41.22% <66.66%> (+15.72%)`	⬆️
src/components/MoneyReportHeader.tsx	`0.00% <0.00%> (ø)`
... and 170 files with indirect coverage changes

…uestHoldStatus-pure-function

linhvovan29546 · 2026-03-10T11:45:34Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b42db89c13

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/components/MoneyReportHeader.tsx

…ng hold status

linhvovan29546 · 2026-03-10T13:15:32Z

@codex review

chatgpt-codex-connector · 2026-03-10T13:26:33Z

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

melvin-bot · 2026-03-10T14:14:18Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/components/MoneyReportHeader.tsx

tests/unit/ReportUtilsTest.ts

tests/ui/components/BaseReportActionContextMenuTest.tsx

…lookup

trjExpensify · 2026-03-11T23:14:43Z

PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself.

DylanDylann · 2026-03-12T08:24:09Z

@MelvinBot Could you please review this PR?

DylanDylann · 2026-03-12T08:54:42Z

The rest looks fine to me

…atus-pure-function

linhvovan29546 · 2026-03-12T10:00:31Z

The test failure is not related to this PR.

linhvovan29546 · 2026-03-12T10:03:40Z

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

I've added more tests. I think that's sufficient now, they should cover the UI cases properly.

MelvinBot · 2026-03-12T10:46:13Z

The statement is partially correct but incomplete. Here's the code evidence:

What IS correct

isRemoveHoldAction at ReportPrimaryActionUtils.ts:278-301 does return false when transactionThreadReportID is falsy:

function isRemoveHoldAction(report, chatReport, reportTransactions) {
    // ...
    const transactionThreadReportID = getOneTransactionThreadReportID(report, chatReport, reportActions);
    if (!transactionThreadReportID) {
        return false;  // ← confirmed
    }
    const isHolder = reportTransactions.some((transaction) => isHoldCreator(transaction, transactionThreadReportID));
    return isHolder;
}

What the statement MISSES

isRemoveHoldAction is not the only path that returns REMOVE_HOLD. In getReportPrimaryAction, there are three paths that return REMOVE_HOLD:

Path 1 — line 471 (left side of OR): isRemoveHoldAction(...) — requires transactionThreadReportID to be truthy (single-transaction reports).

Path 2 — line 471 (right side of OR): isPayActionWithAllExpensesHeld && expensesToHold.length — does NOT require transactionThreadReportID. Fires on multi-transaction reports where all expenses are held and the report is payable.

// line 471-472
if (isRemoveHoldAction(report, chatReport, reportTransactions) || (isPayActionWithAllExpensesHeld && expensesToHold.length)) {
    return CONST.REPORT.PRIMARY_ACTIONS.REMOVE_HOLD;
}

Path 3 — line 491: expensesToHold.length (standalone fallthrough) — also does NOT require transactionThreadReportID. Fires when no higher-priority action applies but there are held expenses.

// line 491-493
if (expensesToHold.length) {
    return CONST.REPORT.PRIMARY_ACTIONS.REMOVE_HOLD;
}

Both paths 2 and 3 use getAllExpensesToHoldIfApplicable, which iterates over all report actions and does not depend on transactionThreadReportID.

Is the `parentReportAction` fallback reachable?

Looking at the REMOVE_HOLD button handler in MoneyReportHeader.tsx:1246-1268:

onPress={() => {
    const parentReportAction = getReportAction(moneyRequestReport?.parentReportID, moneyRequestReport?.parentReportActionID);
    const IOUActions = getAllExpensesToHoldIfApplicable(moneyRequestReport, reportActions, transactions, policy);

    if (IOUActions.length) {
        // Batch unhold — handles multi-transaction cases (paths 2 & 3)
        for (const action of IOUActions) {
            changeMoneyRequestHoldStatus(action, getLinkedIOUTransaction(action, transactions));
        }
        return;  // ← early return, line 1263 is NOT reached
    }

    // Fallback to single-action unhold
    const moneyRequestAction = transactionThreadReportID ? requestParentReportAction : parentReportAction;
    // ...
}}

When REMOVE_HOLD is triggered via paths 2 or 3, the IOUActions.length branch at line 1256 would typically handle it with the batch unhold and return early before reaching line 1263. So in practice, line 1263's parentReportAction fallback is unlikely to be hit — but it's not impossible if there's a state/timing difference between when getReportPrimaryAction computed REMOVE_HOLD (with non-empty expensesToHold) and when the button is pressed (where getAllExpensesToHoldIfApplicable could return empty due to state changes between renders).

Conclusion

The statement that "parentReportAction fallback is a defensive path that shouldn't be reachable in practice" is mostly accurate for path 1 (single-transaction, isRemoveHoldAction), but not fully accurate because paths 2 and 3 can show the REMOVE_HOLD button on multi-transaction reports where transactionThreadReportID is falsy. The IOUActions batch branch usually handles those cases before the fallback is reached, making the fallback rare but not provably unreachable.

DylanDylann · 2026-03-12T10:59:08Z

@MelvinBot Many thanks. You did a great job

DylanDylann · 2026-03-12T11:33:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-03-12.at.18.30.45.mov

Screen.Recording.2026-03-12.at.18.29.52.mov

DylanDylann · 2026-03-12T11:33:27Z

@linhvovan29546 We got conflict

DylanDylann

LGTM

melvin-bot · 2026-03-12T11:33:48Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #66418 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

…atus-pure-function

linhvovan29546 · 2026-03-12T11:50:13Z

The test failure is not related to this PR.

DylanDylann · 2026-03-12T14:01:51Z

cc @tgolen

tgolen · 2026-03-12T16:53:02Z

@linhvovan29546 I don't want to merge this with the failing test. Can you see if it's fixed in main or reach out on Slack and see if someone is fixing it?

…uestHoldStatus-pure-function

linhvovan29546 · 2026-03-13T00:20:24Z

@tgolen all tests passed👍

github-actions · 2026-03-13T15:52:03Z

🚧 @tgolen has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-13T15:57:02Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84507.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-c5fca4f-59ef620-12bb30575c9076ae5ffd6804a4fc50300c00ef64/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-c5fca4f-59ef620-651f36cb8962680bd5bfcdbf24cbc22463a8c56c/index.html

Web 🕸️
https://84507.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-16T10:31:37Z

🚀 Deployed to staging by https://github.com/tgolen in version: 9.3.38-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-17T11:27:43Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.38-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

chore: make changeMoneyRequestHoldStatus pure function receive iouTra…

9834215

…nsaction

melvin-bot bot assigned linhvovan29546 Mar 8, 2026

Merge branch 'Expensify:main' into refactor/66418-make-changeMoneyReq…

43385fa

…uestHoldStatus-pure-function

linhvovan29546 changed the title ~~chore: make changeMoneyRequestHoldStatus pure function receive iouTra…~~ Refactor: make changeMoneyRequestHoldStatus pure function receive iouTransaction Mar 10, 2026

chore: eslint fail

b42db89

chatgpt-codex-connector bot reviewed Mar 10, 2026

View reviewed changes

src/components/MoneyReportHeader.tsx Outdated Show resolved Hide resolved

fix: look up the correct transaction for each action when bulk toggli…

59964c9

…ng hold status

This comment was marked as outdated.

Sign in to view

fix: look up the correct transaction for each action when bulk toggli…

bb8f43c

…ng hold status

linhvovan29546 marked this pull request as ready for review March 10, 2026 14:14

linhvovan29546 requested review from a team as code owners March 10, 2026 14:14

melvin-bot bot requested review from DylanDylann and trjExpensify and removed request for a team March 10, 2026 14:14

melvin-bot bot removed the request for review from a team March 10, 2026 14:14

github-actions bot reviewed Mar 10, 2026

View reviewed changes

src/components/MoneyReportHeader.tsx Outdated Show resolved Hide resolved

github-actions bot reviewed Mar 10, 2026

View reviewed changes

tests/unit/ReportUtilsTest.ts Outdated Show resolved Hide resolved

github-actions bot reviewed Mar 10, 2026

View reviewed changes

tests/ui/components/BaseReportActionContextMenuTest.tsx Outdated Show resolved Hide resolved

github-actions bot reviewed Mar 10, 2026

View reviewed changes

tests/ui/components/BaseReportActionContextMenuTest.tsx Outdated Show resolved Hide resolved

linhvovan29546 added 2 commits March 10, 2026 21:28

chore: add comment to explain ignore type error

22c8082

refactor: extract getLinkedIOUTransaction to deduplicate transaction …

47c5914

…lookup

trjExpensify removed their request for review March 11, 2026 23:14

linhvovan29546 added 3 commits March 12, 2026 16:03

chore: write unit test for getLinkedIOUTransaction

b8ead11

chore: add condition for iouTransaction

092a22a

Merge branch 'main' into refactor/66418-make-changeMoneyRequestHoldSt…

cf4f4bd

…atus-pure-function

DylanDylann approved these changes Mar 12, 2026

View reviewed changes

melvin-bot bot requested a review from Valforte March 12, 2026 11:33

Merge branch 'main' into refactor/66418-make-changeMoneyRequestHoldSt…

7e6f5ab

…atus-pure-function

tgolen approved these changes Mar 12, 2026

View reviewed changes

Merge branch 'Expensify:main' into refactor/66418-make-changeMoneyReq…

707a79b

…uestHoldStatus-pure-function

tgolen merged commit c5fca4f into Expensify:main Mar 13, 2026
30 checks passed

This was referenced Mar 13, 2026

[Due for payment 2026-03-25] Investigate workflow job failing on main: test / test (job 7) #85243

Open

Investigate workflow job failing on main: test / test (job 7) #85246

Closed

linhvovan29546 deleted the refactor/66418-make-changeMoneyRequestHoldStatus-pure-function branch March 13, 2026 16:44

OSBotify mentioned this pull request Mar 16, 2026

Deploy Checklist: New Expensify 2026-03-16 #85347

Closed

74 tasks

melvin-bot bot mentioned this pull request Mar 17, 2026

Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.TRANSACTION in src/libs/ReportUtils.ts #66418

Open

Conversation

linhvovan29546 commented Mar 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Mar 8, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

linhvovan29546 commented Mar 10, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

This comment was marked as outdated.

linhvovan29546 commented Mar 10, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 10, 2026

Uh oh!

melvin-bot bot commented Mar 10, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

trjExpensify commented Mar 11, 2026

Uh oh!

DylanDylann commented Mar 12, 2026

Uh oh!

DylanDylann commented Mar 12, 2026

Uh oh!

linhvovan29546 commented Mar 12, 2026

Uh oh!

linhvovan29546 commented Mar 12, 2026

Uh oh!

MelvinBot commented Mar 12, 2026

What IS correct

What the statement MISSES

Is the parentReportAction fallback reachable?

Conclusion

Uh oh!

DylanDylann commented Mar 12, 2026

Uh oh!

DylanDylann commented Mar 12, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann commented Mar 12, 2026

Uh oh!

DylanDylann left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Mar 12, 2026

Uh oh!

linhvovan29546 commented Mar 12, 2026

Uh oh!

DylanDylann commented Mar 12, 2026

Uh oh!

tgolen commented Mar 12, 2026

Uh oh!

linhvovan29546 commented Mar 13, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 13, 2026

Uh oh!

github-actions bot commented Mar 13, 2026

Uh oh!

OSBotify commented Mar 16, 2026

Uh oh!

OSBotify commented Mar 17, 2026

Uh oh!

Reviewers

linhvovan29546 commented Mar 8, 2026 •

edited

Loading

codecov bot commented Mar 8, 2026 •

edited by github-actions bot

Loading

Is the `parentReportAction` fallback reachable?