Conversation
|
🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here. |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
This comment has been minimized.
This comment has been minimized.
|
🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
Applause confirmed here that the deploy blockers initially introduced are now fixed |
melvin-bot
bot
requested review from
MonilBhavsar and
heyjennahay
and removed request for
a team
|
@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b4c07555be
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if (!initialTransaction?.isFromGlobalCreate && !isArchivedExpenseReport && iouType !== CONST.IOU.TYPE.CREATE) { | ||
| // If the user started this flow using the Create expense option (combined submit/track flow) or the green receipt FAB, | ||
| // they should be redirected to the participants page (or default policy flow), not the "from report" path. | ||
| if (!initialTransaction?.isFromGlobalCreate && !initialTransaction?.isFromFloatingActionButton && !isArchivedExpenseReport && iouType !== CONST.IOU.TYPE.CREATE) { |
There was a problem hiding this comment.
This condition now routes any scan started with isFromFloatingActionButton away from the “participants auto-assigned from report” branch, which regresses FAB quick actions like the policy-chat “Scan receipt” flow (startMoneyRequest(..., skipConfirmation=true, isFromFloatingActionButton=true) in FloatingActionButtonAndPopover). In those cases we already have a target report, but this change falls through to navigateToParticipantPage, adding an unexpected participant step (and showing the skip-confirmation warning) instead of proceeding with the preselected report.
Useful? React with 👍 / 👎.
rlinoz
left a comment
rlinoz
left a comment
There was a problem hiding this comment.
Looks good, you might want to take a look at codex comment though.
|
|
||
| const quickActionReportID = policyChatForActivePolicy?.reportID ?? reportID; | ||
| Tab.setSelectedTab(CONST.TAB.IOU_REQUEST_TYPE, CONST.IOU.REQUEST_TYPE.SCAN); | ||
| // Scan shortcut span: green receipt button (web sidebar) and camera FAB (narrow/mobile) |
There was a problem hiding this comment.
| // Scan shortcut span: green receipt button (web sidebar) and camera FAB (narrow/mobile) | |
| // Scan shortcut span: green receipt button (web sidebar) and camera FAB (narrow/mobile) |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
Julesssss
deleted the
revert-84397-revert-84317-cristi_measure-scan-shortcut
branch
|
🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.36-0 🚀
|
|
Deploy Blocker #84961 was identified to be related to this PR. |
|
Deploy Blocker #85026 was identified to be related to this PR. |
|
Deploy Blocker ##85050 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.36-10 🚀
|
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.37-0 🚀
|
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.37-10 🚀
|
6 participants
Reverts #84397
Explanation of Change
Adds Sentry metrics for Scan quick action.
Fixed Issues
#83502
PROPOSAL:
Tests
Test that Creating expenses, including Scans works as expected from the Global Create and from the Quick Scan FAB button.
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
N/A - regression tests should reveal any potential new bugs.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari