[No QA] [Sentry] Stop starting ManualOpenReport for non-OpenReport actions#84595
Merged
rlinoz merged 1 commit intoExpensify:mainfrom Mar 9, 2026
Merged
Conversation
melvin-bot
bot
requested review from
abdulrahuman5196 and
joekaufmanexpensify
and removed request for
a team
|
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Author
|
cc: @rlinoz PR is ready to review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e1ac599b30
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const reportID = reportIDMatch?.at(1); | ||
| // Start a Sentry span for report navigation — only for exact report-open routes, not sub-pages. | ||
| // Matches: r/<id>, search/r/<id>, search/view/<id>, e/<id> | ||
| const reportOpenMatch = Str.cutAfter(route, '?').match(/^(search\/(?:r|view)|r|e)\/(\w+)$/); |
There was a problem hiding this comment.
The new regex only matches r/<reportID> and search/view|r/<reportID> exactly, so valid open-report URLs that include an action ID (for example r/<reportID>/<reportActionID> and search/view/<reportID>/<reportActionID>) no longer start ManualOpenReport spans. Those routes are still first-class report opens (ROUTES.REPORT_WITH_ID.route and ROUTES.SEARCH_REPORT.route both define optional :reportActionID), so this change drops telemetry for deep links/parent-action navigation paths and can skew open-report performance data.
Useful? React with 👍 / 👎.
Contributor
There was a problem hiding this comment.
I think this is very infrequent and fine for now, we might even want to have a different metric for deeplinking into a report.
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
rlinoz
approved these changes
Mar 9, 2026
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
75 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.3.34-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.34-2 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
The old regex /^(?:search/)?(?:r|e)/(\w+)/ had no end anchor, so it matched any route starting with those prefixes — including sub-pages like r/123/details. The fix adds $ after the ID capture group, ensuring only routes that end at the reportID qualify.
search/view/was also missing from the condition entirely, so those routes never got spans. The new regex handles all four patterns in one place, and spanName is derived from the captured prefix instead of repeated startsWith checks.Fixed Issues
$ #79653
PROPOSAL:
Tests
Offline tests
N/A
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari