Fix Reimbursable toggle hidden for personal card transactions#84596

Merged

Gonals merged 3 commits intomainfrom

claude-fixReimbursableToggleForPersonalCards

Mar 17, 2026

Contributor

MelvinBot commented Mar 9, 2026

Explanation of Change

In MoneyRequestView, the shouldShowReimbursable condition was using isFromCreditCardImport to determine whether to hide the Reimbursable toggle. That helper returns true for both managed/company cards and personal cards imported via bank connection. This caused the Reimbursable toggle to be incorrectly hidden for personal card transactions.

This PR switches to using isManagedCardTransaction instead, which only returns true for centrally managed cards (Expensify or Company Cards). This ensures the Reimbursable toggle remains visible for personal card imports while still being hidden for managed card transactions.

Fixed Issues

$ #81997
PROPOSAL: #81997 (comment)

Tests

Log in as an admin of a workspace that has personal card transactions
Go to Reports > Approve
Click on a report containing a personal card transaction
Select a line item to open the expense
Verify the "Reimbursable" toggle is visible and can be switched between Reimbursable and Non-reimbursable
Verify that managed/company card transactions still do NOT show the Reimbursable toggle

Verify that no errors appear in the JS console

Offline tests

N/A — this change only affects UI visibility logic and does not involve network requests.

QA Steps

Log in as an admin of a workspace with personal card transactions
Go to Reports > Approve
Open a report with a personal card expense
Select the expense line item
Verify the "Reimbursable" option is visible and functional
Verify managed/company card transactions still hide the Reimbursable toggle

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

N/A — no UI layout changes, only visibility logic fix

Android: mWeb Chrome

N/A — no UI layout changes, only visibility logic fix

iOS: Native

N/A — no UI layout changes, only visibility logic fix

iOS: mWeb Safari

N/A — no UI layout changes, only visibility logic fix

MacOS: Chrome / Safari

N/A — no UI layout changes, only visibility logic fix


          Use isManagedCardTransaction instead of isFromCreditCardImport for re…

4f08814

…imbursable toggle visibility

The Reimbursable toggle was hidden for personal card transactions because
isFromCreditCardImport returns true for both managed and personal cards.
Switching to isManagedCardTransaction ensures the toggle is only hidden
for managed/company card transactions while remaining visible for personal
card imports.

Co-authored-by: Alberto Gonzalez-Cela <Gonals@users.noreply.github.com>

MelvinBot assigned Gonals

MelvinBot requested a review from a team

March 9, 2026 13:38

MelvinBot mentioned this pull request

[Due for payment 2026-03-30] [$250] Admins unable to edit Reimbursable status for personal card in ND #81997

Open

7 tasks


          Fix: sort isManagedCardTransaction import alphabetically for Prettier

d482b22

Co-authored-by: Alberto Gonzalez-Cela <Gonals@users.noreply.github.com>

Contributor Author

MelvinBot commented Mar 9, 2026

Fixed the failing Prettier check: the isManagedCardTransaction import was placed out of alphabetical order in the named imports from @libs/TransactionUtils. Sorted it to the correct position.

Contributor

abzokhattab commented Mar 13, 2026 •

edited

Loading

@MelvinBot I found some regressions. Can you review this and implement it if you cannot flag any other issues.

Root Cause

In MoneyRequestView.tsx, the shouldShowReimbursable condition uses a misleadingly-named local variable isManagedCardTransaction that is actually bound to isFromCreditCardImport:

    isFromCreditCardImport as isCardTransactionTransactionUtils,

    const isManagedCardTransaction = isCardTransactionTransactionUtils(transaction);

    const shouldShowReimbursable =
        (isPolicyExpenseChat || (isExpenseUnreported && !!policy)) &&
        (policy?.disabledFields?.reimbursable !== true || isCurrentTransactionReimbursableDifferentFromPolicyDefault) &&
        !isManagedCardTransaction &&
        !isInvoice;

isFromCreditCardImport returns true for all card-imported transactions -- including personal cards (any transaction with bank, cardNumber, or transactionType === CARD). This causes shouldShowReimbursable to evaluate to false for personal card expenses, hiding the reimbursable toggle even for admins.

The real isManagedCardTransaction in TransactionUtils only checks !!transaction?.managedCard, which is true only for centrally managed cards (Expensify Card / company card feeds) -- not personal cards.

The expense creation flow in MoneyRequestConfirmationListFooter.tsx already uses the correct function:

    const shouldShowReimbursable =
        (isPolicyExpenseChat || isTrackExpense) && !!policy && policy?.disabledFields?.reimbursable !== true && !isManagedCardTransaction(transaction) && !isTypeInvoice;

So there's an inconsistency: the creation flow correctly shows the toggle for personal cards, but the detail/edit view hides it.

Fix

In src/components/ReportActionItem/MoneyRequestView.tsx:

Import the real isManagedCardTransaction from TransactionUtils
Rename the existing local variable from isManagedCardTransaction to isFromCardImport to eliminate the naming confusion (no behavioral change)
Use the real isManagedCardTransaction in the shouldShowReimbursable condition only

The other usages of the renamed variable (shouldShowCard, shouldShowConvertedAmount, posted date/original amount display) remain unchanged since they intentionally apply to all card imports.

 import {
     ...
     isFromCreditCardImport as isCardTransactionTransactionUtils,
     isCategoryBeingAnalyzed,
+    isManagedCardTransaction as isManagedCardTransactionTransactionUtils,
     ...
 } from '@libs/TransactionUtils';

-    const isManagedCardTransaction = isCardTransactionTransactionUtils(transaction);
+    const isFromCardImport = isCardTransactionTransactionUtils(transaction);
     const cardProgramName = getCompanyCardDescription(...);
-    const shouldShowCard = isManagedCardTransaction && cardProgramName;
+    const shouldShowCard = isFromCardImport && cardProgramName;

     const shouldShowReimbursable =
         (isPolicyExpenseChat || (isExpenseUnreported && !!policy)) &&
         (policy?.disabledFields?.reimbursable !== true || ...) &&
-        !isManagedCardTransaction &&
+        !isManagedCardTransactionTransactionUtils(transaction) &&
         !isInvoice;

     // shouldShowConvertedAmount and posted date block: unchanged, use isFromCardImport

What changes behaviorally: Only shouldShowReimbursable -- personal card transactions now correctly show the reimbursable toggle, matching the creation flow in MoneyRequestConfirmationListFooter.

What doesn't change: Card name display, converted amount visibility, and posted date/original amount descriptions all continue using isFromCardImport (the broad check), preserving existing behavior for all card types.


          Refine reimbursable toggle fix to only change shouldShowReimbursable

a7f92fa

The previous approach replaced isFromCreditCardImport with
isManagedCardTransaction for ALL usages, which unintentionally
changed the behavior of shouldShowCard, shouldShowConvertedAmount,
and the posted date/original amount display.

This commit takes a more surgical approach:
- Renames local variable to isFromCardImport (uses broad isFromCreditCardImport)
- Only shouldShowReimbursable uses the narrow isManagedCardTransaction check
- Card name, converted amount, and posted date continue using isFromCardImport

Co-authored-by: Abdelrahman Khattab <abzokhattab@users.noreply.github.com>

Contributor

abzokhattab commented Mar 13, 2026

Melven only works if I post on the main issue, as I am not the main author 🥲

MelvinBot marked this pull request as ready for review

March 13, 2026 04:03

MelvinBot requested a review from a team as a code owner

March 13, 2026 04:03

melvin-bot bot requested review from abzokhattab and removed request for a team

March 13, 2026 04:03

melvin-bot bot commented Mar 13, 2026

@abzokhattab Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot bot requested review from heyjennahay and removed request for a team

March 13, 2026 04:03

abzokhattab approved these changes

View reviewed changes

melvin-bot bot requested a review from Gonals

March 13, 2026 04:03

codecov bot commented Mar 13, 2026 •

edited by github-actions bot

Loading

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...c/components/ReportActionItem/MoneyRequestView.tsx	`0.23% <0.00%> (-0.21%)`	⬇️
... and 447 files with indirect coverage changes

Contributor

Gonals commented Mar 17, 2026

Melven only works if I post on the main issue, as I am not the main author 🥲

It seems like it did make some changes, right?

Contributor

abzokhattab commented Mar 17, 2026

yes but i had to post on the issue not the PR as you are the author here...

i think its still expected

Gonals approved these changes

View reviewed changes

Gonals merged commit 4fb0b95 into main

40 checks passed

Gonals deleted the claude-fixReimbursableToggleForPersonalCards branch

March 17, 2026 14:20

Contributor

github-actions bot commented Mar 17, 2026

🚧 @Gonals has triggered a test Expensify/App build. You can view the workflow run here.

Contributor

OSBotify commented Mar 17, 2026

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Contributor

github-actions bot commented Mar 17, 2026

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84596.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-4fb0b95-9897949-b02c639a30c2720b7ee00acaa38a1d7e6c22c0ff/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-4fb0b95-9897949-603c258d5b36abde9f5919fbb06309ee3f5d067a/index.html

Web 🕸️
https://84596.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

narefyev91 mentioned this pull request

[Personal card import] Missing reimbursable toggle on personal card expenses #84890

Closed

7 tasks

OSBotify mentioned this pull request

Deploy Checklist: New Expensify 2026-03-18 #85646

Closed

100 tasks

Contributor

OSBotify commented Mar 18, 2026

🚀 Deployed to staging by https://github.com/Gonals in version: 9.3.40-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

kavimuru commented Mar 18, 2026

@Gonals @heyjennahay , Applause QA does not have personal card transactions, could this be verified internally?

Log in as an admin of a workspace that has personal card transactions

Contributor

OSBotify commented Mar 18, 2026

🚀 Deployed to staging by https://github.com/Gonals in version: 9.3.40-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot mentioned this pull request

[Due for payment 2026-03-30] [$250] Expenses - Uploaded receipt is not displayed when create manual expense #85669

Open

7 tasks

Contributor

joekaufmanexpensify commented Mar 19, 2026

Works well for me on staging. Checked off for QA!

Contributor

OSBotify commented Mar 23, 2026

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.41-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet