Show View button instead of status badge in Action column for Paid/Done reports by MelvinBot · Pull Request #84626 · Expensify/App

MelvinBot · 2026-03-09T18:35:17Z

Explanation of Change

The Action column in the Reports search table was rendering a colored status badge (BadgeActionCell) for reports with Paid or Done status, duplicating the information already shown in the dedicated Status column. This change removes the badge rendering for these terminal states and instead shows a "View" button, consistent with other non-actionable states. Other action buttons (Submit, Approve, Pay) remain unchanged.

Specifically:

Removed the isBadgeAction check and BadgeActionCell rendering from ActionCell
Expanded shouldUseViewAction to include PAID and DONE action types so they render a "View" button
Removed the now-unused parentAction prop from ActionCell and its caller in TransactionItemRow

Fixed Issues

$ #84623
PROPOSAL: #84623 (comment)

Tests

Navigate to the Reports page in New Expensify (Search > Reports)
Find a report with "Paid" status in the table
Verify the Status column shows a green "Paid" badge
Verify the Action column shows a "View" button (not a duplicate "Paid" badge)
Find a report with "Done" status
Verify the Status column shows a "Done" badge
Verify the Action column shows a "View" button (not a duplicate "Done" badge)
Find a report with "Open" or "Processing" status that has a Submit/Approve/Pay action
Verify those action buttons still appear correctly in the Action column

Verify that no errors appear in the JS console

Offline tests

This change is purely UI rendering — no network calls are involved. Offline behavior is unaffected since the Action column simply renders a different component (Button instead of Badge) for the same data.

QA Steps

Navigate to the Reports page in New Expensify (Search > Reports)
Find reports with "Paid" or "Done" status
Verify the Action column shows a "View" button instead of a colored status badge
Verify the Status column still shows the correct status badge
Verify reports with Submit/Approve/Pay actions still show those buttons correctly in the Action column

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

N/A - Web only change (Action column rendering)

Android: mWeb Chrome

N/A - Wide screen table layout only

iOS: Native

N/A - Web only change (Action column rendering)

iOS: mWeb Safari

N/A - Wide screen table layout only

MacOS: Chrome / Safari

Verified: Reports with Paid/Done status now show "View" button in Action column instead of duplicate status badge. Status column still displays the correct badge.

…ne reports The Action column was rendering a colored status badge (BadgeActionCell) for reports with Paid or Done status, duplicating the information already shown in the dedicated Status column. This replaces the badge with a View button for these terminal states, keeping other action buttons (Submit, Approve, Pay) unchanged. Co-authored-by: Shawn Borton <shawnborton@users.noreply.github.com>

github-actions · 2026-03-09T18:37:22Z

🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

Co-authored-by: Shawn Borton <shawnborton@users.noreply.github.com>

MelvinBot · 2026-03-09T18:38:04Z

Fixed the failing Prettier check: ran Prettier on ActionCell/index.tsx to fix line formatting.

Co-authored-by: Shawn Borton <shawnborton@users.noreply.github.com>

…eFromActionColumn' into claude-removeDuplicateStatusBadgeFromActionColumn Co-authored-by: Shawn Borton <shawnborton@users.noreply.github.com>

MelvinBot · 2026-03-09T18:38:42Z

Fixed the failing Prettier check: the shouldUseViewAction assignment in ActionCell/index.tsx had an unnecessary line break that Prettier wanted on a single line.

melvin-bot · 2026-03-09T19:34:03Z

@FitseTLT Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shawnborton · 2026-03-09T19:34:05Z

Tested and looks good to me, let's get this into review @FitseTLT

trjExpensify

Shawn created this one. 👍

FitseTLT · 2026-03-10T19:47:17Z

@MelvinBot can u remove unnecessary code, now that we don't need badge for paid and done actions?

BadgeActionCell.tsx is no longer imported or used after removing badge rendering for Paid/Done actions. Delete the dead file. Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>

MelvinBot · 2026-03-10T19:50:16Z

Deleted the unused BadgeActionCell.tsx file — it was no longer imported after removing badge rendering for Paid/Done actions but the file itself was still in the repo.

Note: The actionTranslationsMap entries for DONE and PAID are technically unreachable from ActionCell now (since those actions always use the VIEW translation), but they need to stay because the map is typed as Record<SearchTransactionAction, TranslationPaths>, which requires all action types to be present.

melvin-bot · 2026-03-10T19:50:40Z

@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

FitseTLT · 2026-03-10T20:09:41Z

@MelvinBot I also see isLargeScreenWidth prop for action cell is useless and also the paid and done parts in actionTranslationsMap. But pls make sure my assumption is correct.

No caller passes isLargeScreenWidth to ActionCell — it always defaults to true, making the null branch dead code. Remove the prop and the conditional. Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>

MelvinBot · 2026-03-10T20:14:13Z

Verified both assumptions:

isLargeScreenWidth — confirmed unnecessary, removed. No caller passes this prop to ActionCell — it always defaulted to true, making the : null branch dead code. I've removed the prop, default, and the conditional.

PAID/DONE in actionTranslationsMap — confirmed unreachable, but should stay. These entries are never accessed at runtime (PAID/DONE now always use the VIEW translation key). However, the map is typed as Record<SearchTransactionAction, TranslationPaths>, which requires an entry for every action type. Removing PAID/DONE would require either:

Partial<Record<...>> → forces null checks at every translate(actionTranslationsMap[...]) call
Exclude<> type → adds type complexity for little gain

Since the entries are harmless and maintain type completeness, I'd recommend keeping them. Let me know if you'd prefer a different approach.

FitseTLT · 2026-03-10T20:48:18Z

@codex review

chatgpt-codex-connector · 2026-03-10T21:00:23Z

Codex Review: Didn't find any major issues. What shall we delve into next?

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

FitseTLT · 2026-03-10T21:47:48Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ x If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

shawnborton · 2026-03-16T12:45:47Z

@carlosmiceli can you please approve and merge? Thanks!

github-actions · 2026-03-17T18:00:12Z

🚧 @carlosmiceli has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-03-17T18:02:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-03-17T18:08:18Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84626.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-9118512-da2c958-7d7090c1895899b695622f0db921a6b89697c504/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-9118512-da2c958-765ddd9b4770d84050ec15b59ee9ff4d1cd11af2/index.html

Web 🕸️
https://84626.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-18T13:29:43Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.3.40-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-18T14:05:43Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.3.40-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-23T09:26:33Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.41-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot assigned shawnborton Mar 9, 2026

MelvinBot requested a review from a team March 9, 2026 18:35

MelvinBot mentioned this pull request Mar 9, 2026

[Due for payment 2026-03-30] [$250] Duplicate report status badge shown in Action column #84623

Open

7 tasks

Fix: Run Prettier on ActionCell to fix formatting

6f73abe

Co-authored-by: Shawn Borton <shawnborton@users.noreply.github.com>

MelvinBot and others added 2 commits March 9, 2026 18:38

Fix: Prettier formatting in ActionCell

0a31bff

Co-authored-by: Shawn Borton <shawnborton@users.noreply.github.com>

Merge remote-tracking branch 'origin/claude-removeDuplicateStatusBadg…

8afac87

…eFromActionColumn' into claude-removeDuplicateStatusBadgeFromActionColumn Co-authored-by: Shawn Borton <shawnborton@users.noreply.github.com>

This comment has been minimized.

Sign in to view

shawnborton marked this pull request as ready for review March 9, 2026 19:33

shawnborton requested a review from a team as a code owner March 9, 2026 19:33

melvin-bot bot requested review from FitseTLT and removed request for a team March 9, 2026 19:34

melvin-bot bot requested review from trjExpensify and removed request for a team March 9, 2026 19:34

trjExpensify previously approved these changes Mar 10, 2026

View reviewed changes

Remove unused BadgeActionCell component

b71b810

BadgeActionCell.tsx is no longer imported or used after removing badge rendering for Paid/Done actions. Delete the dead file. Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>

MelvinBot dismissed trjExpensify’s stale review via b71b810 March 10, 2026 19:50

MelvinBot requested a review from a team as a code owner March 10, 2026 19:50

melvin-bot bot requested review from carlosmiceli and removed request for a team March 10, 2026 19:50

Remove unused isLargeScreenWidth prop from ActionCell

551ce46

No caller passes isLargeScreenWidth to ActionCell — it always defaults to true, making the null branch dead code. Remove the prop and the conditional. Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>

FitseTLT approved these changes Mar 10, 2026

View reviewed changes

carlosmiceli approved these changes Mar 17, 2026

View reviewed changes

carlosmiceli merged commit 9118512 into main Mar 17, 2026
34 checks passed

carlosmiceli deleted the claude-removeDuplicateStatusBadgeFromActionColumn branch March 17, 2026 17:51

OSBotify mentioned this pull request Mar 18, 2026

Deploy Checklist: New Expensify 2026-03-18 #85646

Closed

100 tasks

Conversation

MelvinBot commented Mar 9, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Mar 9, 2026

Uh oh!

MelvinBot commented Mar 9, 2026

Uh oh!

MelvinBot commented Mar 9, 2026

Uh oh!

This comment has been minimized.

melvin-bot bot commented Mar 9, 2026

Uh oh!

shawnborton commented Mar 9, 2026

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

FitseTLT commented Mar 10, 2026

Uh oh!

MelvinBot commented Mar 10, 2026

Uh oh!

melvin-bot bot commented Mar 10, 2026

Uh oh!

FitseTLT commented Mar 10, 2026

Uh oh!

MelvinBot commented Mar 10, 2026

Uh oh!

FitseTLT commented Mar 10, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 10, 2026

Uh oh!

FitseTLT commented Mar 10, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

shawnborton commented Mar 16, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

OSBotify commented Mar 17, 2026

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

OSBotify commented Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants