Skip to content

[No QA] Recreate workspace merchant rules article#84674

Merged
stephanieelliott merged 8 commits intomainfrom
helpsite-workspace-merchant-rules-no-netsuite
Mar 11, 2026
Merged

[No QA] Recreate workspace merchant rules article#84674
stephanieelliott merged 8 commits intomainfrom
helpsite-workspace-merchant-rules-no-netsuite

Conversation

@stephanieelliott
Copy link
Contributor

Related product change PR: #83005

Un-does #82856

These files were already reviewed and approved in the original PR (later reverted) #82356

@stephanieelliott stephanieelliott self-assigned this Mar 10, 2026

Enable Workspace Merchant Rules to help Workspace Admins standardize how expenses from common merchants are coded across the workspace. These rules automatically apply consistent categories, tags, and other expense fields based on the merchant name, reducing manual cleanup and improving reporting accuracy.

These rules work in New Expensify, can only be configured in New Expensify, and apply consistently across all workspace members.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability violation: "These rules work in New Expensify, can only be configured in New Expensify, and apply consistently across all workspace members" is redundant -- it mentions "New Expensify" twice in the same sentence. Consider simplifying: "These rules can only be configured in New Expensify and apply consistently across all workspace members."

@github-actions
Copy link
Contributor

HelpDot Documentation Review

Overall Assessment

This PR introduces a well-structured new article for Workspace Merchant Rules and integrates cross-references across five existing documentation files. The overall documentation strategy is sound -- the new article is comprehensive, the cross-linking is thorough, and the writing is clear and accessible. There is one critical defect (a broken image path) and a handful of minor consistency issues that should be addressed before merge.

Scores Summary

  • Readability: 8/10 - The writing is clear, well-organized, and uses appropriate language for the target audience. The step-by-step instructions are easy to follow. The examples section is a standout -- practical, concrete, and genuinely helpful. Minor deductions for some repetitive phrasing across files and one inconsistent bullet punctuation.
  • AI Readiness: 9/10 - Strong YAML metadata across all files. The internalScope fields follow the prescribed format and clearly delineate audience, coverage, and exclusions. Headings are descriptive and use full feature names. Keywords are well-chosen and updated appropriately. The heading hierarchy in the new article uses only # and ##, which is correct.
  • Style Compliance: 7/10 - Generally follows Expensify conventions (correct use of "workspace," "member," bold for UI labels, numbered steps for procedures). Deductions for a broken image link, a missing period on a bullet, and an FAQ heading with inconsistent capitalization.

Key Findings

Critical issue:

  • In Workspace-Rules.md, the added image reference contains a broken path: ExpensifyHelp-FlagExpensesMissing\|temizedReceipts_01.png. The pipe character should be the letter I -- the correct filename on disk is ExpensifyHelp-FlagExpensesMissingItemizedReceipts_01.png. This will render as a broken image in production.

Minor issues:

  • In Create-expense-tags.md, the second bullet in the new "Workspace Merchant Rules for tags" section is missing a trailing period: "Rules take precedence over learned suggestions" -- every other bullet in this section and the parallel section in Create-expense-categories.md ends with a period.
  • In Workspace-Merchant-Rules.md, step 9 reads "Select Save Rule" but is missing a trailing period, unlike the other steps.
  • In Workspace-Merchant-Rules.md, the FAQ heading "Who Can Enable Workspace Merchant Rules?" uses title case ("Can"), while every other FAQ heading in the same section uses sentence case. This should be "Who can enable Workspace Merchant Rules?" for consistency.
  • The phrase "Workspace Merchant Rules" appears very frequently in the new article (30+ times in 154 lines). While this aids AI discoverability, it reads somewhat repetitively in places. Consider using "these rules" or "merchant rules" (lowercase) after the first mention within a given section for readability.

Positive aspects:

  • The cross-referencing strategy is excellent. Every relevant article now points back to the new Workspace Merchant Rules article, and the new article links outward to related content (Workspace Rules, Personal Expense Rules). This creates a well-connected documentation network.
  • The examples section in the new article is exceptionally well done -- four real-world scenarios with specific merchant names, clear rule configurations, and brief explanations of the benefit. This is the kind of practical content that helps users understand the feature quickly.
  • The FAQ section in the new article is thorough and anticipates common user questions, especially the troubleshooting question "Why didn't my Workspace Merchant Rule apply?" with its enumerated list of causes.
  • The internalScope updates to existing files properly exclude the new topic area, maintaining clear boundaries between articles.
  • The new article's intro paragraph efficiently communicates what the feature does, who it is for, and where it works -- all in two sentences.

Recommendations

  1. [Must fix] Correct the broken image path in Workspace-Rules.md -- replace the pipe character with I so the filename reads ExpensifyHelp-FlagExpensesMissingItemizedReceipts_01.png.
  2. [Must fix] Add the missing period to the bullet in Create-expense-tags.md ("Rules take precedence over learned suggestions" -> "Rules take precedence over learned suggestions.").
  3. [Should fix] Add the missing period to step 9 in Workspace-Merchant-Rules.md ("Select Save Rule" -> "Select Save Rule.").
  4. [Should fix] Normalize the FAQ heading capitalization: "Who Can Enable Workspace Merchant Rules?" -> "Who can enable Workspace Merchant Rules?"
  5. [Optional] Consider reducing repetition of the full phrase "Workspace Merchant Rules" within sections of the new article where context is already established.

Files Reviewed

File Status
docs/articles/expensify-classic/expenses/Expense-Rules.md Good -- clean cross-reference addition with updated internalScope
docs/articles/new-expensify/reports-and-expenses/Create-an-Expense.md Good -- appropriate note and bullet additions
docs/articles/new-expensify/workspaces/Create-expense-categories.md Good -- well-placed section with clear bullets
docs/articles/new-expensify/workspaces/Create-expense-tags.md Minor fix needed -- missing period on one bullet
docs/articles/new-expensify/workspaces/Workspace-Merchant-Rules.md Strong new article -- minor punctuation and capitalization fixes needed
docs/articles/new-expensify/workspaces/Workspace-Rules.md Critical fix needed -- broken image path with pipe character

Review based solely on the proposed diff. Unchanged content was not evaluated.

stephanieelliott and others added 4 commits March 10, 2026 07:27
…s.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…s.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…s.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@stephanieelliott stephanieelliott requested a review from a team March 11, 2026 06:40
@melvin-bot
Copy link

melvin-bot bot commented Mar 11, 2026

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @jliexpensify

@melvin-bot melvin-bot bot requested review from jliexpensify and removed request for a team March 11, 2026 06:40
@melvin-bot
Copy link

melvin-bot bot commented Mar 11, 2026

@jliexpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions github-actions bot changed the title Recreate workspace merchant rules article [No QA] Recreate workspace merchant rules article Mar 11, 2026
Copy link
Contributor

@jliexpensify jliexpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stephanieelliott stephanieelliott merged commit 8a56542 into main Mar 11, 2026
17 checks passed
@stephanieelliott stephanieelliott deleted the helpsite-workspace-merchant-rules-no-netsuite branch March 11, 2026 22:07
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.37-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.37-10 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants