[No QA] Add reasonAttributes to FullscreenLoadingIndicator usage sites#84719
Merged
youssef-lr merged 4 commits intoExpensify:mainfrom Mar 13, 2026
Conversation
sosek108
changed the title
melvin-bot
bot
requested review from
trjExpensify
and removed request for
a team
|
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Contributor
|
PR doesn’t need product input as a performance PR. Unassigning and unsubscribing myself. |
hoangzinh
reviewed
Mar 11, 2026
| return ( | ||
| <> | ||
| {isLoading && <FullScreenLoadingIndicator />} | ||
| {isLoading && <FullScreenLoadingIndicator reasonAttributes={{context: 'WalletStatementModal', isLoading}} />} |
Contributor
There was a problem hiding this comment.
Suggested change
| {isLoading && <FullScreenLoadingIndicator reasonAttributes={{context: 'WalletStatementModal', isLoading}} />} | |
| {isLoading && <FullScreenLoadingIndicator reasonAttributes={{context: 'WalletStatementModal'}} />} |
NAB: I think we don't need this attribute; it's always true
| <FullScreenLoaderStateContext.Provider value={stateContextValue}> | ||
| {children} | ||
| {isLoaderVisible && <FullScreenLoadingIndicator />} | ||
| {isLoaderVisible && <FullScreenLoadingIndicator reasonAttributes={{context: 'FullScreenLoaderContext', isLoaderVisible}} />} |
Contributor
There was a problem hiding this comment.
Suggested change
| {isLoaderVisible && <FullScreenLoadingIndicator reasonAttributes={{context: 'FullScreenLoaderContext', isLoaderVisible}} />} | |
| {isLoaderVisible && <FullScreenLoadingIndicator reasonAttributes={{context: 'FullScreenLoaderContext'}} />} |
NAB: I think we don't need this attribute; it's always true
| {isLoading && ( | ||
| <FullScreenLoadingIndicator | ||
| testID="attachment-loading-spinner" | ||
| reasonAttributes={{context: 'AttachmentModalBaseContent', isLoading}} |
Contributor
There was a problem hiding this comment.
Suggested change
| reasonAttributes={{context: 'AttachmentModalBaseContent', isLoading}} | |
| reasonAttributes={{context: 'AttachmentModalBaseContent'}} |
NAB: I think we don't need this attribute; it's always true
|
|
||
| if (isLoading) { | ||
| return <FullScreenLoadingIndicator />; | ||
| const reasonAttributes: SkeletonSpanReasonAttributes = {context: 'MissingPersonalDetails', isLoading}; |
Contributor
There was a problem hiding this comment.
Suggested change
| const reasonAttributes: SkeletonSpanReasonAttributes = {context: 'MissingPersonalDetails', isLoading}; | |
| const reasonAttributes: SkeletonSpanReasonAttributes = {context: 'MissingPersonalDetails'}; |
NAB: I think we don't need this attribute; it's always true
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
Contributor
Author
|
Fixed |
youssef-lr
previously approved these changes
Mar 13, 2026
…n-loading-reason-attributes # Conflicts: # src/pages/LoadingPage.tsx
Contributor
|
Updated the branch and resolved conflicts. |
youssef-lr
approved these changes
Mar 13, 2026
Contributor
|
🚧 @youssef-lr has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
74 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.3.38-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.38-4 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Adds
reasonAttributesto allFullscreenLoadingIndicatorusage sites so that Sentry skeleton spans carry structured metadata (acontextstring and relevant boolean state flags). This makes it possible to identify which component is showing a loading state and why, enabling engineers to debug infinite skeleton issues in Sentry.The
reasonAttributesprop is also threaded through the image component chain (Image/types.ts→ImageWithSizeCalculation→ThumbnailImage→ReceiptImage) so image-loading skeletons carry context too.Fixed Issues
$ #83395
PROPOSAL:
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari