#7 - Get the billing grace end period collection with useOnyx by bernhardoj · Pull Request #84751 · Expensify/App

bernhardoj · 2026-03-10T14:41:48Z

Explanation of Change

Fixed Issues

$ #66456
PROPOSAL:

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Prerequisite:

have multiple workspaces
have an empty report
have a report to submit, approve, and pay

Run Onyx.merge('sharedNVP_private_billingGracePeriodEnd_[replaceWithYourACcountID]', {value: 1}); in console
Open Reports > Reports
Open the empty report
Press the Add expense button > Add unreported expense
Verify it navigates you to the restricted action page
Close the report
Press + Create button > Create report
Verify it navigates you to the workspace selection page
Open Reports > Submit
Press the Submit action button
Verify it navigates you to the restricted action page
Open Reports > Approve
Press the Approve action button
Verify it navigates you to the restricted action page
Open Reports > Pay
Press the Pay action button (select Mark as paid sub-option if needed)
Verify it navigates you to the restricted action page

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mp4

melvin-bot · 2026-03-10T14:41:56Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2026-03-10T14:42:01Z

Many of the changes are just renaming.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5bf0cfdcc8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-10T14:52:07Z

src/components/SelectionListWithSections/Search/ExpenseReportListItem.tsx

            snapshotReport,
            snapshotPolicy,
            lastPaymentMethod,
+            userBillingGraceEndPeriods,


Include billing grace periods in action callback dependencies

handleOnButtonPress now captures userBillingGraceEndPeriods but the useCallback dependency array was not updated, so when this Onyx collection arrives after initial render the callback can keep using a stale undefined value. In that state, handleActionButtonPress() may evaluate restrictions against outdated fallback data, allowing action-button flows on expense report rows to bypass the intended restricted-action redirect until another dependency happens to recreate the callback.

Useful? React with 👍 / 👎.

@bernhardoj Please address this comment.

Hmm, why is this not caught by ESLisnt 🤔

Fixed

codecov · 2026-03-10T14:56:12Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/MoneyReportHeader.tsx	`0.00% <ø> (ø)`
...ReportPreview/MoneyRequestReportPreviewContent.tsx	`61.51% <ø> (ø)`
.../SearchPageHeader/SearchFiltersBarCreateButton.tsx	`93.87% <100.00%> (+9.78%)`	⬆️
...nListWithSections/Search/ExpenseReportListItem.tsx	`0.00% <ø> (ø)`
...onListWithSections/Search/ReportListItemHeader.tsx	`97.14% <ø> (ø)`
...ionListWithSections/Search/TransactionListItem.tsx	`0.00% <ø> (ø)`
src/libs/ReportUtils.ts	`77.12% <100.00%> (+0.48%)`	⬆️
src/libs/SubscriptionUtils.ts	`79.89% <100.00%> (ø)`
src/pages/ReportDetailsPage.tsx	`57.06% <100.00%> (ø)`
src/pages/inbox/report/PureReportActionItem.tsx	`56.74% <ø> (+0.05%)`	⬆️
... and 9 more
... and 168 files with indirect coverage changes

shubham1206agra · 2026-03-13T09:55:24Z

@bernhardoj Please resolve conflicts

…ng-grace-period-subscription-utils-7

bernhardoj · 2026-03-13T12:26:54Z

@shubham1206agra fixed

bernhardoj · 2026-03-13T12:31:53Z

Checking the failing typecheck

bernhardoj · 2026-03-13T12:32:57Z

Fixed

shubham1206agra · 2026-03-14T12:08:18Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
xIf a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-03-14.at.5.37.10.PM.mov

github-actions · 2026-03-16T23:33:54Z

🚧 @inimaga has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-16T23:38:55Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84751.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-6f0ddc3-03346cd-6e767c9c7e5e45305f3fabe687886df6dead7db1/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-6f0ddc3-03346cd-17cb72b46ff698009f95e6deec623d99527dd40a/index.html

Web 🕸️
https://84751.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-16T23:39:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-03-17T11:55:38Z

🚀 Deployed to staging by https://github.com/inimaga in version: 9.3.39-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

izarutskaya · 2026-03-17T19:26:58Z

@bernhardoj We can't check this in app as console option is no longer available in native. Web - passed. We tried to complete 1 step in Web, than other in apps, but it doesn't work. Let me know if I missed anything. Thank you in advance

Screen.Recording.20260317.235946.Expensify.mp4

OSBotify · 2026-03-18T13:02:44Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.39-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

bernhardoj added 3 commits March 10, 2026 22:06

rename

39c12f8

pass userBillingGraceEndPeriods from useOnyx

c8b2a82

pass userBillingGraceEndPeriods from useOnyx

5bf0cfd

bernhardoj requested review from a team as code owners March 10, 2026 14:41

melvin-bot bot assigned bernhardoj Mar 10, 2026

melvin-bot bot requested review from JmillsExpensify and shubham1206agra and removed request for a team March 10, 2026 14:41

melvin-bot bot removed request for a team and JmillsExpensify March 10, 2026 14:41

prettier

438a1d9

chatgpt-codex-connector bot reviewed Mar 10, 2026

View reviewed changes

pass userBillingGraceEndPeriods from useOnyx

5fedd16

Merge branch 'main' into chore/66456-remove-onyx-connect-shared-billi…

e54f61e

…ng-grace-period-subscription-utils-7

rename

d82a1c2

lint

100de38

shubham1206agra approved these changes Mar 14, 2026

View reviewed changes

melvin-bot bot requested a review from inimaga March 14, 2026 18:12

inimaga approved these changes Mar 16, 2026

View reviewed changes

inimaga merged commit 6f0ddc3 into Expensify:main Mar 16, 2026
33 checks passed

OSBotify mentioned this pull request Mar 17, 2026

Deploy Checklist: New Expensify 2026-03-17 #85529

Closed

75 tasks

Conversation

bernhardoj commented Mar 10, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 10, 2026

Uh oh!

bernhardoj commented Mar 10, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

shubham1206agra Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

bernhardoj Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Mar 10, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

shubham1206agra commented Mar 13, 2026

Uh oh!

bernhardoj commented Mar 13, 2026

Uh oh!

bernhardoj commented Mar 13, 2026

Uh oh!

bernhardoj commented Mar 13, 2026

Uh oh!

shubham1206agra commented Mar 14, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

github-actions bot commented Mar 16, 2026

Uh oh!

github-actions bot commented Mar 16, 2026

Uh oh!

OSBotify commented Mar 16, 2026

Uh oh!

OSBotify commented Mar 17, 2026

Uh oh!

izarutskaya commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Mar 10, 2026 •

edited by github-actions bot

Loading

izarutskaya commented Mar 17, 2026 •

edited

Loading