Skip to content

Catch AbortError from video.play() on web during rapid seeking#84794

Open
MelvinBot wants to merge 7 commits intomainfrom
claude-catchVideoPlayAbortError
Open

Catch AbortError from video.play() on web during rapid seeking#84794
MelvinBot wants to merge 7 commits intomainfrom
claude-catchVideoPlayAbortError

Conversation

@MelvinBot
Copy link
Contributor

Explanation of Change

When playing a video attachment and rapidly seeking via the progress bar, the browser logs AbortError: The play() request was interrupted by a call to pause(). This happens because HTMLVideoElement.play() returns a Promise, and if pause() is called before it resolves, the browser rejects it with an AbortError.

This PR adds a patch-package patch for expo-video's VideoPlayer.web.js that wraps all 5 HTMLVideoElement.play() call sites with .catch() to silently swallow AbortError while re-throwing any other errors. This is the standard fix recommended by Chrome's documentation for this exact error.

The 5 patched call sites are:

  • play() method
  • replace() method
  • replay() method
  • _synchronizeWithFirstVideo() method
  • onplay event listener

Fixed Issues

$ #84294
PROPOSAL: #84294 (comment)

Tests

  1. Open a workspace chat
  2. Add a video attachment (~10MB)
  3. Start playing the video attachment
  4. While the video is playing, rapidly change the seek position by dragging the progress bar back and forth
  5. Verify no AbortError console errors appear
  6. Verify video playback still works correctly after seeking
  • Verify that no errors appear in the JS console

Offline tests

N/A — This fix only affects web video playback error handling and does not involve network requests.

QA Steps

  1. Open a workspace chat on web (Chrome or Safari)
  2. Add a video attachment (~10MB)
  3. Play the video and rapidly scrub the seek bar back and forth
  4. Open browser DevTools console
  5. Verify no AbortError or The play() request was interrupted errors appear
  6. Verify video plays normally after seeking
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A — web-only patch

Android: mWeb Chrome

N/A — web-only patch

iOS: Native

N/A — web-only patch

iOS: mWeb Safari

N/A — web-only patch

MacOS: Chrome / Safari

N/A — web-only patch (this is where the fix applies)

…ors during rapid seeking

Co-authored-by: Abdelrahman Khattab <abzokhattab@users.noreply.github.com>
@MelvinBot MelvinBot requested a review from a team March 10, 2026 20:29
@MelvinBot
Copy link
Contributor Author

I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-catchVideoPlayAbortError
git checkout -b claude-catchVideoPlayAbortError upstream/claude-catchVideoPlayAbortError
git push -u origin claude-catchVideoPlayAbortError

Then you can close this PR and open a new one from your fork.

@MelvinBot MelvinBot marked this pull request as ready for review March 16, 2026 23:32
@MelvinBot
Copy link
Contributor Author

Done! This PR has been marked as ready for review. ✅

@melvin-bot melvin-bot bot requested review from abzokhattab and removed request for a team March 16, 2026 23:32
@melvin-bot
Copy link

melvin-bot bot commented Mar 16, 2026

@abzokhattab Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@abzokhattab
Copy link
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-03-11.at.04.21.34.mov
Android: mWeb Chrome
Screen.Recording.2026-03-11.at.04.14.48.mov
iOS: HybridApp
Screen.Recording.2026-03-11.at.04.20.27.mov
iOS: mWeb Safari
Screen.Recording.2026-03-11.at.04.19.19.mov
MacOS: Chrome / Safari
Screen.Recording.2026-03-11.at.03.50.48.mov

@melvin-bot melvin-bot bot requested a review from Julesssss March 17, 2026 18:31
@abzokhattab
Copy link
Contributor

The PR is ready @Julesssss

Julesssss
Julesssss previously approved these changes Mar 19, 2026
@Julesssss
Copy link
Contributor

@abzokhattab ah conflict to resolve. I can't ask melvin to do this because it will add me as co-auther.

@abzokhattab
Copy link
Contributor

@MelvinBot merge to main and fix the conflicts

MelvinBot and others added 2 commits March 19, 2026 19:17
…AbortError

Co-authored-by: Abdelrahman Khattab <abzokhattab@users.noreply.github.com>

# Conflicts:
#	patches/expo-video/details.md
The expo-video package was upgraded from 3.0.12 to 55.0.3 on main,
removing the old patches directory. This recreates the AbortError
catch patch for the new version, adapting to a minor code change
in the onplay handler that now includes an if-guard.

Co-authored-by: Abdelrahman Khattab <abzokhattab@users.noreply.github.com>
@MelvinBot MelvinBot requested a review from a team as a code owner March 19, 2026 19:19
@melvin-bot melvin-bot bot requested review from abzokhattab and removed request for a team March 19, 2026 19:19
@melvin-bot
Copy link

melvin-bot bot commented Mar 19, 2026

@abzokhattab Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@MelvinBot
Copy link
Contributor Author

Merged main into the branch and resolved the conflicts.

What changed: The expo-video package was upgraded from 3.0.12 to 55.0.3 on main, which removed the old patches/expo-video/ directory entirely. I recreated the AbortError catch patch for the new version (expo-video+55.0.3+001+catch_play_abort_error.patch) and adapted it to a minor code change in the onplay handler (which now includes an if (e.target !== mountedVideo) guard that wasn't present in 3.0.12).

Commits:

  • Merge commit: merges origin/main into the branch
  • 5f94c47: Adds the updated patch files for expo-video 55.0.3

Remove empty first line and fix last hunk line count (7 -> 6) so
patch-package can parse the file.

Co-authored-by: Abdelrahman Khattab <abzokhattab@users.noreply.github.com>
@MelvinBot
Copy link
Contributor Author

Fixed the failing checks. The patch file expo-video+55.0.3+001+catch_play_abort_error.patch had two format issues causing patch-package to fail parsing:

  1. Empty first line — the file had a blank line before the diff --git header. Patch files must start with diff --git on line 1.
  2. Wrong hunk line count — the last hunk header said @@ -305,7 +305,7 @@ but only contained 6 lines on each side. Fixed to @@ -305,6 +305,6 @@.

The patch file could not be parsed by patch-package 8.1.0-canary.1.
Regenerated using git diff --no-index to produce valid hunk headers
and correct blob hashes. Also fixed variable shadowing in the onplay
handler's catch callback (e -> err) to avoid shadowing the event param.

Co-authored-by: Abdelrahman Khattab <abzokhattab@users.noreply.github.com>
@MelvinBot
Copy link
Contributor Author

Fixed the failing checks by regenerating the expo-video patch file.

Root cause: The patch file expo-video+55.0.3+001+catch_play_abort_error.patch could not be parsed by patch-package 8.1.0-canary.1, causing all CI checks to fail during npm install (postInstall). The patch had an incorrect last hunk header (-305,6 instead of -305,7), a missing context line, and placeholder blob hashes in the index line.

Fix: Regenerated the patch using git diff --no-index against the actual source files, producing valid hunk headers and real blob hashes. Also renamed the catch parameter from e to err in the onplay handler to avoid shadowing the outer event parameter.

@MelvinBot
Copy link
Contributor Author

The failing checks were all caused by the expo-video+55.0.3+001+catch_play_abort_error.patch file not being parseable by patch-package. This was already fixed in commit c91142d ("Fix: regenerate expo-video patch with correct format"), which was pushed at 19:36 UTC.

The latest CI run shows validate-patches, Spell check, and Translation Dry Run all passing now. Builds are still in progress but the root cause has been resolved.

@Expensify Expensify deleted a comment from MelvinBot Mar 19, 2026
@Julesssss
Copy link
Contributor

@abzokhattab could you verify Melvin's latest change, I'll generate test builds too for final verififcation

@github-actions
Copy link
Contributor

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

@MelvinBot
Copy link
Contributor Author

The failing checks are unrelated to this PR's changes.

Failing checks:

  1. build (developmentDebug, false) — Android build fails with: Could not read script 'node_modules/expo/scripts/autolinking.gradle' as it does not exist
  2. build (New Expensify Dev, DebugDevelopment, false) — iOS build fails during native compilation (log truncated at 70K+ lines, appears to time out)

Why these are unrelated:

Evidence: All other checks pass (ESLint, typecheck, tests, prettier, spellcheck, perf-tests, storybook, validate-patches, etc.).

@abzokhattab
Copy link
Contributor

@MelvinBot merge to main again

…AbortError

Co-authored-by: Abdelrahman Khattab <abzokhattab@users.noreply.github.com>
@MelvinBot
Copy link
Contributor Author

Merged main into this branch — up to date now.

@MelvinBot
Copy link
Contributor Author

The failing check (build (New Expensify Dev, DebugDevelopment, false)) is unrelated to this PR.

Analysis: This PR only modifies web-only patch files (patches/expo-video/details.md and patches/expo-video/expo-video+55.0.3+001+catch_play_abort_error.patch), which have no impact on the iOS build. The failure is a generic RockError: Failed to build the project in the iOS simulator build step with no specific compilation error in the logs. The remote build cache also failed (Remote Cache: Failed to fetch cached build), forcing a full rebuild that appears to have failed due to infrastructure issues.

Evidence: The two changed files are JavaScript/web-only patches. The iOS build has no compilation errors — only warnings. The build failure is infrastructure-related (cache miss + generic Rock build tool error), not caused by code changes.

Suggestion: Re-running the failing check should resolve this.

@abzokhattab
Copy link
Contributor

@MelvinBot merge to main again

…AbortError

Co-authored-by: Abdelrahman Khattab <abzokhattab@users.noreply.github.com>
@MelvinBot
Copy link
Contributor Author

Merged main into this branch again — up to date now.

@abzokhattab
Copy link
Contributor

@Julesssss the issue is fixed

Screen.Recording.2026-03-24.at.02.45.53.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants